From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Pete Batard <pete@akeo.ie>
Subject: Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
Date: Sun, 21 Feb 2021 21:33:37 +0000 [thread overview]
Message-ID: <20210221213337.GP1664@vanye> (raw)
In-Reply-To: <CAMj1kXEtE72mHFmR57YXh-jGXbbQm0Jeq9K3JDoxRtbjS4JkLQ@mail.gmail.com>
On Sun, Feb 21, 2021 at 21:50:20 +0100, Ard Biesheuvel wrote:
> On Sun, 21 Feb 2021 at 21:43, Leif Lindholm <leif@nuviainc.com> wrote:
> >
> > On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote:
> > > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm <leif@nuviainc.com> wrote:
> > > >
> > > > *How* annoying was this?
> > > >
> > > > This is kind of useful information, well at the "would be good to see
> > > > in a regular DEBUG build" level.
> > > >
> > > > This change will have suddenly effectively hidden a message that was
> > > > already present in many platforms, where they were not (very) annoyingly
> > > > repetitive during a normal boot.
> > > >
> > > > It feels the test suite is not the thing that we need to optimise
> > > > debug output for.
> > > >
> > > > Is there some alternative way we can rate limit this?
> > >
> > > Given that the sole purpose of this library is to paper over the fact
> > > that the platform violates the spec, and lacks the ability to tell
> > > time, I think it makes little sense to obsess over how wrong the value
> > > is that it returns.
> >
> > I'm not obsessing about anything, I'm saying that using tediousness
> > when running a testsuite as an argument, potential issues with the
> > only aspect that makes this implementation useful without having to
> > rebuild firmware every few weeks are now hidden.
> >
> > If we truly don't care about the feature, nuke it. Don't hide when it
> > breaks.
> >
>
> Nuke what exactly? I think the library has a use, I simply don't see
> the point of reporting 25-50 times every boot that no timestamp was
> recorded in a variable.
Nuke the variable and always use the build timestamp EPOCH.
I would prefer that to silent failure.
Or we can figure out and alternative way to stop it spamming the
console.
The library is declared as a BASE library, but that's clearly untrue
as it depends on UefiRuntimeLib.
So we could, for example, break out the "check for EPOCH in variable"
into a protocol and print the message only once at protocol init.
Or we could add a Pcd for "no point, I have no persistent storage".
/
Leif
next prev parent reply other threads:[~2021-02-21 21:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 16:41 [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Samer El-Haj-Mahmoud
2021-02-20 16:50 ` Ard Biesheuvel
2021-02-20 17:22 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-02-20 21:46 ` Leif Lindholm
2021-02-20 23:25 ` Samer El-Haj-Mahmoud
2021-02-21 10:50 ` Ard Biesheuvel
2021-02-21 20:43 ` Leif Lindholm
2021-02-21 20:50 ` Ard Biesheuvel
2021-02-21 21:33 ` Leif Lindholm [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-20 19:07 Samer El-Haj-Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221213337.GP1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox