From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web12.26146.1613943379019538550 for ; Sun, 21 Feb 2021 13:36:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=MXs2Y+IT; spf=pass (domain: nuviainc.com, ip: 209.85.128.54, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f54.google.com with SMTP id v62so12610467wmg.4 for ; Sun, 21 Feb 2021 13:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CLB/0Gx/DkUFUVKi9Ugfr40Vcmlcg9la2QSIAzbwu3U=; b=MXs2Y+ITpf4cBZaIg+qYFkbOyMlsOwIA22ayl5g2Rke12nF4A81xL2vTKdF4fwWo0M 8fRJl2rO+1J8GeTzWdtSf6Xj7LUpTdQzbntZwrq2jVDh0J5nvxWKNxG/JyjOgxSjaydR BjaJgwHjaW++0nWS7gDaTqdxtVlXFkfXAfxODsa/N2aLQbysvI/CxgdGIaGbc4mSbcVH HadX4p56kkXn/2ziNY5DDjpecqlVxQBA9wpPS/uglmgns5g3hc6AryQ6t0Z/BxniB3A9 3eIh6EsaJX76/lI5jILcOULPdGIkRbDg/Ncq7PImnFl0ZGdWbifu5sKr6hongwzpJGTn jQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CLB/0Gx/DkUFUVKi9Ugfr40Vcmlcg9la2QSIAzbwu3U=; b=neloAzW8moli+V+Z1LV8r9L86eb7SelUJW3D0IzJ18x2ND807DE5/RtVHwII6h1glW dlXruzbw9wA4GySxDhiEI9tb4j8kMnZMG51WjE/D1RSGGTXpSuYAbdRB2e8g8Diy/k3B KGYpb8ygJ5DQsJZtUfc8khVJvGlQ0PIjhR7VO4rZ5IuDMcqUH5HMZH1rLsFUktWVYfYA IbSJpqby8Eg0mC4bPrRl8FhFhsihCw1JvcE9XNDjcE9fusSEmD4evTJDIw7290sQzVfJ MsYzjLOJ5HKjXquvP+K9HSl375ZsE+ZWM2SJlLhsrdhO38ZxMRVRgM31uk3+Xh/Getp4 MhnA== X-Gm-Message-State: AOAM530AfXAT6dF0+HXymu39y74q9qPIgdNLF+Tf1A2lkugctlpBd40N 3Y2PZ+l7YrKTiezC1MVJh9GXdw== X-Google-Smtp-Source: ABdhPJwdEzpa8Zul2HVLOpdd+dc/LHj4K2T1PPsrBpQoks/a4d0SpdjXAZM67XS/q/tRv/shymu7oA== X-Received: by 2002:a05:600c:4fd5:: with SMTP id o21mr17028930wmq.20.1613943377575; Sun, 21 Feb 2021 13:36:17 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id h17sm18117766wrw.74.2021.02.21.13.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 13:36:17 -0800 (PST) Date: Sun, 21 Feb 2021 21:36:15 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH v2 3/3] ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE Message-ID: <20210221213615.GQ1664@vanye> References: <20210221032900.6485-1-rebecca@nuviainc.com> <20210221032900.6485-4-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210221032900.6485-4-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 20, 2021 at 20:29:00 -0700, Rebecca Cran wrote: > Update OemGetChassisType in OemMiscLib to return MISC_CHASSIS_TYPE > instead of EFI_STATUS, which matches other OemMiscLib functions. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm > --- > ArmPkg/Include/Library/OemMiscLib.h | 8 +++----- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 11 ++++------- > 2 files changed, 7 insertions(+), 12 deletions(-) > > diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h > index 31dfe7dac2a6..5f71b2ad48c7 100644 > --- a/ArmPkg/Include/Library/OemMiscLib.h > +++ b/ArmPkg/Include/Library/OemMiscLib.h > @@ -128,14 +128,12 @@ OemGetMaxProcessors ( > > /** Gets the type of chassis for the system. > > - @param ChassisType The type of the chassis. > - > - @retval EFI_SUCCESS The chassis type was fetched successfully. > + @retval The type of the chassis. > **/ > -EFI_STATUS > +MISC_CHASSIS_TYPE > EFIAPI > OemGetChassisType ( > - OUT UINT8 *ChassisType > + VOID > ); > > /** Returns whether the specified processor is present or not. > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > index b02a568426dd..6b233742feb0 100644 > --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > @@ -95,19 +95,16 @@ OemGetMaxProcessors ( > > /** Gets the type of chassis for the system. > > - @param ChassisType The type of the chassis. > - > - @retval EFI_SUCCESS The chassis type was fetched successfully. > + @retval The type of the chassis. > **/ > -EFI_STATUS > +MISC_CHASSIS_TYPE > EFIAPI > OemGetChassisType ( > - UINT8 *ChassisType > + VOID > ) > { > ASSERT (FALSE); > - *ChassisType = MiscChassisTypeUnknown; > - return EFI_SUCCESS; > + return MiscChassisTypeUnknown; > } > > /** Returns whether the specified processor is present or not. > -- > 2.26.2 >