From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web10.33938.1613997325430345523 for ; Mon, 22 Feb 2021 04:35:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Nhhun28y; spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f48.google.com with SMTP id l13so4632540wmg.5 for ; Mon, 22 Feb 2021 04:35:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9sX0UwuJZKNRvlgL/lSHqqpK4Uq3PbjSDQkuPfEICIc=; b=Nhhun28yj+gAXhSVqJdEHW/DE3/kMtWjXXTvS966lphgzdMZtdtwjaasq7nEc4dlpL wpkyJflohuaDQNyKRCGSBZ9XMkkjTEsybESM59ULeqU26s4QwbrH4QyMfdzgau5je+J5 WIc5Cq1y6M9XI4h/cmVB7HK4F2IHIatPcQKCZz5HEqXm0W/X0P2rrk27EkbU9b8700Iv Nsu8rUINrDeTKsGHFpiQZordrNWh3kAHbQlzNsn9J/VzzGc0L5PlVAKYvjIlo3cHR+no NEju54HskPqUNJTx53pkM5VPq4UItw+9s3JCjuKMmeSQFt7yaI/lrMUFzyZ+D0w9SgJ9 B6vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9sX0UwuJZKNRvlgL/lSHqqpK4Uq3PbjSDQkuPfEICIc=; b=UMKlXrxLeWy3N/FKhxBvRbREAgcjNRwf9ixVKFxVGW6kvJJk26la8O90IV7ilwuJkN DTMl4VxlYtoMc2lr6plsuDc7SkG6fLEhQsEik1DaYvQYLEISt3dcNTf9C4899e1PXZRS Wp51vOZ55LBDr/jYvxKP/7UsbNzoBu7MiBvYz8PIvsRB+/+sLc62goIsjcQ6+19+pwSM c1t2oh/TgAJ6JDsJWofaHDdzMs4AC8Sv/4W3UC3KvK/GncR7LHNo3jflu9C7q/l4hc0h aKkcof61KYTE8MKxWOZr0HllnhGO65Vp0/VXDplUv1NTzoDUmI/LnHeTFRm2q+ttJdsz XtGA== X-Gm-Message-State: AOAM531QrcISepFYT5n6o5NAy8DdBMthtFPXDsZBl7wS1ZE1rCdSr/JR 2yOjz89TzBNF7Pk1a4q8jCQqxQ== X-Google-Smtp-Source: ABdhPJwpoQfetAidaKHiDktNJxY1FjK+VdRbBIMbuXBgAOF4BnCWhttu1YX4w+66hD4erNYuW7dD7w== X-Received: by 2002:a1c:c90c:: with SMTP id f12mr20328665wmb.98.1613997323855; Mon, 22 Feb 2021 04:35:23 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id v9sm24606711wrn.86.2021.02.22.04.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 04:35:23 -0800 (PST) Date: Mon, 22 Feb 2021 12:35:21 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH v2 2/3] ArmPkg: Rename some functions and parameters in OemMiscLib Message-ID: <20210222123521.GR1664@vanye> References: <20210221032900.6485-1-rebecca@nuviainc.com> <20210221032900.6485-3-rebecca@nuviainc.com> <20210221212153.GO1664@vanye> <60e89245-a027-d082-9ece-bc9fed791583@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <60e89245-a027-d082-9ece-bc9fed791583@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Feb 21, 2021 at 16:04:31 -0700, Rebecca Cran wrote: > On 2/21/21 2:21 PM, Leif Lindholm wrote: > > On Sat, Feb 20, 2021 at 20:28:59 -0700, Rebecca Cran wrote: (Adding necessary patch context back in - please don't strip out until absolutely certain it is irrelevant to conversation.) diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c index e6adbceba2d5..fc4dba319aad 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c @@ -23,27 +23,6 @@ #include "SmbiosMisc.h" -/** - * Returns the chassis type in SMBIOS format. - * - * @return Chassis type -**/ > > > -UINT8 > > > -GetChassisType ( > > > - VOID > > > - ) > > > -{ > > > - EFI_STATUS Status; > > > - UINT8 ChassisType; > > > - > > > - Status = OemGetChassisType (&ChassisType); > > > - if (EFI_ERROR (Status)) { > > > - return 0; > > > - } > > > - > > > - return ChassisType; > > > -} > > > - > > > > This function is outright deleted, not renamed. > > Does this belong in another patch? > > I think it belongs here: it was just a helper function for when > OemGetChassisType returned EFI_STATUS. Since it now returns the same data as > this function, we don't need it anymore. This patch, according to its title and commit message, does renaming. The refactoring should then be moved over to 3/3, together with this hunk: @@ -165,10 +142,7 @@ SMBIOS_MISC_TABLE_FUNCTION(MiscChassisManufacturer) SmbiosRecord->Hdr.Length = sizeof (SMBIOS_TABLE_TYPE3) + SmbiosRecord->ExtendLength + 1; - ChassisType = GetChassisType (); - if (ChassisType != 0) { - SmbiosRecord->Type = ChassisType; - } + SmbiosRecord->Type = OemGetChassisType (); //ContainedElements ASSERT (ContainedElementCount < 2); The current layout means this code (in 2/3) relies on the API change introduced in 3/3. / Leif > > -- > Rebecca Cran