From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by mx.groups.io with SMTP id smtpd.web09.5900.1614056039783373481 for ; Mon, 22 Feb 2021 20:53:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=IRyAI9VP; spf=pass (domain: nuviainc.com, ip: 209.85.219.54, mailfrom: rebecca@nuviainc.com) Received: by mail-qv1-f54.google.com with SMTP id 15so2002316qvp.13 for ; Mon, 22 Feb 2021 20:53:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XVma0+zc0vW6GA6twiYbQWUsYB1yCAFNlVMiuuHLTB8=; b=IRyAI9VPqjGPmJQfnZzGlFJxRRnuU/j74E7ZfSbSJZJcOKJS3n1p8TBe6Dq+jZDNo0 4dEmnvBWtO1u52FHByKl6Awoz/EyOGQ6OZkxqK1Ys/Ggh9As19k83maqmSnGucKNPvQP Uw2uAJ1tQ3+k0ViSEjRzwcqKrfypgdUcNbtUErahjZUcU5JWad5pRGXR5h3H8PPspK0J 2zuLxS5DTmO4bRJ/dhaPf/RhoWpYdVnn4GQkslKDbPdZn1ttPHBRXZQoqGdr5tof3fA7 vy8laW5+j7vFWfF4zBX8i+Geaie4rPhCX11peTo9zW0wLfOFqlXBPp6pRliAxLYeaasE Ul8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XVma0+zc0vW6GA6twiYbQWUsYB1yCAFNlVMiuuHLTB8=; b=nYFR9Y+7crt7sbyPY1wXKbGUgDssx8G/vGc/nyJeAV7Cfg07ovezdX9vnwP6HkS7pD 5ISc8AA3n6g/ln1KyqxrxBg8ww6EZhlgDBHHbOHMwKuSDTgUjr5+nxp6B+KspTnxpjaf I3gM9R1TxtGvRKy3CSBFbojEQizgInrYRHtJBqvE5AOnrhM339fFpWlJjeAbm3+tbMCX oF6bErwWxQmm+y2AbSrjOqvUbgD1+7WE4gONzpDq3r0bWhs9Mki0AVnpLwWFC1pCzy8Y iXDQ2TKkBCeFeGRfZ9QbjmTfnaedmV4nkzy3GY7QgTf6PcYsn2/wFSkwGhKtLD6liYiy fDww== X-Gm-Message-State: AOAM533+XA+obRSebgL3mQgFuP7yfGt285jHaQhsgd3M2df3W4B/kCNu BZKA6haodEP7z4SFuaz/nZxyUsX86GX3Dmm3laMEp1Hexk87YE9/Li3TbKoiq3m3j8flv+nzo1b iJFL9KuyZwEHdrQyDiPJbykdiADteZGCbMVOyG7nh9OzgqaJRTlsJ69Rx2QOjrk7NaTp9QQ== X-Google-Smtp-Source: ABdhPJxYnrnuzbZKFxWTXmP/XVzp01olcR77Z1EjwIjulmGN186xcmm0Edyr/u8Uq2KgJ3cITXRaNw== X-Received: by 2002:a0c:ab15:: with SMTP id h21mr16288284qvb.51.1614056038708; Mon, 22 Feb 2021 20:53:58 -0800 (PST) Return-Path: Received: from cube.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id x9sm12303258qtr.74.2021.02.22.20.53.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 20:53:58 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel Subject: [PATCH v3 1/3] ArmPkg: Fix ordering of return type and EFIAPI specifier in OemMiscLib Date: Mon, 22 Feb 2021 21:53:51 -0700 Message-Id: <20210223045353.31315-2-rebecca@nuviainc.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210223045353.31315-1-rebecca@nuviainc.com> References: <20210223045353.31315-1-rebecca@nuviainc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The return type should be on the line before any EFIAPI specifier. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/OemMiscLib.h | 14 +++++++------- ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 12 ++++++------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h index e70019d05f15..ad0e77685dbe 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -71,8 +71,8 @@ typedef enum @return CPU frequency in Hz **/ -EFIAPI UINTN +EFIAPI OemGetCpuFreq ( IN UINT8 ProcessorIndex ); @@ -87,8 +87,8 @@ OemGetCpuFreq ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetProcessorInformation ( IN UINTN ProcessorIndex, IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, @@ -106,8 +106,8 @@ OemGetProcessorInformation ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetCacheInformation ( IN UINT8 ProcessorIndex, IN UINT8 CacheLevel, @@ -120,8 +120,8 @@ OemGetCacheInformation ( @return The maximum number of sockets. **/ -EFIAPI UINT8 +EFIAPI OemGetProcessorMaxSockets ( VOID ); @@ -132,8 +132,8 @@ OemGetProcessorMaxSockets ( @retval EFI_SUCCESS The chassis type was fetched successfully. **/ -EFIAPI EFI_STATUS +EFIAPI OemGetChassisType ( OUT UINT8 *ChassisType ); @@ -144,8 +144,8 @@ OemGetChassisType ( @return TRUE is the processor is present, FALSE otherwise. **/ -EFIAPI BOOLEAN +EFIAPI OemIsSocketPresent ( IN UINTN ProcessorIndex ); @@ -156,8 +156,8 @@ OemIsSocketPresent ( @param TokenToUpdate The string to update. @param Offset The field to get information about. **/ -EFIAPI VOID +EFIAPI OemUpdateSmbiosInfo ( IN EFI_HII_HANDLE HiiHandle, IN EFI_STRING_ID TokenToUpdate, diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c index 73cebef2d1b9..6b179941e414 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -23,8 +23,8 @@ @return CPU frequency in Hz **/ -EFIAPI UINTN +EFIAPI OemGetCpuFreq ( IN UINT8 ProcessorIndex ) @@ -43,8 +43,8 @@ OemGetCpuFreq ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetProcessorInformation ( IN UINTN ProcessorIndex, IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, @@ -66,8 +66,8 @@ OemGetProcessorInformation ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetCacheInformation ( IN UINT8 ProcessorIndex, IN UINT8 CacheLevel, @@ -84,8 +84,8 @@ OemGetCacheInformation ( @return The maximum number of sockets. **/ -EFIAPI UINT8 +EFIAPI OemGetProcessorMaxSockets ( VOID ) @@ -117,8 +117,8 @@ OemGetChassisType ( @return TRUE is the processor is present, FALSE otherwise. **/ -EFIAPI BOOLEAN +EFIAPI OemIsSocketPresent ( IN UINTN ProcessorIndex ) @@ -133,8 +133,8 @@ OemIsSocketPresent ( @param TokenToUpdate The string to update. @param Offset The field to get information about. **/ -EFIAPI VOID +EFIAPI OemUpdateSmbiosInfo ( IN EFI_HII_HANDLE mHiiHandle, IN EFI_STRING_ID TokenToUpdate, -- 2.26.2