Re: [PATCH v3 0/3] ArmPkg: Fix several issues in OemMiscLib

["Leif Lindholm" <leif@nuviainc.com>]

On Mon, Feb 22, 2021 at 21:53:50 -0700, Rebecca Cran wrote:
> Update OemMiscLib with the following changes:
> 
> o Fixed ordering of return type and EFIAPI specifier.
> o Renamed 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'.
> o Renamed 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'.
> o Renamed OemGetProcessorMaxSockets to OemGetMaxProcessors.
> o Renamed OemIsSocketPresent to OemIsProcessorPresent.
> o Updated OemGetChassisType to return MISC_CHASSIS_TYPE instead of
>   EFI_STATUS, which matches other OemMiscLib functions.
> 
> Github pull request (personal build): https://github.com/tianocore/edk2/pull/1435
> 
> Changes between v2 and v3:
> 
> Moved the OemGetChassisType changes from 2/3 to 3/3.
> Renamed the 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'.

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 078400ee15e7..a2b5ea38a6fb.

Thanks!

> 
> Rebecca Cran (3):
>   ArmPkg: Fix ordering of return type and EFIAPI specifier in OemMiscLib
>   ArmPkg: Rename some functions and parameters in OemMiscLib
>   ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE
> 
>  ArmPkg/Include/Library/OemMiscLib.h                                            | 34 ++++++++---------
>  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                            | 40 +++++++++-----------
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c               | 40 ++++++++++----------
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 28 +-------------
>  4 files changed, 55 insertions(+), 87 deletions(-)
> 
> -- 
> 2.26.2
>