From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.groups.io with SMTP id smtpd.web12.9092.1614083941750734603 for ; Tue, 23 Feb 2021 04:39:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=F7VwfSR8; spf=pass (domain: nuviainc.com, ip: 209.85.221.45, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f45.google.com with SMTP id r3so10785348wro.9 for ; Tue, 23 Feb 2021 04:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=chSUSZ4r2UVeuW62IzZMtIszkyT+jzhE1tthVKsPzyQ=; b=F7VwfSR8/XFgKg3ndge2WFpKTMwxe15rDlVUIhzkWEx8GuYuSRPlYM33tU4/J1F1vu 8AuBt/+QHda3yHlR+FjhggRgTZyjrH64d6u+VfSJQHQY3Vt0lq1iSrVxUw2D1Rjh8D3n tWj4nbFUz2X2sM7U4ejyi0ClIRqHISx4mGjZtib1p9f77nP2PEI17mi4LIFA+PhFM0U4 TWTmdH6MhcNTuT6F/Fmvsb+XceLaah/ZZEcz0cnsED5PYt7QV4UDm4baKPl5akrhaqP+ JecXTail7k/wSKxsYTVful1Sgj6p18jBcJQ/WZmLEIO0LRONK7kepiwzDSIfP9Of6JJC ZCOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=chSUSZ4r2UVeuW62IzZMtIszkyT+jzhE1tthVKsPzyQ=; b=OAr/tR3ISo/gZS4TYHgKonM9GUd/R1ZPoSBY2LNoDRcQJXTOqmeV6mOZXBTJuDJoxC WVZa1og5MSN1B5iSU1OkBvf9zrHGE9u/5i78ihzXNFaiB24ch0hEz8c+6lIEBXlIQYxJ 9EKnhD+gLERcnEOOc180TAyyHYQkINtEqrjaZZEM2luGY6UYCRV8FhjuXy9/ooyT9288 5CSj0pPJwyr1BY4TKc8hhQnCguWDIKl7dcX/3lpaPKVqcsLPvpMsSpN7bFLELxosNUyz fbi1nw21Ln65NHVAbCIazx0YxLUdv52DeoCMcKxM1z8viunqzPL+uZP3fSg8766v3sjt VmzA== X-Gm-Message-State: AOAM533hLSZwR5o0HLQ2i/iEJTfDBoKVnyF2DmaBxj1ZbCOV1UanX80K LCqswXSufi1jI3NqlwWomwX+QA== X-Google-Smtp-Source: ABdhPJzv7ksUWM+oJFdJAqI0EjuzjR95RCEo5Vm+1nVOQez84QYiqb9iYT269GOe3AzOWVIsYB75aw== X-Received: by 2002:a5d:69ce:: with SMTP id s14mr4764553wrw.172.1614083940378; Tue, 23 Feb 2021 04:39:00 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id o9sm634613wmc.8.2021.02.23.04.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 04:38:59 -0800 (PST) Date: Tue, 23 Feb 2021 12:38:58 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH v3 0/3] ArmPkg: Fix several issues in OemMiscLib Message-ID: <20210223123858.GZ1664@vanye> References: <20210223045353.31315-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210223045353.31315-1-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 22, 2021 at 21:53:50 -0700, Rebecca Cran wrote: > Update OemMiscLib with the following changes: > > o Fixed ordering of return type and EFIAPI specifier. > o Renamed 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'. > o Renamed 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'. > o Renamed OemGetProcessorMaxSockets to OemGetMaxProcessors. > o Renamed OemIsSocketPresent to OemIsProcessorPresent. > o Updated OemGetChassisType to return MISC_CHASSIS_TYPE instead of > EFI_STATUS, which matches other OemMiscLib functions. > > Github pull request (personal build): https://github.com/tianocore/edk2/pull/1435 > > Changes between v2 and v3: > > Moved the OemGetChassisType changes from 2/3 to 3/3. > Renamed the 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'. For the series: Reviewed-by: Leif Lindholm Pushed as 078400ee15e7..a2b5ea38a6fb. Thanks! > > Rebecca Cran (3): > ArmPkg: Fix ordering of return type and EFIAPI specifier in OemMiscLib > ArmPkg: Rename some functions and parameters in OemMiscLib > ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE > > ArmPkg/Include/Library/OemMiscLib.h | 34 ++++++++--------- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 40 +++++++++----------- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 40 ++++++++++---------- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 28 +------------- > 4 files changed, 55 insertions(+), 87 deletions(-) > > -- > 2.26.2 >