From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, ardb+tianocore@kernel.org,
leif@nuviainc.com, sami.mujawar@arm.com
Subject: [PATCH v3 00/26] Fix Ecc reported errors in ArmPkg
Date: Tue, 23 Feb 2021 13:13:40 +0000 [thread overview]
Message-ID: <20210223131406.3484-1-Pierre.Gondois@arm.com> (raw)
From: Pierre Gondois <Pierre.Gondois@arm.com>
The Ecc tools available in the BaseTools package checks for
good practice coding standards. Some errors reported while
running Ecc on the ArmPkg require modifications.
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3
v2:
For ArmPkg: Fix Ecc error 8001 in Chipset
- Only use one trailing underscore for the
ARM_CORTEX_A5x_H__ include guard. [Sami]
- 2 patches had the same name and fixed the same
Ecc error in V1. They are merged in V2. [Pierre]
v3:
- Place ScmiMessageIdBasexxx related changes that were in
'ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK' in
'ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE'. [Sami]
Pierre Gondois (26):
ArmPkg: Fix Ecc error 8001 in Chipset
ArmPkg: Fix Ecc error 8001 in SemihostLib
ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib
ArmPkg: Fix Ecc error 9005 in CpuDxe
ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc
ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib
ArmPkg: Fix Ecc error 10014 in ArmScmiDxe
ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe
ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe
ArmPkg: Fix Ecc error 10014 in SemihostLib
ArmPkg: Remove ArmGic/ArmGicSecLib.c
ArmPkg: Fix Ecc error 5003 in ArmExceptionLib
ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe
ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib
ArmPkg: Rename include guard in ArmGicLib.h
ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE
ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM
ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib
ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID
ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE
ArmPkg: Fix Ecc error 8005 for SCMI_STATUS
ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID
ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE
ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK
ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT
ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE
ArmPkg/ArmPkg.dsc | 6 +-
ArmPkg/Drivers/ArmGic/ArmGicSecLib.c | 58 -------
ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 9 +-
.../ArmScmiPerformanceProtocolPrivate.h | 4 +-
ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 10 +-
ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 24 +--
ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 44 ++---
ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 10 +-
.../ArmScmiDxe/ScmiPerformanceProtocol.c | 30 ++--
ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 48 +++---
ArmPkg/Drivers/CpuDxe/CpuMpCore.c | 4 +-
.../GenericWatchdogDxe/GenericWatchdogDxe.inf | 3 +-
.../MmCommunicationDxe/MmCommunicate.h | 8 +-
.../MmCommunicationDxe/MmCommunication.inf | 3 +-
ArmPkg/Include/Chipset/AArch64.h | 12 +-
ArmPkg/Include/Chipset/AArch64Mmu.h | 4 +-
ArmPkg/Include/Chipset/ArmCortexA5x.h | 8 +-
ArmPkg/Include/Chipset/ArmV7.h | 4 +-
ArmPkg/Include/Library/ArmGicLib.h | 8 +-
ArmPkg/Include/Library/OpteeLib.h | 11 +-
ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h | 10 +-
.../Include/Protocol/ArmScmiClock2Protocol.h | 6 +-
.../Include/Protocol/ArmScmiClockProtocol.h | 32 ++--
.../Protocol/ArmScmiPerformanceProtocol.h | 14 +-
.../Library/ArmArchTimerLib/ArmArchTimerLib.c | 12 +-
.../ArmDisassemblerLib/ArmDisassembler.c | 159 +++++++++---------
.../ArmDisassemblerLib/ThumbDisassembler.c | 158 ++++++++---------
.../AArch64/AArch64Exception.c | 4 +-
.../AArch64/ExceptionSupport.S | 10 +-
.../ArmExceptionLib/Arm/ArmException.c | 5 +-
ArmPkg/Library/ArmSoftFloatLib/platform.h | 6 +
ArmPkg/Library/SemihostLib/SemihostLib.c | 26 +--
ArmPkg/Library/SemihostLib/SemihostLib.inf | 3 +-
ArmPkg/Library/SemihostLib/SemihostPrivate.h | 80 ++++-----
.../ArmMmuStandaloneMmLib.inf | 4 +-
ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 10 +-
36 files changed, 416 insertions(+), 431 deletions(-)
delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c
--
2.17.1
next reply other threads:[~2021-02-23 13:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 13:13 PierreGondois [this message]
2021-02-23 13:13 ` [PATCH v3 01/26] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-23 13:13 ` [PATCH v3 02/26] ArmPkg: Fix Ecc error 8001 in SemihostLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 03/26] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 04/26] ArmPkg: Fix Ecc error 9005 in CpuDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc PierreGondois
2021-02-23 13:13 ` [PATCH v3 06/26] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 07/26] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 08/26] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 09/26] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 10/26] ArmPkg: Fix Ecc error 10014 in SemihostLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 11/26] ArmPkg: Remove ArmGic/ArmGicSecLib.c PierreGondois
2021-02-23 13:13 ` [PATCH v3 12/26] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 13/26] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 14/26] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 15/26] ArmPkg: Rename include guard in ArmGicLib.h PierreGondois
2021-02-23 13:13 ` [PATCH v3 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE PierreGondois
2021-02-23 13:13 ` [PATCH v3 17/26] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM PierreGondois
2021-02-23 13:13 ` [PATCH v3 18/26] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 19/26] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID PierreGondois
2021-02-23 13:14 ` [PATCH v3 20/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE PierreGondois
2021-02-23 13:14 ` [PATCH v3 21/26] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS PierreGondois
2021-02-23 13:14 ` [PATCH v3 22/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID PierreGondois
2021-02-23 13:14 ` [PATCH v3 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE PierreGondois
2021-02-25 12:51 ` [edk2-devel] " Sami Mujawar
2021-02-23 13:14 ` [PATCH v3 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK PierreGondois
2021-02-25 12:52 ` [edk2-devel] " Sami Mujawar
2021-02-23 13:14 ` [PATCH v3 25/26] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT PierreGondois
2021-02-23 13:14 ` [PATCH v3 26/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223131406.3484-1-Pierre.Gondois@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox