From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9421.1614086087750764696 for ; Tue, 23 Feb 2021 05:14:47 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66A3331B; Tue, 23 Feb 2021 05:14:47 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2F34F3F70D; Tue, 23 Feb 2021 05:14:46 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [PATCH v3 20/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE Date: Tue, 23 Feb 2021 13:14:00 +0000 Message-Id: <20210223131406.3484-21-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c index 847868a7749e..25f6cc3371af 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -95,7 +95,7 @@ ScmiCommandExecute ( // Fill in message header. MessageHeader = SCMI_MESSAGE_HEADER ( Command->MessageId, - SCMI_MESSAGE_TYPE_COMMAND, + ScmiMessageTypeCommand, Command->ProtocolId ); diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h index 5f1225f54cd9..6de57a5c9514 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -23,9 +23,9 @@ typedef enum { // SCMI message types. typedef enum { - SCMI_MESSAGE_TYPE_COMMAND = 0, - SCMI_MESSAGE_TYPE_DELAYED_RESPONSE = 2, // Skipping 1 is deliberate. - SCMI_MESSAGE_TYPE_NOTIFICATION = 3 + ScmiMessageTypeCommand = 0, + ScmiMessageTypeDelayedResponse = 2, // Skipping 1 is deliberate. + ScmiMessageTypeNotification = 3 } SCMI_MESSAGE_TYPE; // SCMI response error codes. -- 2.17.1