From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.9480.1614086089182409955 for ; Tue, 23 Feb 2021 05:14:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D07E231B; Tue, 23 Feb 2021 05:14:48 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C681D3F70D; Tue, 23 Feb 2021 05:14:47 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [PATCH v3 21/26] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS Date: Tue, 23 Feb 2021 13:14:01 +0000 Message-Id: <20210223131406.3484-22-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 +- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c index 25f6cc3371af..a1bf1b95c052 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -123,7 +123,7 @@ ScmiCommandExecute ( Response = (SCMI_MESSAGE_RESPONSE*)MtlGetChannelPayload (Channel); - if (Response->Status != SCMI_SUCCESS) { + if (Response->Status != ScmiSuccess) { DEBUG ((DEBUG_ERROR, "SCMI error: ProtocolId = 0x%x, MessageId = 0x%x, error = %d\n", Command->ProtocolId, Command->MessageId, diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h index 6de57a5c9514..118961dbe219 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -30,17 +30,17 @@ typedef enum { // SCMI response error codes. typedef enum { - SCMI_SUCCESS = 0, - SCMI_NOT_SUPPORTED = -1, - SCMI_INVALID_PARAMETERS = -2, - SCMI_DENIED = -3, - SCMI_NOT_FOUND = -4, - SCMI_OUT_OF_RANGE = -5, - SCMI_BUSY = -6, - SCMI_COMMS_ERROR = -7, - SCMI_GENERIC_ERROR = -8, - SCMI_HARDWARE_ERROR = -9, - SCMI_PROTOCOL_ERROR = -10 + ScmiSuccess = 0, + ScmiNotSupported = -1, + ScmiInvalidParameters = -2, + ScmiDenied = -3, + ScmiNotFound = -4, + ScmiOutOfRange = -5, + ScmiBusy = -6, + ScmiCommsError = -7, + ScmiGenericError = -8, + ScmiHardwareError = -9, + ScmiProtocolError = -10 } SCMI_STATUS; // SCMI message IDs common to all protocols. -- 2.17.1