From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.9422.1614086090924850211 for ; Tue, 23 Feb 2021 05:14:51 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91C2931B; Tue, 23 Feb 2021 05:14:50 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.9.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3B6FF3F70D; Tue, 23 Feb 2021 05:14:49 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com Subject: [PATCH v3 22/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID Date: Tue, 23 Feb 2021 13:14:02 +0000 Message-Id: <20210223131406.3484-23-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com> References: <20210223131406.3484-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 6 +++--- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c index a1bf1b95c052..3793c0663666 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -195,7 +195,7 @@ ScmiGetProtocolVersion ( Status = ScmiProtocolDiscoveryCommon ( ProtocolId, - SCMI_MESSAGE_ID_PROTOCOL_VERSION, + ScmiMessageIdProtocolVersion, (UINT32**)&ProtocolVersion ); if (EFI_ERROR (Status)) { @@ -224,7 +224,7 @@ ScmiGetProtocolAttributes ( { return ScmiProtocolDiscoveryCommon ( ProtocolId, - SCMI_MESSAGE_ID_PROTOCOL_ATTRIBUTES, + ScmiMessageIdProtocolAttributes, ReturnValues ); } @@ -246,7 +246,7 @@ ScmiGetProtocolMessageAttributes ( { return ScmiProtocolDiscoveryCommon ( ProtocolId, - SCMI_MESSAGE_ID_PROTOCOL_MESSAGE_ATTRIBUTES, + ScmiMessageIdProtocolMessageAttributes, ReturnValues ); } diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h index 118961dbe219..e56c9e0dc342 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -45,9 +45,9 @@ typedef enum { // SCMI message IDs common to all protocols. typedef enum { - SCMI_MESSAGE_ID_PROTOCOL_VERSION = 0x0, - SCMI_MESSAGE_ID_PROTOCOL_ATTRIBUTES = 0x1, - SCMI_MESSAGE_ID_PROTOCOL_MESSAGE_ATTRIBUTES = 0x2 + ScmiMessageIdProtocolVersion = 0x0, + ScmiMessageIdProtocolAttributes = 0x1, + ScmiMessageIdProtocolMessageAttributes = 0x2 } SCMI_MESSAGE_ID; // Not defined in SCMI specification but will help to identify a message. -- 2.17.1