From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, ardb+tianocore@kernel.org,
leif@nuviainc.com, sami.mujawar@arm.com
Subject: [PATCH v3 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE
Date: Tue, 23 Feb 2021 13:14:03 +0000 [thread overview]
Message-ID: <20210223131406.3484-24-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210223131406.3484-1-Pierre.Gondois@arm.com>
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3
Notes:
v3:
- Import ScmiMessageIdBasexxx related changes from the patch
'ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK'. [Sami]
ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 12 ++++++------
ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h | 10 +++++-----
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
index c84ce97f15ac..2c6206be9368 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
@@ -69,9 +69,9 @@ BaseGetTotalProtocols (
/** Common function which returns vendor details.
- @param[in] MessageId SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR
+ @param[in] MessageId ScmiMessageIdBaseDiscoverVendor
OR
- SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR
+ ScmiMessageIdBaseDiscoverSubVendor
@param[out] VendorIdentifier ASCII name of the vendor/subvendor.
@@ -133,7 +133,7 @@ BaseDiscoverVendor (
)
{
return BaseDiscoverVendorDetails (
- SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR,
+ ScmiMessageIdBaseDiscoverVendor,
VendorIdentifier
);
}
@@ -156,7 +156,7 @@ BaseDiscoverSubVendor (
)
{
return BaseDiscoverVendorDetails (
- SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR,
+ ScmiMessageIdBaseDiscoverSubVendor,
VendorIdentifier
);
}
@@ -184,7 +184,7 @@ BaseDiscoverImplVersion (
UINT32 PayloadLength;
Cmd.ProtocolId = ScmiProtocolIdBase;
- Cmd.MessageId = SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION;
+ Cmd.MessageId = ScmiMessageIdBaseDiscoverImplementationVersion;
PayloadLength = 0;
@@ -251,7 +251,7 @@ BaseDiscoverListProtocols (
}
Cmd.ProtocolId = ScmiProtocolIdBase;
- Cmd.MessageId = SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS;
+ Cmd.MessageId = ScmiMessageIdBaseDiscoverListProtocols;
Skip = 0;
diff --git a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h b/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h
index 2f93ec92325e..73ad3e32a2f5 100644
--- a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h
+++ b/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h
@@ -1,6 +1,6 @@
/** @file
- Copyright (c) 2017-2018, Arm Limited. All rights reserved.
+ Copyright (c) 2017-2021, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -158,10 +158,10 @@ typedef struct _SCMI_BASE_PROTOCOL {
// SCMI Message IDs for Base protocol.
typedef enum {
- SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR = 0x3,
- SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR = 0x4,
- SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION = 0x5,
- SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS = 0x6
+ ScmiMessageIdBaseDiscoverVendor = 0x3,
+ ScmiMessageIdBaseDiscoverSubVendor = 0x4,
+ ScmiMessageIdBaseDiscoverImplementationVersion = 0x5,
+ ScmiMessageIdBaseDiscoverListProtocols = 0x6
} SCMI_MESSAGE_ID_BASE;
#endif /* ARM_SCMI_BASE_PROTOCOL_H_ */
--
2.17.1
next prev parent reply other threads:[~2021-02-23 13:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 13:13 [PATCH v3 00/26] Fix Ecc reported errors in ArmPkg PierreGondois
2021-02-23 13:13 ` [PATCH v3 01/26] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-23 13:13 ` [PATCH v3 02/26] ArmPkg: Fix Ecc error 8001 in SemihostLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 03/26] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 04/26] ArmPkg: Fix Ecc error 9005 in CpuDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc PierreGondois
2021-02-23 13:13 ` [PATCH v3 06/26] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 07/26] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 08/26] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 09/26] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 10/26] ArmPkg: Fix Ecc error 10014 in SemihostLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 11/26] ArmPkg: Remove ArmGic/ArmGicSecLib.c PierreGondois
2021-02-23 13:13 ` [PATCH v3 12/26] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 13/26] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe PierreGondois
2021-02-23 13:13 ` [PATCH v3 14/26] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 15/26] ArmPkg: Rename include guard in ArmGicLib.h PierreGondois
2021-02-23 13:13 ` [PATCH v3 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE PierreGondois
2021-02-23 13:13 ` [PATCH v3 17/26] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM PierreGondois
2021-02-23 13:13 ` [PATCH v3 18/26] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib PierreGondois
2021-02-23 13:13 ` [PATCH v3 19/26] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID PierreGondois
2021-02-23 13:14 ` [PATCH v3 20/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE PierreGondois
2021-02-23 13:14 ` [PATCH v3 21/26] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS PierreGondois
2021-02-23 13:14 ` [PATCH v3 22/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID PierreGondois
2021-02-23 13:14 ` PierreGondois [this message]
2021-02-25 12:51 ` [edk2-devel] [PATCH v3 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE Sami Mujawar
2021-02-23 13:14 ` [PATCH v3 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK PierreGondois
2021-02-25 12:52 ` [edk2-devel] " Sami Mujawar
2021-02-23 13:14 ` [PATCH v3 25/26] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT PierreGondois
2021-02-23 13:14 ` [PATCH v3 26/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223131406.3484-24-Pierre.Gondois@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox