public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Graeme Gregory <graeme@nuviainc.com>,
	Radoslaw Biernacki <rad@semihalf.com>
Subject: Re: [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables
Date: Tue, 23 Feb 2021 18:41:00 +0000	[thread overview]
Message-ID: <20210223184100.GH1664@vanye> (raw)
In-Reply-To: <20210223174342.8572-1-rebecca@nuviainc.com>

On Tue, Feb 23, 2021 at 10:43:38 -0700, Rebecca Cran wrote:
> o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios.
> o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support
>   for SMBIOS 3.4.0, as is required by SBBR.
> o Add an implementation of OemMiscLib that provides the system
>   information. The serial numbers, asset tags etc. are currently all
>   fixed strings, to allow fwts to pass without errors.
> o Add SMBIOS PCDs to identify the platform. The processor serial
>   number, asset tag and part number are populated because otherwise
>   fwts reports errors.
> 
> Changes between v4 and v5
> 
> o Moved calling FdtHelperCountCpus in SbsaQemuAcpiDxe from 1/4 into 2/4.

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 9fb5174e0a16..71d92a044db0.

(I did trim a couple of trailing blank lines at end of file in 3/4
before pushing.)

> 
> Rebecca Cran (4):
>   SbsaQemu: Add FdtHelperLib
>   SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib
>   Platform/Qemu/SbsaQemu: Add SMBIOS tables
>   Silicon/Qemu: Don't re-use NumCores as loop index in AddMadtTable
> 
>  Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c                    | 242 ++++++++++++++++++++
>  Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf                  |  53 +++++
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  50 +++-
>  Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   7 +
>  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   |  62 +----
>  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |   1 +
>  Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h              |  24 ++
>  Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c         |  62 +++++
>  Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf       |  28 +++
>  Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |  18 ++
>  10 files changed, 493 insertions(+), 54 deletions(-)
>  create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
>  create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf
>  create mode 100644 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h
>  create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c
>  create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf
> 
> -- 
> 2.26.2
> 

      parent reply	other threads:[~2021-02-23 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 17:43 [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables Rebecca Cran
2021-02-23 17:43 ` [edk2-platforms PATCH v5 1/4] SbsaQemu: Add FdtHelperLib Rebecca Cran
2021-02-23 17:43 ` [edk2-platforms PATCH v5 2/4] SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib Rebecca Cran
2021-02-23 17:43 ` [edk2-platforms PATCH v5 3/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables Rebecca Cran
2021-02-23 17:43 ` [edk2-platforms PATCH v5 4/4] Silicon/Qemu: Don't re-use NumCores as loop index in AddMadtTable Rebecca Cran
2021-02-23 18:41 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223184100.GH1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox