From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mx.groups.io with SMTP id smtpd.web08.654.1614105664224992436 for ; Tue, 23 Feb 2021 10:41:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=QVEO/rKB; spf=pass (domain: nuviainc.com, ip: 209.85.221.43, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f43.google.com with SMTP id t15so23553277wrx.13 for ; Tue, 23 Feb 2021 10:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5ksN6Yp7BVwI9rEa9xIUN8wnyc2zfI+13qdw2j+gKtg=; b=QVEO/rKBjwuAUE+SBAsvwRuR05VfpD8QCWreb0OLn+VzJkdenfbyGxD9WEYyQP5jeQ JkSXSFgfpqmz+pBh2QFvL20k+/0zg0GAv+OOdmAf0x4C07xsTe+h3Jfn4eWUnHtaUQwG z6ojrz4u0Qe1vWDA42Tu8tj2XyCmEA03wlb3NfneFT4jqlUxNzR+SfNgbb0UAnfam2Qe bxRh/6TTBpSSDAkLaRruF910uz7CkqoIGuLIZa2+l5aCTPuLxH7Y132pnHrwYjr8oGdz e+GeX7pRI4fl6x8HszYb4hBRe50F0E9KIOBqqMhUdUobf4QWk4OLCkaiBW2J8U3HAJIv EhpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5ksN6Yp7BVwI9rEa9xIUN8wnyc2zfI+13qdw2j+gKtg=; b=Z8s8iSePbWnz63Rib9JVF6x5/PDHU1RbcIKuLROnw4H5uifBUugRS+zIslvq5SsLih IjJIGpPUVymSFOIcLR5q8Owqgd0a+nYw1VhVpxumLKDeNJ2G2rw9mN0ExLAnvPvfjaLY 7wqzY+ViJBuvIzlKTzP/FhFnDWJGw8KFqCY9TSj/1GKSQsYBhbqpfGYizcO9gwYCqYUF lOjcRgSkIEKHmiCpipZoLobO3JSCRG/zTzxcMZd2Bj431tG+leD/EDuShw00Vb92MBvk +x6HkdHTrhvxeM7cNRQxvr5cWoxIngVSytF8d0nxj+UbtcHncYagua9kesUhNYEd1CFs 6jyg== X-Gm-Message-State: AOAM532oNumkf8EcjzkjlfvBUSFjIdmG2EFF4Q8zrojyIeV7ROPC1yNO RSZpp2yIyo2OLChd24/fCx1T/A== X-Google-Smtp-Source: ABdhPJwKi5hbgJS/p1Txabo+pYJZdbEE/gcbcQbq0xg4ZIL9PycWXUXnjEath/y1jQN0MI3tX5s+wg== X-Received: by 2002:adf:8b0d:: with SMTP id n13mr28262699wra.94.1614105662649; Tue, 23 Feb 2021 10:41:02 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id a6sm3692568wmj.23.2021.02.23.10.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 10:41:02 -0800 (PST) Date: Tue, 23 Feb 2021 18:41:00 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki Subject: Re: [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables Message-ID: <20210223184100.GH1664@vanye> References: <20210223174342.8572-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210223174342.8572-1-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 23, 2021 at 10:43:38 -0700, Rebecca Cran wrote: > o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. > o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support > for SMBIOS 3.4.0, as is required by SBBR. > o Add an implementation of OemMiscLib that provides the system > information. The serial numbers, asset tags etc. are currently all > fixed strings, to allow fwts to pass without errors. > o Add SMBIOS PCDs to identify the platform. The processor serial > number, asset tag and part number are populated because otherwise > fwts reports errors. > > Changes between v4 and v5 > > o Moved calling FdtHelperCountCpus in SbsaQemuAcpiDxe from 1/4 into 2/4. For the series: Reviewed-by: Leif Lindholm Pushed as 9fb5174e0a16..71d92a044db0. (I did trim a couple of trailing blank lines at end of file in 3/4 before pushing.) > > Rebecca Cran (4): > SbsaQemu: Add FdtHelperLib > SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib > Platform/Qemu/SbsaQemu: Add SMBIOS tables > Silicon/Qemu: Don't re-use NumCores as loop index in AddMadtTable > > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 242 ++++++++++++++++++++ > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 53 +++++ > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 50 +++- > Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 7 + > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 62 +---- > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 1 + > Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h | 24 ++ > Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c | 62 +++++ > Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf | 28 +++ > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 18 ++ > 10 files changed, 493 insertions(+), 54 deletions(-) > create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > create mode 100644 Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf > create mode 100644 Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h > create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.c > create mode 100644 Silicon/Qemu/SbsaQemu/Library/FdtHelperLib/FdtHelperLib.inf > > -- > 2.26.2 >