* [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5
2021-02-24 1:37 [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Takuto Naito
@ 2021-02-24 1:37 ` Takuto Naito
2021-02-24 2:24 ` [edk2-devel] " Heng Luo
2021-02-24 1:37 ` [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: " Takuto Naito
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Takuto Naito @ 2021-02-24 1:37 UTC (permalink / raw)
To: devel; +Cc: Takuto Naito, Sai Chaganty, Nate DeSimone, Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
These build errors occur only with DEBUG target because
RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable",
but DEBUG_GCC5_X64_CC_FLAGS doesn't.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
.../PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
.../IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
.../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
3 files changed, 9 deletions(-)
diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c
index 15d295a573..231cb367bc 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c
+++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c
@@ -104,12 +104,10 @@ ConfigureRpLtrOverride (
UINT32 OvrEn;
UINT32 OvrVal;
BOOLEAN IsCpuPcie;
- UINT32 LtrCfgLock;
IsCpuPcie = FALSE;
OvrEn = 0;
OvrVal = 0;
- LtrCfgLock = 0;
if (DevNum == SA_PEG0_DEV_NUM || DevNum == SA_PEG3_DEV_NUM) {
IsCpuPcie = TRUE;
diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c
index faac07c45d..e88abe550f 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c
+++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c
@@ -313,8 +313,6 @@ DmarTableUpdate (
UINTN Offset;
UINTN StructureLen;
UINT64 McD0BaseAddress;
- UINT32 GttMmAdr;
- UINT64 McD2BaseAddress;
UINT16 IgdMode;
UINT16 GttMode;
UINT32 IgdMemSize;
@@ -381,9 +379,6 @@ DmarTableUpdate (
GttMemSize = (1 << GttMode) * (1024) * (1024);
}
- McD2BaseAddress = PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, IGD_BUS_NUM, IGD_DEV_NUM, IGD_FUN_NUM, 0);
- GttMmAdr = (PciSegmentRead32 (McD2BaseAddress + R_SA_IGD_GTTMMADR)) & 0xFFFFFFF0;
-
DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress = (PciSegmentRead32 (McD0BaseAddress + R_SA_BGSM) & ~(0x01));
DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionLimitAddress = DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress + IgdMemSize + GttMemSize - 1;
DEBUG ((DEBUG_INFO, "RMRR Base address IGD %016lX\n", DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress));
diff --git a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c
index 7693e76683..3adc05ce89 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c
+++ b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c
@@ -29,8 +29,6 @@ GetPcieRpNumber (
OUT UINTN *RpNumber
)
{
- UINT64 RpBase;
- RpBase = PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, SA_MC_BUS, RpDev, RpFun, 0);
GetPchPcieRpNumber (RpDev, RpFun, RpNumber);
}
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5
2021-02-24 1:37 ` [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: " Takuto Naito
@ 2021-02-24 2:24 ` Heng Luo
0 siblings, 0 replies; 10+ messages in thread
From: Heng Luo @ 2021-02-24 2:24 UTC (permalink / raw)
To: devel@edk2.groups.io, naitaku@gmail.com
Cc: Chaganty, Rangasai V, Desimone, Nathaniel L
Reviewed-by: Heng Luo <heng.luo@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Takuto
> Naito
> Sent: Wednesday, February 24, 2021 9:38 AM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix
> build error with GCC5
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
>
> Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> These build errors occur only with DEBUG target because
> RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> DEBUG_GCC5_X64_CC_FLAGS doesn't.
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Signed-off-by: Takuto Naito <naitaku@gmail.com>
> ---
> .../PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
> .../IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
> .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
> 3 files changed, 9 deletions(-)
>
> diff --git
> a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientR
> pLib/PcieClientRpLib.c
> b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientR
> pLib/PcieClientRpLib.c
> index 15d295a573..231cb367bc 100644
> ---
> a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientR
> pLib/PcieClientRpLib.c
> +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/Pc
> +++ ieClientRpLib/PcieClientRpLib.c
> @@ -104,12 +104,10 @@ ConfigureRpLtrOverride (
> UINT32 OvrEn;
> UINT32 OvrVal;
> BOOLEAN IsCpuPcie;
> - UINT32 LtrCfgLock;
>
> IsCpuPcie = FALSE;
> OvrEn = 0;
> OvrVal = 0;
> - LtrCfgLock = 0;
>
> if (DevNum == SA_PEG0_DEV_NUM || DevNum == SA_PEG3_DEV_NUM) {
> IsCpuPcie = TRUE;
> diff --git
> a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/
> DxeVtdInitLib.c
> b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/
> DxeVtdInitLib.c
> index faac07c45d..e88abe550f 100644
> ---
> a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/
> DxeVtdInitLib.c
> +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVt
> +++ dInitLib/DxeVtdInitLib.c
> @@ -313,8 +313,6 @@ DmarTableUpdate (
> UINTN Offset;
> UINTN StructureLen;
> UINT64 McD0BaseAddress;
> - UINT32 GttMmAdr;
> - UINT64 McD2BaseAddress;
> UINT16 IgdMode;
> UINT16 GttMode;
> UINT32 IgdMemSize;
> @@ -381,9 +379,6 @@ DmarTableUpdate (
> GttMemSize = (1 << GttMode) * (1024) * (1024);
> }
>
> - McD2BaseAddress = PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM,
> IGD_BUS_NUM, IGD_DEV_NUM, IGD_FUN_NUM, 0);
> - GttMmAdr = (PciSegmentRead32 (McD2BaseAddress +
> R_SA_IGD_GTTMMADR)) & 0xFFFFFFF0;
> -
> DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress =
> (PciSegmentRead32 (McD0BaseAddress + R_SA_BGSM) & ~(0x01));
> DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionLimitAddress =
> DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress +
> IgdMemSize + GttMemSize - 1;
> DEBUG ((DEBUG_INFO, "RMRR Base address IGD %016lX\n", DmarTable-
> >RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress));
> diff --git
> a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelpe
> rClient.c
> b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelpe
> rClient.c
> index 7693e76683..3adc05ce89 100644
> ---
> a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelpe
> rClient.c
> +++ b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiH
> +++ elperClient.c
> @@ -29,8 +29,6 @@ GetPcieRpNumber (
> OUT UINTN *RpNumber
> )
> {
> - UINT64 RpBase;
> - RpBase = PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, SA_MC_BUS, RpDev,
> RpFun, 0);
> GetPchPcieRpNumber (RpDev, RpFun, RpNumber); }
>
> --
> 2.30.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
2021-02-24 1:37 [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Takuto Naito
2021-02-24 1:37 ` [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: " Takuto Naito
@ 2021-02-24 1:37 ` Takuto Naito
2021-02-24 2:24 ` [edk2-devel] " Heng Luo
2021-02-24 2:18 ` [PATCH edk2-platforms v1 0/2] " Nate DeSimone
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Takuto Naito @ 2021-02-24 1:37 UTC (permalink / raw)
To: devel; +Cc: Takuto Naito, Sai Chaganty, Nate DeSimone, Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
These build errors occur only with DEBUG target because
RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable",
but DEBUG_GCC5_X64_CC_FLAGS doesn't.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
.../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 --------
.../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c
index cc5337698b..0baee8795d 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c
@@ -182,14 +182,6 @@ PlatformHookSerialPortInitialize (
VOID
)
{
- UINT16 IndexPort;
- UINT16 DataPort;
- UINT8 Index;
-
- IndexPort = 0;
- DataPort = 0;
- Index = 0;
-
//
// Enable I/O decoding for COM1(3F8h-3FFh), COM2(2F8h-2FFh), I/O port 2Eh/2Fh, 4Eh/4Fh, 60h/64Fh and 62h/66h.
//
diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c
index 2ad229c1cd..0bba41e6d4 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c
@@ -393,6 +393,7 @@ TigerlakeURvpInitPreMem (
/// Performing PlatformInitPreMemCallBack after PeiReadOnlyVariable2 PPI produced
///
Status = PeiServicesNotifyPpi (&mPreMemNotifyList);
+ ASSERT_EFI_ERROR (Status);
///
/// After code reorangized, memorycallback will run because the PPI is already
@@ -400,6 +401,7 @@ TigerlakeURvpInitPreMem (
/// done before.
///
Status = PeiServicesNotifyPpi (&mMemDiscoveredNotifyList);
+ ASSERT_EFI_ERROR (Status);
DEBUG ((DEBUG_INFO, "TigerlakeURvpInitPreMem End!\n"));
--
2.30.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
2021-02-24 1:37 ` [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: " Takuto Naito
@ 2021-02-24 2:24 ` Heng Luo
0 siblings, 0 replies; 10+ messages in thread
From: Heng Luo @ 2021-02-24 2:24 UTC (permalink / raw)
To: devel@edk2.groups.io, naitaku@gmail.com
Cc: Chaganty, Rangasai V, Desimone, Nathaniel L
Reviewed-by: Heng Luo <heng.luo@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Takuto
> Naito
> Sent: Wednesday, February 24, 2021 9:38 AM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg:
> Fix build error with GCC5
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
>
> Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> These build errors occur only with DEBUG target because
> RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> DEBUG_GCC5_X64_CC_FLAGS doesn't.
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Signed-off-by: Takuto Naito <naitaku@gmail.com>
> ---
> .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 --------
> .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base
> PlatformHookLib.c
> b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Bas
> ePlatformHookLib.c
> index cc5337698b..0baee8795d 100644
> ---
> a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base
> PlatformHookLib.c
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/B
> +++ asePlatformHookLib.c
> @@ -182,14 +182,6 @@ PlatformHookSerialPortInitialize (
> VOID
> )
> {
> - UINT16 IndexPort;
> - UINT16 DataPort;
> - UINT8 Index;
> -
> - IndexPort = 0;
> - DataPort = 0;
> - Index = 0;
> -
> //
> // Enable I/O decoding for COM1(3F8h-3FFh), COM2(2F8h-2FFh), I/O port
> 2Eh/2Fh, 4Eh/4Fh, 60h/64Fh and 62h/66h.
> //
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLi
> b/PeiTigerlakeURvpInitPreMemLib.c
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLi
> b/PeiTigerlakeURvpInitPreMemLib.c
> index 2ad229c1cd..0bba41e6d4 100644
> ---
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLi
> b/PeiTigerlakeURvpInitPreMemLib.c
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardIn
> +++ itLib/PeiTigerlakeURvpInitPreMemLib.c
> @@ -393,6 +393,7 @@ TigerlakeURvpInitPreMem (
> /// Performing PlatformInitPreMemCallBack after PeiReadOnlyVariable2 PPI
> produced
> ///
> Status = PeiServicesNotifyPpi (&mPreMemNotifyList);
> + ASSERT_EFI_ERROR (Status);
>
> ///
> /// After code reorangized, memorycallback will run because the PPI is
> already @@ -400,6 +401,7 @@ TigerlakeURvpInitPreMem (
> /// done before.
> ///
> Status = PeiServicesNotifyPpi (&mMemDiscoveredNotifyList);
> + ASSERT_EFI_ERROR (Status);
>
> DEBUG ((DEBUG_INFO, "TigerlakeURvpInitPreMem End!\n"));
>
> --
> 2.30.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
2021-02-24 1:37 [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Takuto Naito
2021-02-24 1:37 ` [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: " Takuto Naito
2021-02-24 1:37 ` [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: " Takuto Naito
@ 2021-02-24 2:18 ` Nate DeSimone
2021-02-24 2:24 ` Heng Luo
2021-02-25 2:18 ` Nate DeSimone
4 siblings, 0 replies; 10+ messages in thread
From: Nate DeSimone @ 2021-02-24 2:18 UTC (permalink / raw)
To: Takuto Naito, devel@edk2.groups.io; +Cc: Chaganty, Rangasai V, Luo, Heng
Thank You Takuto!
For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com>
> Sent: Tuesday, February 23, 2021 5:38 PM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build
> error with GCC5
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
>
> Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> These build errors occur only with DEBUG target because
> RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> DEBUG_GCC5_X64_CC_FLAGS doesn't.
>
> https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but-
> set-variable_v1
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
>
> Takuto Naito (2):
> TigerlakeSiliconPkg: Fix build error with GCC5
> TigerlakeOpenBoardPkg: Fix build error with GCC5
>
> .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 --------
> .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++
> .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
> .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
> .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
> 5 files changed, 2 insertions(+), 17 deletions(-)
>
> --
> 2.30.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
2021-02-24 1:37 [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Takuto Naito
` (2 preceding siblings ...)
2021-02-24 2:18 ` [PATCH edk2-platforms v1 0/2] " Nate DeSimone
@ 2021-02-24 2:24 ` Heng Luo
2021-02-25 2:18 ` Nate DeSimone
4 siblings, 0 replies; 10+ messages in thread
From: Heng Luo @ 2021-02-24 2:24 UTC (permalink / raw)
To: Takuto Naito, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Desimone, Nathaniel L
Thanks Takuto Naito!
For the series..
Reviewed-by: Heng Luo <heng.luo@intel.com>
> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com>
> Sent: Wednesday, February 24, 2021 9:38 AM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build
> error with GCC5
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
>
> Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> These build errors occur only with DEBUG target because
> RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> DEBUG_GCC5_X64_CC_FLAGS doesn't.
>
> https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but-
> set-variable_v1
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
>
> Takuto Naito (2):
> TigerlakeSiliconPkg: Fix build error with GCC5
> TigerlakeOpenBoardPkg: Fix build error with GCC5
>
> .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 --------
> .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++
> .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
> .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
> .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
> 5 files changed, 2 insertions(+), 17 deletions(-)
>
> --
> 2.30.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
2021-02-24 1:37 [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Takuto Naito
` (3 preceding siblings ...)
2021-02-24 2:24 ` Heng Luo
@ 2021-02-25 2:18 ` Nate DeSimone
2021-02-27 14:40 ` Takuto Naito
4 siblings, 1 reply; 10+ messages in thread
From: Nate DeSimone @ 2021-02-25 2:18 UTC (permalink / raw)
To: Takuto Naito, devel@edk2.groups.io; +Cc: Chaganty, Rangasai V, Luo, Heng
The series has been pushed as 33ba808~.. 9951457
Thanks,
Nate
> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com>
> Sent: Tuesday, February 23, 2021 5:38 PM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build
> error with GCC5
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
>
> Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> These build errors occur only with DEBUG target because
> RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> DEBUG_GCC5_X64_CC_FLAGS doesn't.
>
> https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but-
> set-variable_v1
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
>
> Takuto Naito (2):
> TigerlakeSiliconPkg: Fix build error with GCC5
> TigerlakeOpenBoardPkg: Fix build error with GCC5
>
> .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 --------
> .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++
> .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
> .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
> .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
> 5 files changed, 2 insertions(+), 17 deletions(-)
>
> --
> 2.30.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
2021-02-25 2:18 ` Nate DeSimone
@ 2021-02-27 14:40 ` Takuto Naito
2021-03-02 2:47 ` Nate DeSimone
0 siblings, 1 reply; 10+ messages in thread
From: Takuto Naito @ 2021-02-27 14:40 UTC (permalink / raw)
To: Desimone, Nathaniel L
Cc: devel@edk2.groups.io, Chaganty, Rangasai V, Luo, Heng
[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]
Hi,
Actually, I have created a github repository which provides nightly builds
of some platforms in edk2-platoforms.
https://github.com/naitaku/edk2-platforms-build
Now that TigerlakeURvp is built successfully with GCC5, I have added it to
the target of the nightly builds.
Thank you for your support!
Regards,
Takuto Naito
On Thu, Feb 25, 2021 at 11:19 AM Desimone, Nathaniel L <
nathaniel.l.desimone@intel.com> wrote:
> The series has been pushed as 33ba808~.. 9951457
>
> Thanks,
> Nate
>
> > -----Original Message-----
> > From: Takuto Naito <naitaku@gmail.com>
> > Sent: Tuesday, February 23, 2021 5:38 PM
> > To: devel@edk2.groups.io
> > Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> > Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build
> > error with GCC5
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
> >
> > Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> > These build errors occur only with DEBUG target because
> > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> > DEBUG_GCC5_X64_CC_FLAGS doesn't.
> >
> > https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but-
> > set-variable_v1
> >
> > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Heng Luo <heng.luo@intel.com>
> >
> > Takuto Naito (2):
> > TigerlakeSiliconPkg: Fix build error with GCC5
> > TigerlakeOpenBoardPkg: Fix build error with GCC5
> >
> > .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 --------
> > .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++
> > .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
> > .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
> > .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
> > 5 files changed, 2 insertions(+), 17 deletions(-)
> >
> > --
> > 2.30.1
>
>
[-- Attachment #2: Type: text/html, Size: 3800 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
2021-02-27 14:40 ` Takuto Naito
@ 2021-03-02 2:47 ` Nate DeSimone
0 siblings, 0 replies; 10+ messages in thread
From: Nate DeSimone @ 2021-03-02 2:47 UTC (permalink / raw)
To: Takuto Naito; +Cc: devel@edk2.groups.io, Chaganty, Rangasai V, Luo, Heng
Thank you Takuto, that is very helpful!
From: Takuto Naito <naitaku@gmail.com>
Sent: Saturday, February 27, 2021 6:41 AM
To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: devel@edk2.groups.io; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Luo, Heng <heng.luo@intel.com>
Subject: Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
Hi,
Actually, I have created a github repository which provides nightly builds of some platforms in edk2-platoforms.
https://github.com/naitaku/edk2-platforms-build
Now that TigerlakeURvp is built successfully with GCC5, I have added it to the target of the nightly builds.
Thank you for your support!
Regards,
Takuto Naito
On Thu, Feb 25, 2021 at 11:19 AM Desimone, Nathaniel L <mailto:nathaniel.l.desimone@intel.com> wrote:
The series has been pushed as 33ba808~.. 9951457
Thanks,
Nate
> -----Original Message-----
> From: Takuto Naito <mailto:naitaku@gmail.com>
> Sent: Tuesday, February 23, 2021 5:38 PM
> To: mailto:devel@edk2.groups.io
> Cc: Takuto Naito <mailto:naitaku@gmail.com>; Chaganty, Rangasai V
> <mailto:rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <mailto:nathaniel.l.desimone@intel.com>; Luo, Heng <mailto:heng.luo@intel.com>
> Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build
> error with GCC5
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
>
> Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> These build errors occur only with DEBUG target because
> RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> DEBUG_GCC5_X64_CC_FLAGS doesn't.
>
> https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but-
> set-variable_v1
>
> Cc: Sai Chaganty <mailto:rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <mailto:nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <mailto:heng.luo@intel.com>
>
> Takuto Naito (2):
> TigerlakeSiliconPkg: Fix build error with GCC5
> TigerlakeOpenBoardPkg: Fix build error with GCC5
>
> .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 --------
> .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++
> .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
> .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
> .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
> 5 files changed, 2 insertions(+), 17 deletions(-)
>
> --
> 2.30.1
^ permalink raw reply [flat|nested] 10+ messages in thread