From: "Takuto Naito" <naitaku@gmail.com>
To: devel@edk2.groups.io
Cc: Takuto Naito <naitaku@gmail.com>,
Sai Chaganty <rangasai.v.chaganty@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Heng Luo <heng.luo@intel.com>
Subject: [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5
Date: Wed, 24 Feb 2021 10:37:35 +0900 [thread overview]
Message-ID: <20210224013736.74815-2-naitaku@gmail.com> (raw)
In-Reply-To: <20210224013736.74815-1-naitaku@gmail.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
These build errors occur only with DEBUG target because
RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable",
but DEBUG_GCC5_X64_CC_FLAGS doesn't.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
.../PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 --
.../IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 -----
.../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 --
3 files changed, 9 deletions(-)
diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c
index 15d295a573..231cb367bc 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c
+++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c
@@ -104,12 +104,10 @@ ConfigureRpLtrOverride (
UINT32 OvrEn;
UINT32 OvrVal;
BOOLEAN IsCpuPcie;
- UINT32 LtrCfgLock;
IsCpuPcie = FALSE;
OvrEn = 0;
OvrVal = 0;
- LtrCfgLock = 0;
if (DevNum == SA_PEG0_DEV_NUM || DevNum == SA_PEG3_DEV_NUM) {
IsCpuPcie = TRUE;
diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c
index faac07c45d..e88abe550f 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c
+++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c
@@ -313,8 +313,6 @@ DmarTableUpdate (
UINTN Offset;
UINTN StructureLen;
UINT64 McD0BaseAddress;
- UINT32 GttMmAdr;
- UINT64 McD2BaseAddress;
UINT16 IgdMode;
UINT16 GttMode;
UINT32 IgdMemSize;
@@ -381,9 +379,6 @@ DmarTableUpdate (
GttMemSize = (1 << GttMode) * (1024) * (1024);
}
- McD2BaseAddress = PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, IGD_BUS_NUM, IGD_DEV_NUM, IGD_FUN_NUM, 0);
- GttMmAdr = (PciSegmentRead32 (McD2BaseAddress + R_SA_IGD_GTTMMADR)) & 0xFFFFFFF0;
-
DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress = (PciSegmentRead32 (McD0BaseAddress + R_SA_BGSM) & ~(0x01));
DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionLimitAddress = DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress + IgdMemSize + GttMemSize - 1;
DEBUG ((DEBUG_INFO, "RMRR Base address IGD %016lX\n", DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress));
diff --git a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c
index 7693e76683..3adc05ce89 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c
+++ b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c
@@ -29,8 +29,6 @@ GetPcieRpNumber (
OUT UINTN *RpNumber
)
{
- UINT64 RpBase;
- RpBase = PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, SA_MC_BUS, RpDev, RpFun, 0);
GetPchPcieRpNumber (RpDev, RpFun, RpNumber);
}
--
2.30.1
next prev parent reply other threads:[~2021-02-24 1:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 1:37 [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Takuto Naito
2021-02-24 1:37 ` Takuto Naito [this message]
2021-02-24 2:24 ` [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: " Heng Luo
2021-02-24 1:37 ` [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: " Takuto Naito
2021-02-24 2:24 ` [edk2-devel] " Heng Luo
2021-02-24 2:18 ` [PATCH edk2-platforms v1 0/2] " Nate DeSimone
2021-02-24 2:24 ` Heng Luo
2021-02-25 2:18 ` Nate DeSimone
2021-02-27 14:40 ` Takuto Naito
2021-03-02 2:47 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224013736.74815-2-naitaku@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox