From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web11.1184.1614130748295588563 for ; Tue, 23 Feb 2021 17:39:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rffMcBQW; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: naitaku@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id gm18so212492pjb.1 for ; Tue, 23 Feb 2021 17:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OUMLpABVMRb7A7QuVDpGiTFVyly71oOC7uyoJ3kEkUY=; b=rffMcBQWm3XFAPYpfT3y206/jPdlX3IGqoyTd8J1rcaU73/DSI9ohcCoP0iXDy2T4M wwxJ+OGmFv7Cml66KHjWSq8WpQKlr06H4JkByQTfKjU3kbV+2baGB3v0U5afDvfgwWeB MnODrELKgv6Jd0GQyRVnZTik4fAdI80W/bVlX0wR4Uz7pPa6rfJ12fGpzzGpGJhhybim JAdkaiq0sNa+mht1BHD9NeVHvax16SXevi8wnh+OsfPUA+tfm5Gg92aXerTq1vgtm+85 Pr19n1JBxuvrpSWA32T7WV8sw1umCNaeiWTsEJ9qApaZCE5La2qNYuDmuRY5I8v+69tP aT1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OUMLpABVMRb7A7QuVDpGiTFVyly71oOC7uyoJ3kEkUY=; b=nOWmM49GYif3CagaF/79XALHiEa2StJpjjmvynDEhivreF/PcrWEOl02boOv7xxocN bXw9yfgwM2GHXKQZ1EExg7oYRc8k+17zeOpnulEmjwKqomEsey+Wd5UhunwEXSIS6H/T XSIdJZ8hN3pdAiBYSLJ9Detmtm8kdlnjvZ4A1bPTjuKUfbD9vCfffw+KJ7NDHzY5/t9l hVbyhf7fb9BTQP2FCRAmgUD1+mg0C+2pAOnZk+fwOBGDwrzg71syrEiQP009AKJyzkEu sB2zKPv99X17EQKDoWUsH3pkobIXjEoxOkYups2g7x5v3uHZ0GqGcs21woKuwjsPwVFj JKfA== X-Gm-Message-State: AOAM533jwuJUnZo0r13Zvmi8sRRDTFvqfpq2iLQqIM8BYgz0p/PIRz5c S8a0hZdalwioaw308K2F1f8kZb4/17IJd5aY X-Google-Smtp-Source: ABdhPJx1TJV2r9oM7tq4l4UjJFeOYyz026RGabWn8f+KlAQaY8gh7DEh/vFvj2s8a7p8aCaqh+Qt6Q== X-Received: by 2002:a17:90a:f493:: with SMTP id bx19mr1656536pjb.213.1614130747402; Tue, 23 Feb 2021 17:39:07 -0800 (PST) Return-Path: Received: from localhost.localdomain ([240d:1e:84:2c00:4c90:1fc7:fcf3:2538]) by smtp.googlemail.com with ESMTPSA id bj9sm340236pjb.49.2021.02.23.17.39.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Feb 2021 17:39:07 -0800 (PST) From: "Takuto Naito" To: devel@edk2.groups.io Cc: Takuto Naito , Sai Chaganty , Nate DeSimone , Heng Luo Subject: [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Date: Wed, 24 Feb 2021 10:37:36 +0900 Message-Id: <20210224013736.74815-3-naitaku@gmail.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210224013736.74815-1-naitaku@gmail.com> References: <20210224013736.74815-1-naitaku@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. These build errors occur only with DEBUG target because RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but DEBUG_GCC5_X64_CC_FLAGS doesn't. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Takuto Naito --- .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c index cc5337698b..0baee8795d 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c +++ b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePlatformHookLib.c @@ -182,14 +182,6 @@ PlatformHookSerialPortInitialize ( VOID ) { - UINT16 IndexPort; - UINT16 DataPort; - UINT8 Index; - - IndexPort = 0; - DataPort = 0; - Index = 0; - // // Enable I/O decoding for COM1(3F8h-3FFh), COM2(2F8h-2FFh), I/O port 2Eh/2Fh, 4Eh/4Fh, 60h/64Fh and 62h/66h. // diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c index 2ad229c1cd..0bba41e6d4 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c @@ -393,6 +393,7 @@ TigerlakeURvpInitPreMem ( /// Performing PlatformInitPreMemCallBack after PeiReadOnlyVariable2 PPI produced /// Status = PeiServicesNotifyPpi (&mPreMemNotifyList); + ASSERT_EFI_ERROR (Status); /// /// After code reorangized, memorycallback will run because the PPI is already @@ -400,6 +401,7 @@ TigerlakeURvpInitPreMem ( /// done before. /// Status = PeiServicesNotifyPpi (&mMemDiscoveredNotifyList); + ASSERT_EFI_ERROR (Status); DEBUG ((DEBUG_INFO, "TigerlakeURvpInitPreMem End!\n")); -- 2.30.1