From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.groups.io with SMTP id smtpd.web12.5915.1614167384863113442 for ; Wed, 24 Feb 2021 03:49:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Zkwd6Olt; spf=pass (domain: nuviainc.com, ip: 209.85.221.50, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f50.google.com with SMTP id v15so1604836wrx.4 for ; Wed, 24 Feb 2021 03:49:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M/sx4co/z7OzBCq3ljhSy6Ss5SsjKQHCP4pJHBHsZig=; b=Zkwd6OltQLDPEpamDnh/vhQ1EjKIxyUvSfo3KBG+czB1gL3w9EGloWppjVKM5WSjOv d1SLqhqJd9gbu0+fudhdp0f1ywXQBDAP/VvEJ53bjsFJPO3HMPFkYzwHR/esxgO13Hnj nVbR0UAFRDCtYX2JMuEVyPqlC4btPjXptOC6d4OaDrsrAaW3bBZecyD+T/UbQYF0eseD lAqJdBNM69c/0g6HSw7aRWtfejVlkNcp0fDKQzbq5g4Tf/ZCNHFkqXo7oUcxhPI0Wsgb IIg4AnbTigNWYRhbW4S96w9CEJJv1LJkuIbSreBqtwQ30u7KIJ8taRp5LhpAtag1H9nQ rBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M/sx4co/z7OzBCq3ljhSy6Ss5SsjKQHCP4pJHBHsZig=; b=bzhNZVo4wwpPGvhzTJBkPssekdgPbn8GaSjTdtQBmgr1A5pFxGxOWNEEOi36v2fJIc p+si1lMbQVFID8FGRJPZG+pzaLus8VS9l2EgGDElZ8fhPglLpdSoP8mImFIU2ohqEb4t g8EbP4cRfvIPgLhVcqH+GrvcMeOOAXpI0gS8h8LGRetSuazkUxYTpjgYNA90CQnOk9S9 kQ09oK0A1c5GLTFj2Zft/xmZBKN5mQgiRLGFaCRx0czT3FEa5na65CjHyC3kh/3PAVNc WgTaIO1DOJgYgLy/GETiW9n1j0QxVFQ3XNOjM2lmLIwgnNxlqkYk9lRr+OjTgJRx6EEg dI8A== X-Gm-Message-State: AOAM530OB5An13nd/DZ6OEJf1Uv8wTmT93cYHUtEGEKYHWTK0VcK/3Th PSb6VrqBwj4HLYX/2uUU5TSYVd6zHatdYCZclZ4nadVu3/ocRK57RbHigcQLtWL8zHTolJRSrwg vQwXo+jKi1Wl39mKYIMC5ot5ZxpbBNygGaEsih5eboOsuKqnFeGYz4GbtY27Dkq9hNA== X-Google-Smtp-Source: ABdhPJxrZP02DcJgewREhZIQsSAg44jemDOsGh9nzmvoa0zsZI9fAftzD/aZVhkn1UIP3K2PPEXypQ== X-Received: by 2002:a5d:5108:: with SMTP id s8mr3074711wrt.13.1614167382638; Wed, 24 Feb 2021 03:49:42 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id z5sm3134537wrn.8.2021.02.24.03.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 03:49:42 -0800 (PST) Date: Wed, 24 Feb 2021 11:49:40 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, huangming@linux.alibaba.com Cc: Ard Biesheuvel , guoheyi@linux.alibaba.com Subject: Re: [edk2-devel] [PATCH edk2 v2 1/1] ArmPkg/ArmGic: Fix GICR_IPRIORITYR address wrong issue Message-ID: <20210224114940.GL1664@vanye> References: <20210223110642.90020-1-huangming@linux.alibaba.com> <20210223125808.GA1664@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ming, Thanks for this. However, just after I sent my reply, Heyi suggested another improvement to this patch. Can you please implement that, and submit a v2? Best Regards, Leif On Wed, Feb 24, 2021 at 16:26:33 +0800, Ming Huang wrote: > > > On 2/23/21 8:58 PM, Leif Lindholm wrote: > > On Tue, Feb 23, 2021 at 13:42:49 +0100, Ard Biesheuvel wrote: > >> On Tue, 23 Feb 2021 at 12:07, Ming Huang wrote: > >>> > >>> The register address of GICR_IPRIORITYR is in SGI_base frame. Add > >>> IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise > >>> GIC RAS error(Uncorrected software error) may report in ArmGicDxe. > >> > >> NOTE: missing sign-off > >> > >> Patch seems fine to me > >> > >> Tested-by: Ard Biesheuvel # QEMU/kvm guest on ThunderX2 > > > > Also looks good in QEMU. > > Reviewed-by: Leif Lindholm > > > > Ming, can you confirm that the contribution conforms to the developer > > certificate of origin by replyint with your Signed-off-by: ? > > Sorry, I miss the Signed-off-by. > please help to add my Signed-off-by: > Signed-off-by: Ming Huang > > Thanks, > Ming > > > > >> > >> > >> > >>> --- > >>> ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 ++++- > >>> 1 file changed, 4 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > >>> index 8ef32b33a1..b4d3965acb 100644 > >>> --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c > >>> +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > >>> @@ -30,6 +30,9 @@ > >>> #define ICENABLER_ADDRESS(base,offset) ((base) + \ > >>> ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ICENABLER + (4 * offset)) > >>> > >>> +#define IPRIORITY_ADDRESS(base,offset) ((base) + \ > >>> + ARM_GICR_CTLR_FRAME_SIZE + ARM_GIC_ICDIPR + (4 * offset)) > >>> + > >>> /** > >>> * > >>> * Return whether the Source interrupt index refers to a shared interrupt (SPI) > >>> @@ -236,7 +239,7 @@ ArmGicSetInterruptPriority ( > >>> } > >>> > >>> MmioAndThenOr32 ( > >>> - GicCpuRedistributorBase + ARM_GIC_ICDIPR + (4 * RegOffset), > >>> + IPRIORITY_ADDRESS (GicCpuRedistributorBase, RegOffset), > >>> ~(0xff << RegShift), > >>> Priority << RegShift > >>> ); > >>> -- > >>> 2.17.1 > >>> > > > > >