public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ming Huang" <huangming@linux.alibaba.com>
To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com
Cc: guoheyi@linux.alibaba.com, Ming Huang <huangming@linux.alibaba.com>
Subject: [PATCH edk2 v2 1/2] ArmPkg/ArmGicLib: Fix two macros issue for offset parameter
Date: Thu, 25 Feb 2021 11:32:11 +0800	[thread overview]
Message-ID: <20210225033212.2180-2-huangming@linux.alibaba.com> (raw)
In-Reply-To: <20210225033212.2180-1-huangming@linux.alibaba.com>

Modify two macros to put "offset" in parentheses and remove
parentheses from "4 * offset".

Signed-off-by: Ming Huang <huangming@linux.alibaba.com>
---
 ArmPkg/Drivers/ArmGic/ArmGicLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c
index 8ef32b33a1..5d04ed3dac 100644
--- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c
+++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c
@@ -25,10 +25,10 @@
                                            + ARM_GICR_SGI_RESERVED_FRAME_SIZE)
 
 #define ISENABLER_ADDRESS(base,offset) ((base) + \
-          ARM_GICR_CTLR_FRAME_SIZE +  ARM_GICR_ISENABLER + (4 * offset))
+          ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ISENABLER + 4 * (offset))
 
 #define ICENABLER_ADDRESS(base,offset) ((base) + \
-          ARM_GICR_CTLR_FRAME_SIZE +  ARM_GICR_ICENABLER + (4 * offset))
+          ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ICENABLER + 4 * (offset))
 
 /**
  *
-- 
2.17.1


  reply	other threads:[~2021-02-25  3:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25  3:32 [PATCH edk2 v2 0/2] Fix two issue in ArmGicLib Ming Huang
2021-02-25  3:32 ` Ming Huang [this message]
2021-02-25  3:32 ` [PATCH edk2 v2 2/2] ArmPkg/ArmGicLib: Fix GICR_IPRIORITYR address wrong issue Ming Huang
2021-02-25 12:04 ` edk2-stable202102 Re: [PATCH edk2 v2 0/2] Fix two issue in ArmGicLib Leif Lindholm
2021-02-25 13:50   ` 回复: " gaoliming
2021-02-26  3:23     ` [edk2-devel] " Quan Nguyen
2021-03-01 13:20 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210225033212.2180-2-huangming@linux.alibaba.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox