public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh
@ 2021-02-26 12:39 Heinrich Schuchardt
  2021-03-01  1:32 ` 回复: " Gao Jie
  2021-03-02 15:53 ` G Edhaya Chandran
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-02-26 12:39 UTC (permalink / raw)
  To: EDK II Development
  Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen,
	Samer El-Haj-Mahmoud, Heinrich Schuchardt

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3239

A superfluous carriage return leads to an error:

uefi-sct/SctPkg/build.sh: line 61:
syntax error near unexpected token `fi'
uefi-sct/SctPkg/build.sh: line 61:
`    fi'

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 uefi-sct/SctPkg/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh
index 2efc5535b8fc..de7a10034e3d 100755
--- a/uefi-sct/SctPkg/build.sh
+++ b/uefi-sct/SctPkg/build.sh
@@ -56,7 +56,7 @@ function get_gcc_version
 {
 	gcc_version=$($1 -dumpversion)

-	if [ ${gcc_version%%.*} -ge 5 ]; then
+	if [ ${gcc_version%%.*} -ge 5 ]; then
 		gcc_version=5
 	fi

--
2.30.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* 回复: [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh
  2021-02-26 12:39 [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh Heinrich Schuchardt
@ 2021-03-01  1:32 ` Gao Jie
  2021-03-02 15:53 ` G Edhaya Chandran
  1 sibling, 0 replies; 3+ messages in thread
From: Gao Jie @ 2021-03-01  1:32 UTC (permalink / raw)
  To: 'Heinrich Schuchardt', 'EDK II Development'
  Cc: 'Eric Jin', 'G Edhaya Chandran',
	'Arvin Chen', 'Samer El-Haj-Mahmoud'

Reviewed-by: Barton Gao <gaojie@byosoft.com.cn>

Thanks
Barton

-----邮件原件-----
发件人: Heinrich Schuchardt <xypron.glpk@gmx.de> 
发送时间: 2021年2月26日 20:40
收件人: EDK II Development <devel@edk2.groups.io>
抄送: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran <Edhaya.Chandran@arm.
com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin Chen
<arvinx.chen@intel.com>; Samer El-Haj-Mahmoud
<Samer.El-Haj-Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
主题: [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3239

A superfluous carriage return leads to an error:

uefi-sct/SctPkg/build.sh: line 61:
syntax error near unexpected token `fi'
uefi-sct/SctPkg/build.sh: line 61:
`    fi'

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 uefi-sct/SctPkg/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
2efc5535b8fc..de7a10034e3d 100755
--- a/uefi-sct/SctPkg/build.sh
+++ b/uefi-sct/SctPkg/build.sh
@@ -56,7 +56,7 @@ function get_gcc_version  {
 	gcc_version=$($1 -dumpversion)

-	if [ ${gcc_version%%.*} -ge 5 ]; then
+	if [ ${gcc_version%%.*} -ge 5 ]; then
 		gcc_version=5
 	fi

--
2.30.0




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh
  2021-02-26 12:39 [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh Heinrich Schuchardt
  2021-03-01  1:32 ` 回复: " Gao Jie
@ 2021-03-02 15:53 ` G Edhaya Chandran
  1 sibling, 0 replies; 3+ messages in thread
From: G Edhaya Chandran @ 2021-03-02 15:53 UTC (permalink / raw)
  To: Heinrich Schuchardt, EDK II Development
  Cc: Eric Jin, Barton Gao, Arvin Chen, Samer El-Haj-Mahmoud

Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com>

> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: 26 February 2021 18:10
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
> Subject: [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3239
>
> A superfluous carriage return leads to an error:
>
> uefi-sct/SctPkg/build.sh: line 61:
> syntax error near unexpected token `fi'
> uefi-sct/SctPkg/build.sh: line 61:
> `    fi'
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  uefi-sct/SctPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
> 2efc5535b8fc..de7a10034e3d 100755
> --- a/uefi-sct/SctPkg/build.sh
> +++ b/uefi-sct/SctPkg/build.sh
> @@ -56,7 +56,7 @@ function get_gcc_version  {
>  gcc_version=$($1 -dumpversion)
>
> -if [ ${gcc_version%%.*} -ge 5 ]; then
> +if [ ${gcc_version%%.*} -ge 5 ]; then
>  gcc_version=5
>  fi
>
> --
> 2.30.0

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-02 15:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-26 12:39 [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh Heinrich Schuchardt
2021-03-01  1:32 ` 回复: " Gao Jie
2021-03-02 15:53 ` G Edhaya Chandran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox