From: "Jeremy Linton" <jeremy.linton@arm.com>
To: devel@edk2.groups.io
Cc: pete@akeo.ie, awarkentin@vmware.com,
samer.el-haj-mahmoud@arm.com, leif@nuviainc.com,
ardb+tianocore@kernel.org, Jeremy Linton <jeremy.linton@arm.com>
Subject: [BUG] Platform/RaspberryPi/Acpitables: Correct duplicate _UIDs
Date: Fri, 26 Feb 2021 12:24:58 -0600 [thread overview]
Message-ID: <20210226182458.398136-1-jeremy.linton@arm.com> (raw)
From: Jeremy Linton <jeremy.linton@arm.com>
The new emmc2 device adds a container with a _UID of 0
which duplicates an existing ACPI container.
This causes windows to fail to boot with a Stop ACPI_BIOS_ERROR.
The workaround without this fix is to go into the BDS menus and
set the SD routing to the Arasan.
Fixes: 311ed3c790 ("Platform/RaspberryPi/Acpitables: Add eMMC2 device and
tweak Arasan")
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryPi/AcpiTables/Emmc.asl
index 984db4eaa9..179dd3ecdb 100644
--- a/Platform/RaspberryPi/AcpiTables/Emmc.asl
+++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl
@@ -18,7 +18,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC", 2)
#if (RPI_MODEL == 4)
Device (GDV1) {
Name (_HID, "ACPI0004")
- Name (_UID, 0x0)
+ Name (_UID, 0x2)
Name (_CCA, 0x0)
Name (RBUF, ResourceTemplate ()
--
2.13.7
next reply other threads:[~2021-02-26 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 18:24 Jeremy Linton [this message]
2021-02-26 18:40 ` [BUG] Platform/RaspberryPi/Acpitables: Correct duplicate _UIDs Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226182458.398136-1-jeremy.linton@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox