From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.13661.1614363901598273208 for ; Fri, 26 Feb 2021 10:25:02 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6148331B; Fri, 26 Feb 2021 10:25:00 -0800 (PST) Received: from u200856.usa.arm.com (unknown [10.119.48.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1CA9C3F73D; Fri, 26 Feb 2021 10:25:00 -0800 (PST) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: pete@akeo.ie, awarkentin@vmware.com, samer.el-haj-mahmoud@arm.com, leif@nuviainc.com, ardb+tianocore@kernel.org, Jeremy Linton Subject: [BUG] Platform/RaspberryPi/Acpitables: Correct duplicate _UIDs Date: Fri, 26 Feb 2021 12:24:58 -0600 Message-Id: <20210226182458.398136-1-jeremy.linton@arm.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Jeremy Linton The new emmc2 device adds a container with a _UID of 0 which duplicates an existing ACPI container. This causes windows to fail to boot with a Stop ACPI_BIOS_ERROR. The workaround without this fix is to go into the BDS menus and set the SD routing to the Arasan. Fixes: 311ed3c790 ("Platform/RaspberryPi/Acpitables: Add eMMC2 device and tweak Arasan") Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryP= i/AcpiTables/Emmc.asl index 984db4eaa9..179dd3ecdb 100644 --- a/Platform/RaspberryPi/AcpiTables/Emmc.asl +++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl @@ -18,7 +18,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC= ", 2) #if (RPI_MODEL =3D=3D 4)=0D Device (GDV1) {=0D Name (_HID, "ACPI0004")=0D - Name (_UID, 0x0)=0D + Name (_UID, 0x2)=0D Name (_CCA, 0x0)=0D =0D Name (RBUF, ResourceTemplate ()=0D --=20 2.13.7