public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Daniel Schaefer" <daniel.schaefer@hpe.com>
To: <devel@edk2.groups.io>
Cc: Bob Feng <bob.c.feng@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Yuwei Chen <yuwei.chen@intel.com>, Derek Lin <derek.lin2@hpe.com>
Subject: [PATCH v1 0/2] BaseTools: Make undefined VFR macro an error
Date: Tue,  2 Mar 2021 16:21:48 +0800	[thread overview]
Message-ID: <20210302082150.15478-1-daniel.schaefer@hpe.com> (raw)

See the individual commit descriptions.
I split it up into GCC/CLANG and MSVC commits but feel free to squash
them if you think they belong together.

We found a few bugs and lots of dead code with this in our internal
code-base.
I only tested GCC5, CLANBPDB and VS2015 toolchains. Not 100% sure if
this warnings exists in the old MSVC toolchains.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Derek Lin <derek.lin2@hpe.com>

Daniel Schaefer (2):
  BaseTools: Make undefined VFR macro an error (GCC)
  BaseTools: Make undefined VFR macro an error (MSVC)

 BaseTools/Conf/tools_def.template | 50 ++++++++++----------
 1 file changed, 25 insertions(+), 25 deletions(-)

-- 
2.30.0


             reply	other threads:[~2021-03-02  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02  8:21 Daniel Schaefer [this message]
2021-03-02  8:21 ` [PATCH v1 1/2] BaseTools: Make undefined VFR macro an error (GCC) Daniel Schaefer
2021-03-08  1:05   ` [edk2-devel] " Bob Feng
2021-03-08  3:44     ` Daniel Schaefer
     [not found]     ` <166A41333DA0F959.3944@groups.io>
2021-04-23  8:22       ` Daniel Schaefer
2021-03-02  8:21 ` [PATCH v1 2/2] BaseTools: Make undefined VFR macro an error (MSVC) Daniel Schaefer
2021-03-04  2:12   ` 回复: " gaoliming
2021-03-04  2:46     ` Daniel Schaefer
2021-04-23  8:21       ` Daniel Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302082150.15478-1-daniel.schaefer@hpe.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox