From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.57]) by mx.groups.io with SMTP id smtpd.web10.7818.1614783709940084427 for ; Wed, 03 Mar 2021 07:01:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=MUuDqrvE; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.57, mailfrom: ashish.kalra@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IB9dZiQyXZ5Jpya+KfBpNY3bvylfzqxZQ8qiN0g+U9B96Fhbu5YeVYNvefUW5y3yWlr3JsNj/Rj0M3Fd7Df6vr0vKaa4RTEQkdClOeqDmVNzd624/9lu1RUUX9m024hrdGyNHNiDy4Uiu/AcpAwA/ansNT6HfoLCVSDIoeXJbkTPgnUVFr46jOdKqQmIP5h+PPGQ1SJvfV/SEc4gxESI/J81PP54YnwHckZt0D97iXoNfXHq39jp75tgut0Fmh4RGPitNIlWSOBRyQ7qeBQ+EM0e33cEUBSMP8M/SRbeFIvip09t72mBMG8lRh5ilaUuciXwKKT4jJwtk76SWLc5Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjc/hd+JZ+47XQxNea9SIP0HUsQkZwStIzPkSWfBLnk=; b=MdnM0CU1VV7mT1n/xicN7oQfz4tQFWh7M3vOIk4foOaBzRk+aVb2nlCsp3Rfif52HCE7kfBIFIB0bDkjM3U6+BXqtQJeB+4smeAmRQgPHcP1ytVCa811W9uyxOcLKjFwskyRE+Obc5Nc3RCYvUMs6nqtm9O/07x4b9VPjik0kEYqcZgGFqXe9wUL0n6lGGAILEPJ6fL8O1jlL3QiHr/Y1X/xtelleezAydo1FAVmXAG3l35NVIRGwHzn+nEsqWBbyDT2Vash93b8FyHszdhFVZOl8qxA/vWWLeRMKxW+HYPBa2u+BSEd9rzYdRwIAeiaK9zs86Ix+QEn5iFXBNnNdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjc/hd+JZ+47XQxNea9SIP0HUsQkZwStIzPkSWfBLnk=; b=MUuDqrvEkxiqPt0w89A3smVCCR2ltSnJO7XWrXHQN1zSKw16r38Er8jtQCxY7Uql3jaqYawsRxpMZ1RULZRC25wGhOC0G7FKCJc7RpfkqkKBw/AnbKS9BaF3xokYH82SnPmQgUgzoLP8TfgvxS/M3nENr7LfPGI7FmfLbMcxIh4= Authentication-Results: linux.ibm.com; dkim=none (message not signed) header.d=none;linux.ibm.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) by SN1PR12MB2445.namprd12.prod.outlook.com (2603:10b6:802:31::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Wed, 3 Mar 2021 15:01:48 +0000 Received: from SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::24bb:3e53:c95e:cb8e]) by SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::24bb:3e53:c95e:cb8e%7]) with mapi id 15.20.3912.018; Wed, 3 Mar 2021 15:01:48 +0000 Date: Wed, 3 Mar 2021 15:01:42 +0000 From: "Ashish Kalra" To: Tobin Feldman-Fitzthum Cc: devel@edk2.groups.io, Dov Murik , Tobin Feldman-Fitzthum , James Bottomley , Hubertus Franke , Brijesh Singh , Jon Grimm , Tom Lendacky Subject: Re: [edk2-devel] [RFC PATCH 02/14] OvmfPkg/PlatformPei: Mark SEC GHCB page in the page encrpytion bitmap. Message-ID: <20210303150142.GA31610@ashkalra_ubuntu_server> References: <20210302204839.82042-1-tobin@linux.ibm.com> <20210302204839.82042-3-tobin@linux.ibm.com> <20210303001601.GA30351@ashkalra_ubuntu_server> <5950410f-4716-fc45-4b05-042b00e5fb44@linux.ibm.com> In-Reply-To: <5950410f-4716-fc45-4b05-042b00e5fb44@linux.ibm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN6PR01CA0010.prod.exchangelabs.com (2603:10b6:805:b6::23) To SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) Return-Path: ashish.kalra@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ashkalra_ubuntu_server (165.204.77.1) by SN6PR01CA0010.prod.exchangelabs.com (2603:10b6:805:b6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 15:01:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7b9171f5-9453-4d14-1a4f-08d8de5544bb X-MS-TrafficTypeDiagnostic: SN1PR12MB2445: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XQ1s9opRdVB/MOVNLj8obhiq+idiH4TfgANxwH8ncvDiTo54A+VgA1+jNE2yiXkhXLHZVES02gh8g73tDpAI4kEp0oPXdEZ/1XViyM+sH0ZF9wwJRGpPGAHDUraJdZtJ0us2Vp4jAf7NKtzyrNkL65gGExP4bri7czwQgdgulP9Mampk2+Qx52aCB/azUGPoo+jl8jyWaedcP+sMTt2z5dyQ0F08pN/6MIfsR8vfUdKlTk+PcnWmkxJZMsVGf+P5i+SFWfvXsiWdHETS4uuq/TylK9thhfHqK2f+2LxDUI5MFV0GvW1Dj6H2IisRMGQM6BAMhkz+rnqF49mOh05BzBlpF8qvUdo8Ut4GDSDjorZ72dqpJwymIFwRAzU7DdJUW70CZl75zpAQgukuVujLrw3C62QI3pJrfv3txYyC0ge3TwqiqQ7ist9uJ/AVo1h4t/CdmsnFZsbDACfYwK+8Jif3WZqmdNuGO3EFwjOyWdowYHpaWfIl9LIqydwP7qnJfwc8SqIxywSGTeATjt1NLA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2767.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(366004)(39860400002)(136003)(66946007)(66556008)(1076003)(6496006)(478600001)(16526019)(4326008)(86362001)(52116002)(44832011)(5660300002)(6666004)(6916009)(9686003)(8676002)(55016002)(26005)(8936002)(316002)(956004)(186003)(54906003)(66476007)(33716001)(33656002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?wM9hqnBDdK5eAPurbkuSq5txUa446FKGCGZJsa/yg56/PF4Eojl3od3p+B/G?= =?us-ascii?Q?l4TRwhlOQmdtc03DINd5SGzkcxYjkLmJl67zLq9dl4NY7FO5YRuWIcq3RSkJ?= =?us-ascii?Q?yHRCjlqBuYt3B0qGyQunTlVUPcmMh67QAKiEO/Wd0IuoxbHgsugd5T/IDlNa?= =?us-ascii?Q?ExKV2lI6ea0ddS6Kci9f+XiMwV4WmY4ARjXxEHXUxtl8sRH9G1DvQXJtk0uI?= =?us-ascii?Q?tUPTzXVZTFGV1P6Mh1u6/cEvI9XxYEQ5hx+uRoZraZzcjL9qLCzqUWtYt4EV?= =?us-ascii?Q?c4sSWJkcgxvKNF3bPzo99yTKdWmxzB1qPCk9sZsu6uQG5mYWJ//l1nI00cJ4?= =?us-ascii?Q?yq3KDVPfu88fQXxNKdSg34DBFC/9vUL1ESQZviQhczJ7OFASSSwgS6LpO+1M?= =?us-ascii?Q?2E+bJyK+qYn4W13uhuKqQUCoo7nwOTQqvKIriMdqKEU22UnonqJW0Vkk9pkG?= =?us-ascii?Q?MX6yJ4wCC9wuryD/NlR2amcr7HQenqjuGv5gLCKu5F/MIFqLC8mSLNueptZV?= =?us-ascii?Q?3OPFTV4ZAmHERUPJw501DKRf8C7H45ava1WUdi4yX+7OxUQ7QL9yz7EqUzPr?= =?us-ascii?Q?XM32sJAxqaUwTubqPNJ3mqOqiQ7BHQy9/tCQFp7bu2BrBj4uBhJ+qlywXZeG?= =?us-ascii?Q?vQYJfF6dF9nx7rX2LTaoKYa64NxlSeFGF2iJwW4WXo+zQW4eSCKKZSumfDLN?= =?us-ascii?Q?UH0jpI+0Rij9zr3XD7dmxJTEaYPJukgODEpfn5LHvp6Lm4TCvtahJCQd1X4j?= =?us-ascii?Q?r0g6tCvjGlqTno1Q8pgOXOYw4gyg20sftspHMPbZAWYVWlENUk3mK3NqgKyg?= =?us-ascii?Q?33zZv3fG39SW+VBgq1FdYvJc/4ZBPrd8d8CmIsIZZB6MPQQojWdQX9MdGtei?= =?us-ascii?Q?X2nrh2lCgoG9sg+jQqgioZE/ah+Sa1iDxTM8XKnZ/xP0j6FkjkChtsRKrc0u?= =?us-ascii?Q?uQ86UQkIiFJLd9T9nmTNp0uPOREOOMtcbVp5AFUraLlfOIjMF4cxDFCvUk0s?= =?us-ascii?Q?pK9NjKAtv11d1qSxC8l1jVNHjv5Jf36ie+dWsks/2Wr6naQSCG533L94+L+M?= =?us-ascii?Q?XbGaoBfCouXTZdbpVEHT6xK91ZjGVZUeBSmOzE1pPNTj/3Uk1+xbu+tBv45q?= =?us-ascii?Q?3iWUj/uVKQuUFX7KAiPb9MFi5CTPezqGUrJjpfapkeSzwJx/B/sL+uK57T06?= =?us-ascii?Q?XZE5vxtBSC8AqyR4GAaWIp4ZlOEwkxNWOH6BMiwl9i8MWdCBHRllV2TA3voj?= =?us-ascii?Q?eZ2soq5NXO6Du0ZqFfOuGyL41cPtdBPYKTemeLSHAC8Bz7tS7bAJO43mv9H/?= =?us-ascii?Q?NrdGFd8c070vFbxAzI7jAj/C?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9171f5-9453-4d14-1a4f-08d8de5544bb X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 15:01:48.2012 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TnUv3xrucALHJabgm2IPyXKtLsOVUEY/a65CrldJ54FjddjhEf7VWGfUHqaiQFB0vOATvrc2sG4C07WkMupmgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2445 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 03, 2021 at 09:56:00AM -0500, Tobin Feldman-Fitzthum wrote: > > > Hello Tobin, > > > > Just a high level question, why is this patch included in this > > patch series, i don't think you are supporting SEV-ES platform > > migration in this patch-set ? > > You are correct that we don't support migration for SEV-ES machines, > although our approach can potentially be adapted for SEV-ES. I was on the > fence about including this patch, because we don't strictly need it for > migration. I'm not sure if the SEC GHCB would be significant even if we did > support SEV-ES migration. Ultimately it seemed like a good idea because the > SEV firmware build does otherwise support SEV-ES. Since I was introducing > the hypercall in an environment where SEV-ES can be enabled, it seemed > reasonable to include. Syncing page encryption status hypothetically has > uses beyond migration. > > Note that I am not adding full support for the hypercall in OVMF, which > might be a good idea at some point. > Yes, i don't see the assembler code stub for the hypercall in the OVMF patches, so i was wondering the same. Thanks, Ashish