Re: [edk2-devel] [PATCH 0/2 v5] Add support for running StandaloneMm as OP-TEE TA

["Leif Lindholm" <leif@nuviainc.com>]

Hi Sami,

My £0.05 would be something like:
- Drivers/OpTee/OpteeRpmbPkg
- Platform/StandaloneMm/PlatformStandaloneMmPkg

I think until we have more generic STMM solutions, it may be tricky
to figure out the optimal layout, so if the yneed to change in future,
that's fine.

/
    Leif

On Wed, Mar 03, 2021 at 11:32:53 +0000, Sami Mujawar wrote:
> Hi Ard, Leif,
> 
> This patch series is creating 2 new folders Platform/StMMRpmb & Drivers/OpTeeRpmb.
>    - Should these be in Drivers\StandaloneMmRpmbPkg similar to Drivers\OptionRomPkg ?
>    - Also, the maintainer.txt file would need updating accordingly.
> 
> Any advice/suggestions about this, please.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ilias Apalodimas via groups.io
> Sent: 12 February 2021 05:35 PM
> To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: ardb+tianocore@kernel.org; sughosh.ganu@linaro.org; leif@nuviainc.com; Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Subject: [edk2-devel] [PATCH 0/2 v5] Add support for running StandaloneMm as OP-TEE TA
> 
> Hi, 
> 
> This is v5 of [1] 
> 
> Changes since V4:
>  - More coding stule fixes proposed by Sami, which Ecc or Patchcheck didn't
>    report.
>  - Adding missing error handling in InitializeFvAndVariableStoreHeaders().
>    An allocation wasn't properly checked for success
> 
> Changes since V3:
>  - Coding style fixes proposed by Sami
>  - Fixed all reported PatchCheck errors
>  - Added overflow checks on the base aaddress allocated for EFI variables.
>    The size of the partition is user defined (via Pcd's) and the memory layout
>    and allocation address depends on OP-TEE. So let's make sure we won't overflow
>    when calculating the 3 partitions needed for FTW
>  - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing
>  - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm.dsc
>  - Added reviewed-by tags on patch 2/2
> 
> Changes since V2:
>  - Allocate a dynamic number of pages based on the Pcd values instead
>    of a static number
>  - Clean up unused structs in header file
>  - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0
> 
> Changes since V1:
> Some enhancements made by Ilias to the Optee Rpmb driver
> 
> [1] https://edk2.groups.io/g/devel/message/66483?p=,,,20,0,0,0::Created,,ilias+apalodimas,20,2,0,77703661
> 
> Ilias Apalodimas (2):
>   Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
>   StMMRpmb: Add support for building StandaloneMm image for OP-TEE
> 
>  Drivers/OpTeeRpmb/FixupPcd.c               |  89 ++
>  Drivers/OpTeeRpmb/FixupPcd.inf             |  43 +
>  Drivers/OpTeeRpmb/OpTeeRpmbFv.inf          |  58 ++
>  Drivers/OpTeeRpmb/OpTeeRpmbFvb.c           | 920 +++++++++++++++++++++
>  Drivers/OpTeeRpmb/OpTeeRpmbFvb.h           |  52 ++
>  Platform/StMMRpmb/PlatformStandaloneMm.dsc | 165 ++++
>  Platform/StMMRpmb/PlatformStandaloneMm.fdf | 111 +++
>  7 files changed, 1438 insertions(+)
>  create mode 100644 Drivers/OpTeeRpmb/FixupPcd.c
>  create mode 100644 Drivers/OpTeeRpmb/FixupPcd.inf
>  create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFv.inf
>  create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFvb.c
>  create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFvb.h
>  create mode 100644 Platform/StMMRpmb/PlatformStandaloneMm.dsc
>  create mode 100644 Platform/StMMRpmb/PlatformStandaloneMm.fdf
> 
> -- 
> 2.30.0
> 
> 
> 
> 
> 
>