[PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Laszlo Ersek]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249

Generalize the current OVMF SEV subsystem entry, so that we can use it
for Intel TDX in the future, ensuring proper patch circulation for
reviews.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>

Thanks
Laszlo

Laszlo Ersek (2):
  Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
    #3077
  Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"

 Maintainers.txt | 28 +++++++++++++-------
 1 file changed, 18 insertions(+), 10 deletions(-)


base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
-- 
2.19.1.3.g30247aa5d201

[PATCH 1/2] Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and #3077

[Laszlo Ersek]

Tom added initial SEV-ES support (tracked under TianoCore#2198) in commit
range 7f7f511c5a74..7f0b28415cb4. The last commit in that range created
the "OvmfPkg: SEV-related modules" section in "Maintainers.txt".

However, we didn't list the "OvmfPkg/ResetVector" module, which had
received significant updates, enabling QEMU to learn details about the
firmware, from parsing the flash image. The SEC phase of OVMF
("OvmfPkg/Sec") gained a new responsibility as well (#VC exception
handling). List both modules now.

James introduced the remote attested / encrypted boot OVMF platform (under
TianoCore#3077) in commit range ef3e73c6a0c0..01726b6d23d4. This work
further extended "OvmfPkg/ResetVector", and added:

  OvmfPkg/AmdSev/
  OvmfPkg/Include/Guid/ConfidentialComputingSecret.h
  OvmfPkg/Library/PlatformBootManagerLibGrub/

List these too in the "OvmfPkg: SEV-related modules" section, and
designate James as a reviewer.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Maintainers.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index e38497123857..78d0d22bb8b4 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -455,16 +455,22 @@ F: OvmfPkg/PvScsiDxe/
 R: Liran Alon <liran.alon@oracle.com>
 R: Nikita Leshenko <nikita.leshchenko@oracle.com>
 
 OvmfPkg: SEV-related modules
+F: OvmfPkg/AmdSev/
 F: OvmfPkg/AmdSevDxe/
+F: OvmfPkg/Include/Guid/ConfidentialComputingSecret.h
 F: OvmfPkg/Include/Library/MemEncryptSevLib.h
 F: OvmfPkg/IoMmuDxe/AmdSevIoMmu.*
 F: OvmfPkg/Library/BaseMemEncryptSevLib/
+F: OvmfPkg/Library/PlatformBootManagerLibGrub/
 F: OvmfPkg/Library/VmgExitLib/
 F: OvmfPkg/PlatformPei/AmdSev.c
+F: OvmfPkg/ResetVector/
+F: OvmfPkg/Sec/
 R: Tom Lendacky <thomas.lendacky@amd.com>
 R: Brijesh Singh <brijesh.singh@amd.com>
+R: James Bottomley <jejb@linux.ibm.com>
 
 OvmfPkg: TCG- and TPM2-related modules
 F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
 F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
-- 
2.19.1.3.g30247aa5d201

[PATCH 2/2] Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"

[Laszlo Ersek]

The implementation of Intel TDX for OVMF has begun (TianoCore#3249).
Generalize the OVMF SEV section in "Maintainers.txt" to "Confidential
Computing". Add Jiewen Yao and Min Xu to the list of reviewers. Sort the
reviewer list alphabetically, for easier extension in the future.

After the rename, restore the alphabetical ordering between subsystem
titles in "Maintainers.txt".

TDX-related pathnames should be listed in this subsystem (with "F:"
patterns) in the future.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Maintainers.txt | 26 +++++++++++---------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 78d0d22bb8b4..fda3df5de253 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -444,19 +444,9 @@ R: Peter Grehan <grehan@freebsd.org>
 OvmfPkg: CSM modules
 F: OvmfPkg/Csm/
 R: David Woodhouse <dwmw2@infradead.org>
 
-OvmfPkg: LsiScsi driver
-F: OvmfPkg/LsiScsiDxe/
-R: Gary Lin <glin@suse.com>
-
-OvmfPkg: MptScsi and PVSCSI driver
-F: OvmfPkg/MptScsiDxe/
-F: OvmfPkg/PvScsiDxe/
-R: Liran Alon <liran.alon@oracle.com>
-R: Nikita Leshenko <nikita.leshchenko@oracle.com>
-
-OvmfPkg: SEV-related modules
+OvmfPkg: Confidential Computing
 F: OvmfPkg/AmdSev/
 F: OvmfPkg/AmdSevDxe/
 F: OvmfPkg/Include/Guid/ConfidentialComputingSecret.h
 F: OvmfPkg/Include/Library/MemEncryptSevLib.h
@@ -466,11 +456,23 @@ F: OvmfPkg/Library/PlatformBootManagerLibGrub/
 F: OvmfPkg/Library/VmgExitLib/
 F: OvmfPkg/PlatformPei/AmdSev.c
 F: OvmfPkg/ResetVector/
 F: OvmfPkg/Sec/
-R: Tom Lendacky <thomas.lendacky@amd.com>
 R: Brijesh Singh <brijesh.singh@amd.com>
 R: James Bottomley <jejb@linux.ibm.com>
+R: Jiewen Yao <jiewen.yao@intel.com>
+R: Min Xu <min.m.xu@intel.com>
+R: Tom Lendacky <thomas.lendacky@amd.com>
+
+OvmfPkg: LsiScsi driver
+F: OvmfPkg/LsiScsiDxe/
+R: Gary Lin <glin@suse.com>
+
+OvmfPkg: MptScsi and PVSCSI driver
+F: OvmfPkg/MptScsiDxe/
+F: OvmfPkg/PvScsiDxe/
+R: Liran Alon <liran.alon@oracle.com>
+R: Nikita Leshenko <nikita.leshchenko@oracle.com>
 
 OvmfPkg: TCG- and TPM2-related modules
 F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
 F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
-- 
2.19.1.3.g30247aa5d201

Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Ard Biesheuvel]

On Wed, 10 Mar 2021 at 19:57, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
>
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (2):
>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>     #3077
>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
>

For the series,

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>  Maintainers.txt | 28 +++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)
>
>
> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> --
> 2.19.1.3.g30247aa5d201
>
>
>
> 
>
>

Re: [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Philippe Mathieu-Daudé]

On 3/10/21 7:56 PM, Laszlo Ersek wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
> 
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>     #3077
>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
> 
>  Maintainers.txt | 28 +++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)

FWIW:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Re: [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Brijesh Singh]

On 3/10/21 12:56 PM, Laszlo Ersek wrote:
> Ref: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=04%7C01%7Cbrijesh.singh%40amd.com%7C69a977a229bf49dda26008d8e3f64dd3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509994311573441%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=URb6E7%2BOKlhvWMR6v%2BkeLE4I8QSjMDArQsku4vBXrJM%3D&reserved=0
> Ref: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3077&data=04%7C01%7Cbrijesh.singh%40amd.com%7C69a977a229bf49dda26008d8e3f64dd3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509994311578436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ETz9FGGrYKrDdo%2FFk6VC3t%2FE6%2F5qEiS%2Bp7tCDOxN7Gk%3D&reserved=0
> Ref: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3249&data=04%7C01%7Cbrijesh.singh%40amd.com%7C69a977a229bf49dda26008d8e3f64dd3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509994311578436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=DkTRF8W%2BPNuXcg5DLOK4esf2fjcwpy5TZnLUgeXo3kk%3D&reserved=0
>
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>

thanks


Acked-by: Brijesh Singh <brijesh.singh@amd.com>

> Thanks
> Laszlo
>
> Laszlo Ersek (2):
>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>     #3077
>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
>
>  Maintainers.txt | 28 +++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)
>
>
> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507

Re: [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Lendacky, Thomas]

On 3/10/21 12:56 PM, Laszlo Ersek wrote:
> Ref: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=04%7C01%7Cthomas.lendacky%40amd.com%7C273e70e0168942830a1108d8e3f64e49%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509994322372217%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tejxDk6%2BRgpSVUN09fbz1IED%2FmSMzl50Pq%2BEAdj%2Bl1o%3D&reserved=0
> Ref: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3077&data=04%7C01%7Cthomas.lendacky%40amd.com%7C273e70e0168942830a1108d8e3f64e49%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509994322372217%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=KLMxGVNy6ybXkV85m59b5Fg1mzNb5fS1qvuzofXzxRM%3D&reserved=0
> Ref: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3249&data=04%7C01%7Cthomas.lendacky%40amd.com%7C273e70e0168942830a1108d8e3f64e49%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509994322372217%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=od44s9nSRLrzMhACFzTyg2VCeV3BG4bTcvTsAxIR%2FpU%3D&reserved=0
> 
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>    Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>      #3077
>    Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
> 
>   Maintainers.txt | 28 +++++++++++++-------
>   1 file changed, 18 insertions(+), 10 deletions(-)

For the series:

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> 
> 
> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> 

Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Yao, Jiewen]

Both Acked-by: Jiewen Yao <jiewen.yao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Thursday, March 11, 2021 2:57 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Brijesh Singh <brijesh.singh@amd.com>; James
> Bottomley <jejb@linux.ibm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Xu, Min M
> <min.m.xu@intel.com>; Philippe Mathieu-Daudé <philmd@redhat.com>; Tom
> Lendacky <thomas.lendacky@amd.com>
> Subject: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg:
> Confidential Computing" subsystem
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
> 
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>     #3077
>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
> 
>  Maintainers.txt | 28 +++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)
> 
> 
> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> --
> 2.19.1.3.g30247aa5d201
> 
> 
> 
> 
> 

Re: [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Leif Lindholm]

If I was feeling spectacularly nitpicky, I'd grumble something about
2/2 smashing several logical changes into one. But this is a small
update to Maintainers.txt rather than code, so ... for the series.

Acked-by: Leif Lindholm <leif@nuviainc.com>

On Wed, Mar 10, 2021 at 19:56:47 +0100, Laszlo Ersek wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
> 
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>     #3077
>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
> 
>  Maintainers.txt | 28 +++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)
> 
> 
> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> -- 
> 2.19.1.3.g30247aa5d201
> 

Re: [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Laszlo Ersek]

On 03/11/21 12:33, Leif Lindholm wrote:
> If I was feeling spectacularly nitpicky, I'd grumble something about
> 2/2 smashing several logical changes into one. But this is a small
> update to Maintainers.txt rather than code, so ... for the series.
> 
> Acked-by: Leif Lindholm <leif@nuviainc.com>

Thanks -- and yes, I did consider splitting those, but the linkage
between each step is quite strong. Without TDX, I have no reason to
rename the section; once I hint at TDX, I need to add Intel reviewers; I
can't add Intel reviewers well without sorting the current "R:" list;
once I rename the section, I need to move it... Not impossible to split,
but it would have resulted in 5-6 patches, each with ~3 lines.

Thanks for accepting the patch.
Laszlo

> 
> On Wed, Mar 10, 2021 at 19:56:47 +0100, Laszlo Ersek wrote:
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
>>
>> Generalize the current OVMF SEV subsystem entry, so that we can use it
>> for Intel TDX in the future, ensuring proper patch circulation for
>> reviews.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Min Xu <min.m.xu@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (2):
>>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>>     #3077
>>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
>>
>>  Maintainers.txt | 28 +++++++++++++-------
>>  1 file changed, 18 insertions(+), 10 deletions(-)
>>
>>
>> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
>> -- 
>> 2.19.1.3.g30247aa5d201
>>
> 

Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Laszlo Ersek]

On 03/10/21 19:56, Laszlo Ersek wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
> 
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>     #3077
>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
> 
>  Maintainers.txt | 28 +++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)
> 
> 
> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> 

For merging this series, I still need ACKs from James and Min Xu, please.

Thanks
Laszlo

Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[James Bottomley]

On Thu, 2021-03-11 at 18:13 +0100, Laszlo Ersek wrote:
> On 03/10/21 19:56, Laszlo Ersek wrote:
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
> > 
> > Generalize the current OVMF SEV subsystem entry, so that we can use
> > it for Intel TDX in the future, ensuring proper patch circulation
> > for reviews.
> > 
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > 
> > Thanks
> > Laszlo
> > 
> > Laszlo Ersek (2):
> >   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198
> > and #3077
> >   Maintainers: rename the OVMF SEV subsystem to "Confidential
> > Computing"
> > 
> >  Maintainers.txt | 28 +++++++++++++-------
> >  1 file changed, 18 insertions(+), 10 deletions(-)
> > 
> > 
> > base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> > 
> 
> For merging this series, I still need ACKs from James and Min Xu,
> please.

Acked-by: James Bottomley <jejb@linux.ibm.com>

James

Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Laszlo Ersek]

(Top posting, maybe that way I'll have more luck.)

Min Xu -- it's not really trust-inspiring to not receive any feedback
(not even an out-of-office auto-response) from you, in a week, for a
Maintainers.txt patch that designates you as a reviewer for confidential
computing in OVMF. If we are to extrapolate from this responsiveness,
what should we expect for actual *patch* reviews?

Would you like me to drop your name & entry from patch#2?

Laszlo

On 03/11/21 18:13, Laszlo Ersek wrote:
> On 03/10/21 19:56, Laszlo Ersek wrote:
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
>>
>> Generalize the current OVMF SEV subsystem entry, so that we can use it
>> for Intel TDX in the future, ensuring proper patch circulation for
>> reviews.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Min Xu <min.m.xu@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (2):
>>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>>     #3077
>>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
>>
>>  Maintainers.txt | 28 +++++++++++++-------
>>  1 file changed, 18 insertions(+), 10 deletions(-)
>>
>>
>> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
>>
> 
> For merging this series, I still need ACKs from James and Min Xu, please.
> 
> Thanks
> Laszlo
> 
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Min Xu]

Acked-by: Min Xu <min.m.xu@intel.com>

Laszlo
I am so sorry to miss #2 patch review. My fault and will not repeat.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Friday, March 12, 2021 1:13 AM
> To: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
> <min.m.xu@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Andrew Fish
> <afish@apple.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Brijesh
> Singh <brijesh.singh@amd.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Leif Lindholm
> <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Philippe Mathieu-Daudé <philmd@redhat.com>; Tom Lendacky
> <thomas.lendacky@amd.com>
> Subject: Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg:
> Confidential Computing" subsystem
> 
> On 03/10/21 19:56, Laszlo Ersek wrote:
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
> >
> > Generalize the current OVMF SEV subsystem entry, so that we can use it
> > for Intel TDX in the future, ensuring proper patch circulation for
> > reviews.
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> >
> > Thanks
> > Laszlo
> >
> > Laszlo Ersek (2):
> >   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
> >     #3077
> >   Maintainers: rename the OVMF SEV subsystem to "Confidential
> Computing"
> >
> >  Maintainers.txt | 28 +++++++++++++-------
> >  1 file changed, 18 insertions(+), 10 deletions(-)
> >
> >
> > base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> >
> 
> For merging this series, I still need ACKs from James and Min Xu, please.
> 
> Thanks
> Laszlo
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH 0/2] Maintainers: create the "OvmfPkg: Confidential Computing" subsystem

[Laszlo Ersek]

On 03/10/21 19:56, Laszlo Ersek wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
> 
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for Intel TDX in the future, ensuring proper patch circulation for
> reviews.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>   Maintainers: refresh the OVMF SEV subsystem after TianoCore #2198 and
>     #3077
>   Maintainers: rename the OVMF SEV subsystem to "Confidential Computing"
> 
>  Maintainers.txt | 28 +++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)
> 
> 
> base-commit: edd46cd407ea4a0adaa8d6ca86f550c2a4d5c507
> 

Merged as commit range 9fd7e88c23f6..eb07bfb09ef5, via
<https://github.com/tianocore/edk2/pull/1506>.

Thanks
Laszlo