[edk2-staging][PATCH V1 0/5] Resolve dependency from MmUnblockMemoryLib

[edk2-staging][PATCH V1 0/5] Resolve dependency from MmUnblockMemoryLib

[Kun Qin]

The merging of commit range c5740f360636..59a3ccb09e7a on edk2 master has
separated Tcg2Smm driver into 2 functional componnents, Tcg2Acpi and Tcg2
MM driver. They also introduced dependency of MmUnblockMemoryLib on
VariableSmmRuntimeDxe as well as the new Tcg2Acpi driver.

This patch series is sent to resolve the dependency mentioned above.

Patch v1 branch: https://github.com/kuqin12/edk2-platforms/tree/unblock_dependency_v1

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>

Kun Qin (5):
  MinPlatformPkg: CoreCommonLib: Added new library for
    VariableSmmRuntimeDxe
  MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after
    separation
  QuarkPlatformPkg: Quark DSC File: Added new library for
    VariableSmmRuntimeDxe
  Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
    VariableSmmRuntimeDxe
  Socionext: DeveloperBox DSC File: Added library for
    VariableSmmRuntimeDxe

 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc           | 1 +
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc          | 1 +
 Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3 ++-
 Platform/Intel/QuarkPlatformPkg/Quark.dsc                             | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                  | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                   | 1 +
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc                      | 2 ++
 7 files changed, 9 insertions(+), 1 deletion(-)

-- 
2.30.0.windows.1

[edk2-staging][PATCH V1 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in dsc files of
CoreCommonLib to resolve newly introduced dependency. The library
interface is consumed by VariableSmmRuntimeDxe to better support variable
runtime cache feature.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index cb40e111b5dd..bcabb797e91a 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -159,6 +159,7 @@ [LibraryClasses.common]
   LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
 
   SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
   SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
-- 
2.30.0.windows.1

回复: [edk2-devel] [edk2-staging][PATCH V1 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
> 发送时间: 2021年3月11日 4:08
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>
> 主题: [edk2-devel] [edk2-staging][PATCH V1 1/5] MinPlatformPkg:
> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in dsc files of
> CoreCommonLib to resolve newly introduced dependency. The library
> interface is consumed by VariableSmmRuntimeDxe to better support variable
> runtime cache feature.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index cb40e111b5dd..bcabb797e91a 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -159,6 +159,7 @@ [LibraryClasses.common]
>    LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> 
>    SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
> +
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnbloc
> kMemoryLibNull.inf
> 
>    SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
> 
> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib
> .inf
> --
> 2.30.0.windows.1
> 
> 
> 
> 
> 

[edk2-staging][PATCH V1 2/5] MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after separation

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3251

This change follows the commit that separates the original Tcg2Smm driver
into Tcg2Acpi and Tcg2 MM based on functionality in DXE and MM. The new
Tcg2Acpi driver now will be responsible for patching and publishing ACPI
table from DXE, and Tcg2 MM driver will be handling runtime MMI requests
from ACPI calls.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc          | 1 +
 Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
index a76a9bf5fdf9..c2ade240f314 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
@@ -155,6 +155,7 @@
       NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
   }
   SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+  SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf
   SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
 !endif
 
diff --git a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
index 45dda7ea0a91..3edc878e173b 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
+++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
@@ -14,6 +14,7 @@
 !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
 INF  SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.inf
 INF  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
-INF  RuleOverride = DRIVER_ACPITABLE SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+INF  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+INF  RuleOverride = DRIVER_ACPITABLE SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf
 INF  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
 !endif
-- 
2.30.0.windows.1

回复: [edk2-devel] [edk2-staging][PATCH V1 2/5] MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after separation

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Besides, the subject should be edk2-platforms instead of edk2-staging. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
> 发送时间: 2021年3月11日 4:08
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>
> 主题: [edk2-devel] [edk2-staging][PATCH V1 2/5] MinPlatformPkg: Core
> Include Files: Added Tcg2Acpi driver after separation
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3251
> 
> This change follows the commit that separates the original Tcg2Smm driver
> into Tcg2Acpi and Tcg2 MM based on functionality in DXE and MM. The new
> Tcg2Acpi driver now will be responsible for patching and publishing ACPI
> table from DXE, and Tcg2 MM driver will be handling runtime MMI requests
> from ACPI calls.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> | 1 +
>  Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3
> ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> index a76a9bf5fdf9..c2ade240f314 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> @@ -155,6 +155,7 @@
> 
> NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.i
> nf
>    }
>    SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
> +  SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf
>    SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
>  !endif
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> index 45dda7ea0a91..3edc878e173b 100644
> ---
a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> +++
> b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> @@ -14,6 +14,7 @@
>  !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
>  INF  SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.inf
>  INF  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
> -INF  RuleOverride = DRIVER_ACPITABLE
> SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
> +INF  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
> +INF  RuleOverride = DRIVER_ACPITABLE
> SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf
>  INF  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
>  !endif
> --
> 2.30.0.windows.1
> 
> 
> 
> 
> 

Re: [edk2-devel] 回复: [edk2-devel] [edk2-staging][PATCH V1 2/5] MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after separation

[kuqin12]

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

Thanks, Liming. Will use [edk2-platform] next time contributing to this repo.

Regards,
Kun

[-- Attachment #2: Type: text/html, Size: 114 bytes --]

[edk2-staging][PATCH V1 3/5] QuarkPlatformPkg: Quark DSC File: Added new library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in Quark.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
feature.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---
 Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
index e29c7465b1e4..c58da58348e3 100644
--- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
@@ -146,6 +146,7 @@ [LibraryClasses]
   ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
-- 
2.30.0.windows.1

Re: [edk2-staging][PATCH V1 3/5] QuarkPlatformPkg: Quark DSC File: Added new library for VariableSmmRuntimeDxe

[Steele, Kelly]

Reviewed-by: Kelly Steele <kelly.steele@intel.com>

> -----Original Message-----
> From: Kun Qin <kuqin12@gmail.com>
> Sent: Wednesday, March 10, 2021 12:08 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>
> Subject: [edk2-staging][PATCH V1 3/5] QuarkPlatformPkg: Quark DSC File:
> Added new library for VariableSmmRuntimeDxe
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in Quark.dsc to
> resolve new dependency by VariableSmmRuntimeDxe. The library interface
> is consumed by variable module to better support variable runtime cache
> feature.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> index e29c7465b1e4..c58da58348e3 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> @@ -146,6 +146,7 @@ [LibraryClasses]
> 
> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/Dx
> eReportStatusCodeLib.inf
> 
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeE
> xtractGuidedSectionLib.inf
> 
> LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.in
> f
> +
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> ckMemoryLibNull.inf
>    VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> 
> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLi
> b.inf
> 
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> --
> 2.30.0.windows.1

[edk2-staging][PATCH V1 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
file to resolve new dependency by VariableSmmRuntimeDxe. The library
interface is consumed by variable module to better support variable
runtime cache feature.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 409f31c982d7..33e93b74800c 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -311,6 +311,7 @@ [LibraryClasses.IA32]
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
   EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
   HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
 [LibraryClasses.IA32.DXE_DRIVER]
   DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 38bd825c8bdc..f7a876353649 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -313,6 +313,7 @@ [LibraryClasses.X64]
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
   EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
   HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
 [LibraryClasses.X64.DXE_DRIVER]
   DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
-- 
2.30.0.windows.1

Re: [edk2-staging][PATCH V1 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[kuqin12]

Hi Zailiang/Yi,

Could you please help review the patch below? Any input is appreciated.

Thanks,
Kun

On 03/10/2021 12:07, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
> file to resolve new dependency by VariableSmmRuntimeDxe. The library
> interface is consumed by variable module to better support variable
> runtime cache feature.
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 409f31c982d7..33e93b74800c 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>   
>   [LibraryClasses.IA32.DXE_DRIVER]
>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 38bd825c8bdc..f7a876353649 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>   
>   [LibraryClasses.X64.DXE_DRIVER]
>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> 

[edk2-staging][PATCH V1 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
feature.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 0a11b796cca5..acaa4cd90fc5 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -49,6 +49,8 @@ [LibraryClasses]
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
 !endif
 
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
+
 [LibraryClasses.common.SEC]
   PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
-- 
2.30.0.windows.1

Re: [edk2-staging][PATCH V1 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[Kun Qin]

Hi Ard/Leif,

Could you please help review the patch when you have a chance? Thanks in 
advance.

Regards,
Kun

On 03/10/2021 12:07, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
> resolve new dependency by VariableSmmRuntimeDxe. The library interface
> is consumed by variable module to better support variable runtime cache
> feature.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>   Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> index 0a11b796cca5..acaa4cd90fc5 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> @@ -49,6 +49,8 @@ [LibraryClasses]
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>   !endif
>   
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> +
>   [LibraryClasses.common.SEC]
>     PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> 

Re: [edk2-devel] [edk2-staging][PATCH V1 0/5] Resolve dependency from MmUnblockMemoryLib

[Thomas Abraham]

On 3/11/21 1:37 AM, Kun Qin via groups.io wrote: 
> The merging of commit range c5740f360636..59a3ccb09e7a on edk2 master has
> separated Tcg2Smm driver into 2 functional componnents, Tcg2Acpi and Tcg2
> MM driver. They also introduced dependency of MmUnblockMemoryLib on
> VariableSmmRuntimeDxe as well as the new Tcg2Acpi driver.
> 
> This patch series is sent to resolve the dependency mentioned above.
> 
> Patch v1 branch: https://github.com/kuqin12/edk2-
> platforms/tree/unblock_dependency_v1
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> 
> Kun Qin (5):
>   MinPlatformPkg: CoreCommonLib: Added new library for
>     VariableSmmRuntimeDxe
>   MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after
>     separation
>   QuarkPlatformPkg: Quark DSC File: Added new library for
>     VariableSmmRuntimeDxe
>   Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
>     VariableSmmRuntimeDxe
>   Socionext: DeveloperBox DSC File: Added library for
>     VariableSmmRuntimeDxe
> 
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc           | 1 +
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc          | 1 +
>  Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3 ++-
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                             | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                  | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                   | 1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                      | 2 ++
>  7 files changed, 9 insertions(+), 1 deletion(-)

Can this series be extended to resolve the dependency in Platform/Arm/SgiPkg as well? The change being applied in this patch series was tested with SgiPkg it does resolve the dependency.

Thanks,
Thomas.

Re: [edk2-devel] [edk2-staging][PATCH V1 0/5] Resolve dependency from MmUnblockMemoryLib

[Thomas Abraham]

Hi Kun,

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Thomas
> Abraham via groups.io
> Sent: Thursday, March 11, 2021 11:39 AM
> To: devel@edk2.groups.io; kuqin12@gmail.com
> Cc: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Kelly Steele <kelly.steele@intel.com>; Zailiang
> Sun <zailiang.sun@intel.com>; Yi Qian <yi.qian@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>; nd
> <nd@arm.com>
> Subject: Re: [edk2-devel] [edk2-staging][PATCH V1 0/5] Resolve dependency
> from MmUnblockMemoryLib
> 
> On 3/11/21 1:37 AM, Kun Qin via groups.io wrote:
> > The merging of commit range c5740f360636..59a3ccb09e7a on edk2 master
> has
> > separated Tcg2Smm driver into 2 functional componnents, Tcg2Acpi and Tcg2
> > MM driver. They also introduced dependency of MmUnblockMemoryLib on
> > VariableSmmRuntimeDxe as well as the new Tcg2Acpi driver.
> >
> > This patch series is sent to resolve the dependency mentioned above.
> >
> > Patch v1 branch: https://github.com/kuqin12/edk2-
> > platforms/tree/unblock_dependency_v1
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Kelly Steele <kelly.steele@intel.com>
> > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > Cc: Yi Qian <yi.qian@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> >
> > Kun Qin (5):
> >   MinPlatformPkg: CoreCommonLib: Added new library for
> >     VariableSmmRuntimeDxe
> >   MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after
> >     separation
> >   QuarkPlatformPkg: Quark DSC File: Added new library for
> >     VariableSmmRuntimeDxe
> >   Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
> >     VariableSmmRuntimeDxe
> >   Socionext: DeveloperBox DSC File: Added library for
> >     VariableSmmRuntimeDxe
> >
> >  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc           | 1 +
> >  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc          | 1 +
> >  Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3
> ++-
> >  Platform/Intel/QuarkPlatformPkg/Quark.dsc                             | 1 +
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                  | 1 +
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                   | 1 +
> >  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                      | 2 ++
> >  7 files changed, 9 insertions(+), 1 deletion(-)
> 
> Can this series be extended to resolve the dependency in Platform/Arm/SgiPkg
> as well? The change being applied in this patch series was tested with SgiPkg it
> does resolve the dependency.

This patch series need not be extended for Platform/Arm/SgiPkg. Sorry for the noise.

Thanks,
Thomas.