[PATCH v1 0/2] ArmNameSpaceObjects.h checkup

[PATCH v1 0/2] ArmNameSpaceObjects.h checkup

[PierreGondois]

From: Pierre Gondois <Pierre.Gondois@arm.com>

Correct some minor ordering/comments issues in ArmNameSpaceObjects.h.

The changes can be seen at: https://github.com/PierreARM/edk2/tree/1685_CheckUpArmNameSpaceObjects_v1

Pierre Gondois (2):
  DynamicTablesPkg: Re-order GicItsIdentifierArray struct
  DynamicTablesPkg: Remove EArmObjExtendedInterruptInfo

 .../Include/ArmNameSpaceObjects.h             | 24 +++++++++----------
 1 file changed, 11 insertions(+), 13 deletions(-)

--
2.17.1

[PATCH v1 1/2] DynamicTablesPkg: Re-order GicItsIdentifierArray struct

[PierreGondois]

From: Pierre Gondois <Pierre.Gondois@arm.com>

The structure is not correctly placed in the file. Move it
so it follows the EARM_OBJECT_ID enum order.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1685_CheckUpArmNameSpaceObjects_v1

 .../Include/ArmNameSpaceObjects.h             | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
index f0654866444e..bc463d19879d 100644
--- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
+++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
@@ -1,6 +1,6 @@
 /** @file
 
-  Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.<BR>
+  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -465,16 +465,6 @@ typedef struct CmArmItsGroupNode {
   CM_OBJECT_TOKEN   ItsIdToken;
 } CM_ARM_ITS_GROUP_NODE;
 
-/** A structure that describes the
-    GIC ITS Identifiers for an ITS Group node.
-
-    ID: EArmObjGicItsIdentifierArray
-*/
-typedef struct CmArmGicItsIdentifier {
-  /// The ITS Identifier
-  UINT32  ItsId;
-} CM_ARM_ITS_IDENTIFIER;
-
 /** A structure that describes the
     Named component node for the Platform.
 
@@ -636,6 +626,16 @@ typedef struct CmArmPmcgNode {
   CM_OBJECT_TOKEN   ReferenceToken;
 } CM_ARM_PMCG_NODE;
 
+/** A structure that describes the
+    GIC ITS Identifiers for an ITS Group node.
+
+    ID: EArmObjGicItsIdentifierArray
+*/
+typedef struct CmArmGicItsIdentifier {
+  /// The ITS Identifier
+  UINT32  ItsId;
+} CM_ARM_ITS_IDENTIFIER;
+
 /** A structure that describes the
     ID Mappings for the Platform.
 
-- 
2.17.1

[PATCH v1 2/2] DynamicTablesPkg: Remove EArmObjExtendedInterruptInfo

[PierreGondois]

From: Pierre Gondois <Pierre.Gondois@arm.com>

The EArmObjExtendedInterruptInfo doesn't exist. Remove any reference
to this enum.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1685_CheckUpArmNameSpaceObjects_v1

 DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
index bc463d19879d..afcfe3704cb9 100644
--- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
+++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
@@ -681,8 +681,6 @@ typedef CM_ARM_GENERIC_INTERRUPT CM_ARM_SMMU_INTERRUPT;
                 Vector Flags (Byte 3) of the Extended Interrupt
                 resource descriptor.
                 See EFI_ACPI_EXTENDED_INTERRUPT_FLAG_xxx in Acpi10.h
-
-    ID: EArmObjExtendedInterruptInfo
 */
 typedef CM_ARM_GENERIC_INTERRUPT CM_ARM_EXTENDED_INTERRUPT;
 
-- 
2.17.1

Re: [edk2-devel] [PATCH v1 0/2] ArmNameSpaceObjects.h checkup

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 124 bytes --]

Hi Pierre,

Thank you for these patches.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 162 bytes --]

Re: [edk2-devel] [PATCH v1 0/2] ArmNameSpaceObjects.h checkup

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]

Pushed as 71cdb91f3133..83876950ab3c

Thanks.

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 101 bytes --]