* [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
@ 2021-03-16 14:53 Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 01/35] Drivers/ASIX: " Dandan Bi
` (35 more replies)
0 siblings, 36 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:53 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Michael D Kinney, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
RFC: https://edk2.groups.io/g/devel/message/72530
Add RegisterFilterLibNull in dsc files in edk2-platforms repo,
which will be consumed by IoLib and BaseLib.
This is the following update in edk2-platforms repo for the change in edk2,
which will add RegisterFilterLib dependency for IoLib and BaseLib to filter/trace
port IO/MMIO/MSR access.
https://edk2.groups.io/g/devel/message/72754
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Dandan Bi (35):
Drivers/ASIX: Consume RegisterFilterLibNull instance
Drivers/DisplayLink: Consume RegisterFilterLibNull instance
Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
Features/Debugging: Consume RegisterFilterLibNull instance
Features/Network: Consume RegisterFilterLibNull instance
Features/OutOfBandManagement: Consume RegisterFilterLibNull instance
Features/PowerManagement: Consume RegisterFilterLibNull instance
Features/SystemInformation: Consume RegisterFilterLibNull instance
Features/UserInterface: Consume RegisterFilterLibNull instance
Platform/AMD: Consume RegisterFilterLibNull instance
Platform/ARM: Consume RegisterFilterLibNull instance
Platform/BeagleBoard: Consume RegisterFilterLibNull instance
Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
Platform/LeMaker: Consume RegisterFilterLibNull instance
Platform/Qemu: Consume RegisterFilterLibNull instance
Platform/RaspberryPi: Consume RegisterFilterLibNull instance
Platform/RISC-V: Consume RegisterFilterLibNull instance
Platform/SiFive: Consume RegisterFilterLibNull instance
Platform/Socionext: Consume RegisterFilterLibNull instance
Platform/SoftIron: Consume RegisterFilterLibNull instance
Silicon/Hisilicon: Consume RegisterFilterLibNull instance
Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
Silicon/Marvell: Consume RegisterFilterLibNull instance
Silicon/NXP: Consume RegisterFilterLibNull instance
Silicon/Openmoko: Consume RegisterFilterLibNull instance
Silicon/RISC_V: Consume RegisterFilterLibNull instance
Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
Drivers/ASIX/Asix.dsc | 1 +
Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 +
Drivers/OptionRomPkg/OptionRomPkg.dsc | 3 ++-
.../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3 ++-
.../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc | 3 ++-
.../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3 ++-
.../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc | 3 ++-
.../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3 ++-
.../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3 ++-
.../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc | 3 ++-
.../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3 ++-
.../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3 ++-
.../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
.../UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3 ++-
.../Include/VirtualKeyboardFeature.dsc | 3 ++-
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 1 +
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++-
Platform/Intel/BoardModulePkg/BoardModulePkg.dsc | 3 ++-
Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3 ++-
Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 ++-
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 ++-
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1 +
Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
Platform/RaspberryPi/RPi4/RPi4.dsc | 3 ++-
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 +
.../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++-
Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++-
Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 ++-
Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
Silicon/Openmoko/Openmoko.dsc | 1 +
Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
Silicon/Synopsys/DesignWare/DesignWare.dsc | 1 +
Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc | 1 +
47 files changed, 70 insertions(+), 23 deletions(-)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 01/35] Drivers/ASIX: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
@ 2021-03-16 14:53 ` Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 02/35] Drivers/DisplayLink: " Dandan Bi
` (34 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:53 UTC (permalink / raw)
To: devel; +Cc: Samer El-Haj-Mahmoud, Ray Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Drivers/ASIX/Asix.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Drivers/ASIX/Asix.dsc b/Drivers/ASIX/Asix.dsc
index 5e02e11760..4a9f8897b0 100644
--- a/Drivers/ASIX/Asix.dsc
+++ b/Drivers/ASIX/Asix.dsc
@@ -40,10 +40,11 @@ [LibraryClasses]
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.AARCH64, LibraryClasses.ARM]
NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
[LibraryClasses.ARM]
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 02/35] Drivers/DisplayLink: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 01/35] Drivers/ASIX: " Dandan Bi
@ 2021-03-16 14:53 ` Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 03/35] Drivers/OptionRomPkg: " Dandan Bi
` (33 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:53 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Andy Hayes
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Andy Hayes <andy.hayes@displaylink.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc
index 955331ba60..23a9feb175 100644
--- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc
+++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc
@@ -28,10 +28,11 @@ [LibraryClasses]
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.UEFI_DRIVER]
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
[LibraryClasses.AARCH64]
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 03/35] Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 01/35] Drivers/ASIX: " Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 02/35] Drivers/DisplayLink: " Dandan Bi
@ 2021-03-16 14:53 ` Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 04/35] Features/Debugging: " Dandan Bi
` (32 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:53 UTC (permalink / raw)
To: devel; +Cc: Ray Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Drivers/OptionRomPkg/OptionRomPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Drivers/OptionRomPkg/OptionRomPkg.dsc b/Drivers/OptionRomPkg/OptionRomPkg.dsc
index 8a13cc54e6..5c3aed6408 100644
--- a/Drivers/OptionRomPkg/OptionRomPkg.dsc
+++ b/Drivers/OptionRomPkg/OptionRomPkg.dsc
@@ -4,11 +4,11 @@
# This package is designed to interoperate with the EDK II open source project
# at http://www.tianocore.org, and this package is required to build PCI compliant
# Option ROM image for all CPU architectures, including EBC target.
# A single driver can support mixes of EFI 1.1, UEFI 2.0 and UEFI 2.1.
#
-# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
# Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
# Copyright (c) 2020, ARM Limited. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -53,10 +53,11 @@ [LibraryClasses]
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.AARCH64, LibraryClasses.ARM]
NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
[LibraryClasses.ARM]
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 04/35] Features/Debugging: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (2 preceding siblings ...)
2021-03-16 14:53 ` [edk2-platforms] [patch 03/35] Drivers/OptionRomPkg: " Dandan Bi
@ 2021-03-16 14:53 ` Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 05/35] Features/Network: " Dandan Bi
` (31 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:53 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3 ++-
.../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc | 3 ++-
.../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3 ++-
.../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc | 3 ++-
4 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc
index 3e6b1f69c2..ab269dd8df 100644
--- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc
+++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -43,10 +43,11 @@ [LibraryClasses]
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.DXE_RUNTIME_DRIVER]
#######################################
# Edk2 Packages
#######################################
diff --git a/Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc b/Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc
index 65e00b5979..e6e480b734 100644
--- a/Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc
+++ b/Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -57,10 +57,11 @@ [LibraryClasses]
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEIM]
#######################################
# Edk2 Packages
#######################################
diff --git a/Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc b/Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc
index 2852b9cf7c..539c74c84d 100644
--- a/Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc
+++ b/Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -56,10 +56,11 @@ [LibraryClasses]
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEIM]
#######################################
# Edk2 Packages
#######################################
diff --git a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc
index 95adb01a74..7b1e41d999 100644
--- a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc
+++ b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -46,10 +46,11 @@ [LibraryClasses]
TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEIM]
#######################################
# Edk2 Packages
#######################################
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 05/35] Features/Network: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (3 preceding siblings ...)
2021-03-16 14:53 ` [edk2-platforms] [patch 04/35] Features/Debugging: " Dandan Bi
@ 2021-03-16 14:53 ` Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 06/35] Features/OutOfBandManagement: " Dandan Bi
` (30 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:53 UTC (permalink / raw)
To: devel; +Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc b/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc
index c59c21ee6c..36cf817d91 100644
--- a/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc
+++ b/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -68,10 +68,11 @@ [LibraryClasses]
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.SEC,LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
#######################################
# Edk2 Packages
#######################################
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 06/35] Features/OutOfBandManagement: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (4 preceding siblings ...)
2021-03-16 14:53 ` [edk2-platforms] [patch 05/35] Features/Network: " Dandan Bi
@ 2021-03-16 14:53 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 07/35] Features/PowerManagement: " Dandan Bi
` (29 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:53 UTC (permalink / raw)
To: devel; +Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3 ++-
.../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
index a82f18a68c..f27dfbfd3c 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -38,10 +38,11 @@ [LibraryClasses]
BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#####################################
# IPMI Feature Package
#####################################
IpmiCommandLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc
index 89ef648f31..14d840143e 100644
--- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc
+++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -42,10 +42,11 @@ [LibraryClasses]
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#######################################
# SpcrFeaturePkg Packages
#######################################
SpcrDeviceLib|SpcrFeaturePkg/Library/SpcrDeviceLibNull/SpcrDeviceLibNull.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 07/35] Features/PowerManagement: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (5 preceding siblings ...)
2021-03-16 14:53 ` [edk2-platforms] [patch 06/35] Features/OutOfBandManagement: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 08/35] Features/SystemInformation: " Dandan Bi
` (28 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
index 647dc3f93a..5140eb522a 100644
--- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
+++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -39,10 +39,11 @@ [LibraryClasses]
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf
PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
#######################################
# Edk2 Packages
#######################################
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 08/35] Features/SystemInformation: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (6 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 07/35] Features/PowerManagement: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 09/35] Features/UserInterface: " Dandan Bi
` (27 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc
index a59fdf3702..d037b4c078 100644
--- a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc
+++ b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -41,10 +41,11 @@ [LibraryClasses]
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.DXE_DRIVER]
#######################################
# Edk2 Packages
#######################################
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 09/35] Features/UserInterface: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (7 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 08/35] Features/SystemInformation: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 10/35] Platform/AMD: " Dandan Bi
` (26 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
.../UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3 ++-
.../Include/VirtualKeyboardFeature.dsc | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
index d2dcdeb36a..c3f359137e 100644
--- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
+++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -37,10 +37,11 @@ [LibraryClasses]
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.DXE_DRIVER]
#######################################
# Edk2 Packages
#######################################
diff --git a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc
index 7d784f4dff..3b84798bc1 100644
--- a/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc
+++ b/Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -49,10 +49,11 @@ [LibraryClasses]
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#####################################
# User Authentication Feature Package
#####################################
PlatformPasswordLib|UserInterface/UserAuthFeaturePkg/Library/PlatformPasswordLibNull/PlatformPasswordLibNull.inf
diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyboardFeature.dsc b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyboardFeature.dsc
index c10fb2d567..d6d492556d 100644
--- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyboardFeature.dsc
+++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyboardFeature.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -44,10 +44,11 @@ [LibraryClasses]
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.UEFI_DRIVER]
#######################################
# Edk2 Packages
#######################################
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 10/35] Platform/AMD: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (8 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 09/35] Features/UserInterface: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 11/35] Platform/ARM: " Dandan Bi
` (25 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 05d1b69c83..8dd1378b86 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -47,10 +47,11 @@ [LibraryClasses.common]
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 11/35] Platform/ARM: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (9 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 10/35] Platform/AMD: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 12/35] Platform/BeagleBoard: " Dandan Bi
` (24 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Thomas Abraham, Sami Mujawar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 1 +
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
index 38bf6020ba..01539e8916 100644
--- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
+++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
@@ -45,10 +45,11 @@ [LibraryClasses]
MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# Entry point
#
StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index fee7cfcc2d..3f0556e2b8 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -43,10 +43,11 @@ [LibraryClasses.common]
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 12/35] Platform/BeagleBoard: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (10 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 11/35] Platform/ARM: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 13/35] Platform/BoardModulePkg: " Dandan Bi
` (23 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
index c5fc978c5f..98b47948f2 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -1,10 +1,10 @@
#/** @file
# Beagle board package.
#
# Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
-# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.<BR>
# Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
#**/
@@ -46,10 +46,11 @@ [LibraryClasses.common]
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
ResetSystemLib|Platform/BeagleBoard/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.inf
PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 13/35] Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (11 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 12/35] Platform/BeagleBoard: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 14/35] Platform/MinPlatformPkg: " Dandan Bi
` (22 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/Intel/BoardModulePkg/BoardModulePkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dsc b/Platform/Intel/BoardModulePkg/BoardModulePkg.dsc
index bcc2dfbfeb..b7c3d153cf 100644
--- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dsc
+++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dsc
@@ -4,11 +4,11 @@
#
# The DEC files are used by the utilities that parse DSC and
# INF files to generate AutoGen.c and AutoGen.h files
# for the build infrastructure.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -34,10 +34,11 @@ [LibraryClasses]
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEIM]
FirmwareBootMediaLib|IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/PeiFirmwareBootMediaLib.inf
FirmwareBootMediaInfoLib|BoardModulePkg/Library/PeiFirmwareBootMediaInfoLib/PeiFirmwareBootMediaInfoLib.inf
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 14/35] Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (12 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 13/35] Platform/BoardModulePkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: " Dandan Bi
` (21 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index cb40e111b5..bafd814009 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -1,9 +1,9 @@
## @file
# Platform description.
#
-# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -40,10 +40,11 @@ [LibraryClasses.common]
PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (13 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 14/35] Platform/MinPlatformPkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 15:04 ` Steele, Kelly
2021-03-16 14:54 ` [edk2-platforms] [patch 16/35] Platform/Vlv2TbltDevicePkg: " Dandan Bi
` (20 subsequent siblings)
35 siblings, 1 reply; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Kelly Steele
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
index e29c7465b1..632f8a44f1 100644
--- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
@@ -101,10 +101,11 @@ [LibraryClasses]
PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
!endif
DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
index 6fdfba9a58..83909c6357 100644
--- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
@@ -89,10 +89,11 @@ [LibraryClasses]
PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
!endif
DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 16/35] Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (14 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 17/35] Platform/LeMaker: " Dandan Bi
` (19 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Zailiang Sun, Yi Qian
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 ++-
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 409f31c982..ac83f72e88 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -1,9 +1,9 @@
#/** @file
# Platform description.
#
-# Copyright (c) 2012 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2012 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
#
#**/
@@ -93,10 +93,11 @@ [LibraryClasses.common]
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
!if $(RC_BINARY_RELEASE) == TRUE
PchPlatformLib|Vlv2TbltDevicePkg/Library/PchPlatformLib/PchPlatformLib.inf
!endif
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 38bd825c8b..6bbb38cec5 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -1,9 +1,9 @@
#/** @file
# Platform description.
#
-# Copyright (c) 2012 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2012 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
#
#**/
@@ -95,10 +95,11 @@ [LibraryClasses.common]
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
!if $(RC_BINARY_RELEASE) == TRUE
PchPlatformLib|Vlv2TbltDevicePkg/Library/PchPlatformLib/PchPlatformLib.inf
!endif
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 17/35] Platform/LeMaker: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (15 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 16/35] Platform/Vlv2TbltDevicePkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 18/35] Platform/Qemu: " Dandan Bi
` (18 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 26bbbb2497..9d802e83b3 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -53,10 +53,11 @@ [LibraryClasses.common]
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 18/35] Platform/Qemu: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (16 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 17/35] Platform/LeMaker: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 19/35] Platform/RaspberryPi: " Dandan Bi
` (17 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Graeme Gregory, Radoslaw Biernacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index c1f8a46965..34e89b9ad6 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -58,10 +58,11 @@ [LibraryClasses.common]
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|ArmVirtPkg/Library/ArmVirtDxeHobLib/ArmVirtDxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 19/35] Platform/RaspberryPi: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (17 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 18/35] Platform/Qemu: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 20/35] Platform/RISC-V: " Dandan Bi
` (16 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Pete Batard
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
Platform/RaspberryPi/RPi4/RPi4.dsc | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 107cbda297..84c4648a42 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -1,10 +1,10 @@
# @file
#
# Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
# Copyright (c) 2014, Linaro Limited. All rights reserved.
-# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
# Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -72,10 +72,11 @@ [LibraryClasses.common]
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index e0fad6f744..23ec283d01 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -1,10 +1,10 @@
# @file
#
# Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
# Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
-# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
# Copyright (c) 2014, Linaro Limited. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -70,10 +70,11 @@ [LibraryClasses.common]
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 20/35] Platform/RISC-V: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (18 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 19/35] Platform/RaspberryPi: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-17 8:14 ` Abner Chang
2021-03-16 14:54 ` [edk2-platforms] [patch 21/35] Platform/SiFive: " Dandan Bi
` (15 subsequent siblings)
35 siblings, 1 reply; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Daniel Schaefer, Gilbert Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
index 092717d2ef..961e1234e9 100644
--- a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
+++ b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
@@ -53,10 +53,11 @@ [LibraryClasses.common]
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEIM]
FirmwareContextProcessorSpecificLib|Platform/RISC-V/PlatformPkg/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.inf
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 21/35] Platform/SiFive: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (19 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 20/35] Platform/RISC-V: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-17 8:14 ` Abner Chang
2021-03-16 14:54 ` [edk2-platforms] [patch 22/35] Platform/Socionext: " Dandan Bi
` (14 subsequent siblings)
35 siblings, 1 reply; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Daniel Schaefer, Gilbert Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 +
.../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
index 2d652d215f..9610f0613a 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
@@ -94,10 +94,11 @@ [LibraryClasses]
UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
# RISC-V Platform Library
TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
RealTimeClockLib|EmbeddedPkg//Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
index 9f60475189..b3d4427a8a 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
@@ -94,10 +94,11 @@ [LibraryClasses]
UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
# RISC-V Platform Library
TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
RealTimeClockLib|EmbeddedPkg//Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 22/35] Platform/Socionext: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (20 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 21/35] Platform/SiFive: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 23/35] Platform/SoftIron: " Dandan Bi
` (13 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
index 0a364bc457..fa54b571f8 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
@@ -63,10 +63,11 @@ [LibraryClasses]
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
index 18accbfd5d..b8674c84c1 100644
--- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
+++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
@@ -82,10 +82,11 @@ [LibraryClasses.common]
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 23/35] Platform/SoftIron: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (21 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 22/35] Platform/Socionext: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 24/35] Silicon/Hisilicon: " Dandan Bi
` (12 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index dd45b4142c..7750e65eb6 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -54,10 +54,11 @@ [LibraryClasses.common]
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 24/35] Silicon/Hisilicon: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (22 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 23/35] Platform/SoftIron: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 25/35] Silicon/CoffeelakeSiliconPkg: " Dandan Bi
` (11 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Wenyi Xie
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index 6bacd9cafd..51591b15d9 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -24,10 +24,11 @@ [LibraryClasses.common]
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 25/35] Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (23 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 24/35] Silicon/Hisilicon: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 26/35] Silicon/IntelSiliconPkg: " Dandan Bi
` (10 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Sai Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
index 2f25bdb35e..18369afce1 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
@@ -103,10 +103,11 @@ [LibraryClasses.common]
PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 26/35] Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (24 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 25/35] Silicon/CoffeelakeSiliconPkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 27/35] Silicon/KabylakeSiliconPkg: " Dandan Bi
` (9 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Rangasai V Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc
index 6dff68f681..ea6477ec53 100644
--- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc
+++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc
@@ -1,9 +1,9 @@
## @file
# This package provides common open source Intel silicon modules.
#
-# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
# Copyright (c) Microsoft Corporation.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -35,10 +35,11 @@ [LibraryClasses]
SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
MicrocodeFlashAccessLib|IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf
PeiGetVtdPmrAlignmentLib|IntelSiliconPkg/Library/PeiGetVtdPmrAlignmentLib/PeiGetVtdPmrAlignmentLib.inf
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEIM]
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 27/35] Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (25 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 26/35] Silicon/IntelSiliconPkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: " Dandan Bi
` (8 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Sai Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
index aa481d0307..972a882613 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
+++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
@@ -1,9 +1,9 @@
## @file
# Component description file for the SkyLake SiPkg DSC file.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -94,10 +94,11 @@ [LibraryClasses.common]
PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (26 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 27/35] Silicon/KabylakeSiliconPkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 15:05 ` Steele, Kelly
2021-03-16 14:54 ` [edk2-platforms] [patch 29/35] Silicon/TigerlakeSiliconPkg: " Dandan Bi
` (7 subsequent siblings)
35 siblings, 1 reply; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Kelly Steele
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc b/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
index e743a5e272..5b9679f32f 100644
--- a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
+++ b/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
@@ -2,11 +2,11 @@
# INTEL Quark SoC Module Package Reference Implementations
#
# This DSC file is used for Package Level build.
#
# This Module provides FRAMEWORK reference implementation for INTEL Quark SoC.
-# Copyright (c) 2013-2016 Intel Corporation.
+# Copyright (c) 2013-2021 Intel Corporation.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -62,10 +62,11 @@ [LibraryClasses]
!if $(CFG_SOURCE_DEBUG) == 1
PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLibDebug.inf
!else
PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
!endif
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 29/35] Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (27 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 30/35] Silicon/Marvell: " Dandan Bi
` (6 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Sai Chaganty, Nate DeSimone, Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc b/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc
index 73a2594887..b787b00048 100644
--- a/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc
+++ b/Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc
@@ -117,10 +117,11 @@ [LibraryClasses.common]
CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
#
# UEFI & PI
#
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 30/35] Silicon/Marvell: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (28 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 29/35] Silicon/TigerlakeSiliconPkg: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 31/35] Silicon/NXP: " Dandan Bi
` (5 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Marcin Wojtas, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 4cdafe8b1f..ccb45a2adb 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -50,10 +50,11 @@ [LibraryClasses.common]
CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf
PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
PciHostBridgeLib|Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf
PciSegmentLib|Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciSegmentLib/PciSegmentLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
# Basic UEFI services libraries
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 31/35] Silicon/NXP: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (29 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 30/35] Silicon/Marvell: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 32/35] Silicon/Openmoko: " Dandan Bi
` (4 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Meenakshi Aggarwal
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
index 99a317aba7..7c66a88bc6 100644
--- a/Silicon/NXP/NxpQoriqLs.dsc.inc
+++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
@@ -95,10 +95,11 @@ [LibraryClasses.common]
NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
I2cLib|Silicon/NXP/Library/I2cLib/I2cLib.inf
ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 32/35] Silicon/Openmoko: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (30 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 31/35] Silicon/NXP: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 33/35] Silicon/RISC_V: " Dandan Bi
` (3 subsequent siblings)
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Openmoko/Openmoko.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Openmoko/Openmoko.dsc b/Silicon/Openmoko/Openmoko.dsc
index 572be3d730..fbe46e7ff3 100644
--- a/Silicon/Openmoko/Openmoko.dsc
+++ b/Silicon/Openmoko/Openmoko.dsc
@@ -26,10 +26,11 @@ [LibraryClasses]
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.ARM]
NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
[Components]
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 33/35] Silicon/RISC_V: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (31 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 32/35] Silicon/Openmoko: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-17 8:14 ` Abner Chang
2021-03-16 14:54 ` [edk2-platforms] [patch 34/35] Silicon/Synopsys/DesignWare: " Dandan Bi
` (2 subsequent siblings)
35 siblings, 1 reply; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Daniel Schaefer, Gilbert Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc b/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
index 5f88f5e89f..da4083c81e 100644
--- a/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
+++ b/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
@@ -62,10 +62,11 @@ [LibraryClasses.common]
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
RiscVPlatformTimerLib|Silicon/RISC-V/ProcessorPkg/Library/RiscVPlatformTimerLibNull/RiscVPlatformTimerLib.inf
PeiServicesTablePointerLib|Silicon/RISC-V/ProcessorPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTablePointerLibOpenSbi.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[LibraryClasses.common.PEI_CORE]
PeiServicesTablePointerLib|Silicon/RISC-V/ProcessorPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTablePointerLibOpenSbi.inf
[LibraryClasses.common.PEIM]
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 34/35] Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (32 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 33/35] Silicon/RISC_V: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 35/35] Silicon/TexasInstruments: " Dandan Bi
2021-03-16 15:00 ` [edk2-devel] [edk2-platforms] [patch 00/35] " Ard Biesheuvel
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/Synopsys/DesignWare/DesignWare.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Synopsys/DesignWare/DesignWare.dsc b/Silicon/Synopsys/DesignWare/DesignWare.dsc
index 098bba3f7d..2be1d81986 100755
--- a/Silicon/Synopsys/DesignWare/DesignWare.dsc
+++ b/Silicon/Synopsys/DesignWare/DesignWare.dsc
@@ -35,9 +35,10 @@ [LibraryClasses]
TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
[Components]
Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/DwEmacSnpDxe.inf
Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [edk2-platforms] [patch 35/35] Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (33 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 34/35] Silicon/Synopsys/DesignWare: " Dandan Bi
@ 2021-03-16 14:54 ` Dandan Bi
2021-03-16 15:00 ` [edk2-devel] [edk2-platforms] [patch 00/35] " Ard Biesheuvel
35 siblings, 0 replies; 50+ messages in thread
From: Dandan Bi @ 2021-03-16 14:54 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc b/Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
index 18ebc4aedf..895b79dacb 100644
--- a/Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
+++ b/Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
@@ -29,10 +29,11 @@ [LibraryClasses.common]
ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+ RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
DefaultExceptioHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 50+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
` (34 preceding siblings ...)
2021-03-16 14:54 ` [edk2-platforms] [patch 35/35] Silicon/TexasInstruments: " Dandan Bi
@ 2021-03-16 15:00 ` Ard Biesheuvel
2021-03-16 16:23 ` Laszlo Ersek
2021-03-17 3:04 ` 回复: " gaoliming
35 siblings, 2 replies; 50+ messages in thread
From: Ard Biesheuvel @ 2021-03-16 15:00 UTC (permalink / raw)
To: devel, dandan.bi, Laszlo Ersek, Andrew Fish
Cc: Leif Lindholm, Michael D Kinney, Liming Gao
On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> RFC: https://edk2.groups.io/g/devel/message/72530
>
>
> Add RegisterFilterLibNull in dsc files in edk2-platforms repo,
> which will be consumed by IoLib and BaseLib.
>
> This is the following update in edk2-platforms repo for the change in edk2,
> which will add RegisterFilterLib dependency for IoLib and BaseLib to filter/trace
> port IO/MMIO/MSR access.
> https://edk2.groups.io/g/devel/message/72754
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
It is a bit disappointing that we have to update every platform in
existence again to apply a change to a core module.
Is there really not a better way to provide a 'default' resolution for
a library class? Maybe a change to the .DEC format, so that the file
which defines the library class can provide a resolution that is used
if none is provided by the .DSC file?
> Dandan Bi (35):
> Drivers/ASIX: Consume RegisterFilterLibNull instance
> Drivers/DisplayLink: Consume RegisterFilterLibNull instance
> Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
> Features/Debugging: Consume RegisterFilterLibNull instance
> Features/Network: Consume RegisterFilterLibNull instance
> Features/OutOfBandManagement: Consume RegisterFilterLibNull instance
> Features/PowerManagement: Consume RegisterFilterLibNull instance
> Features/SystemInformation: Consume RegisterFilterLibNull instance
> Features/UserInterface: Consume RegisterFilterLibNull instance
> Platform/AMD: Consume RegisterFilterLibNull instance
> Platform/ARM: Consume RegisterFilterLibNull instance
> Platform/BeagleBoard: Consume RegisterFilterLibNull instance
> Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
> Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
> Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
> Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
> Platform/LeMaker: Consume RegisterFilterLibNull instance
> Platform/Qemu: Consume RegisterFilterLibNull instance
> Platform/RaspberryPi: Consume RegisterFilterLibNull instance
> Platform/RISC-V: Consume RegisterFilterLibNull instance
> Platform/SiFive: Consume RegisterFilterLibNull instance
> Platform/Socionext: Consume RegisterFilterLibNull instance
> Platform/SoftIron: Consume RegisterFilterLibNull instance
> Silicon/Hisilicon: Consume RegisterFilterLibNull instance
> Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
> Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
> Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
> Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
> Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
> Silicon/Marvell: Consume RegisterFilterLibNull instance
> Silicon/NXP: Consume RegisterFilterLibNull instance
> Silicon/Openmoko: Consume RegisterFilterLibNull instance
> Silicon/RISC_V: Consume RegisterFilterLibNull instance
> Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
> Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
>
> Drivers/ASIX/Asix.dsc | 1 +
> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 +
> Drivers/OptionRomPkg/OptionRomPkg.dsc | 3 ++-
> .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3 ++-
> .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc | 3 ++-
> .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3 ++-
> .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc | 3 ++-
> .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3 ++-
> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3 ++-
> .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc | 3 ++-
> .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3 ++-
> .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3 ++-
> .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
> .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3 ++-
> .../Include/VirtualKeyboardFeature.dsc | 3 ++-
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 1 +
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++-
> Platform/Intel/BoardModulePkg/BoardModulePkg.dsc | 3 ++-
> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3 ++-
> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 ++-
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 ++-
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1 +
> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 ++-
> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 +
> .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
> Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
> Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++-
> Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++-
> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 ++-
> Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
> Silicon/Openmoko/Openmoko.dsc | 1 +
> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
> Silicon/Synopsys/DesignWare/DesignWare.dsc | 1 +
> Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc | 1 +
> 47 files changed, 70 insertions(+), 23 deletions(-)
>
> --
> 2.18.0.windows.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:54 ` [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: " Dandan Bi
@ 2021-03-16 15:04 ` Steele, Kelly
0 siblings, 0 replies; 50+ messages in thread
From: Steele, Kelly @ 2021-03-16 15:04 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io; +Cc: Kinney, Michael D
Reviewed-by: Kelly Steele <kelly.steele@intel.com>
> -----Original Message-----
> From: Bi, Dandan <dandan.bi@intel.com>
> Sent: Tuesday, March 16, 2021 7:54 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>
> Subject: [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg:
> Consume RegisterFilterLibNull instance
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> index e29c7465b1..632f8a44f1 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> @@ -101,10 +101,11 @@ [LibraryClasses]
>
> PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BaseP
> eCoffExtraActionLibNull.inf
> !endif
>
> DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLi
> bNull.inf
>
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> PeCoffGetEntryPointLib.inf
> VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
> +
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.i
> nf
>
> #
> # UEFI & PI
> #
>
> UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo
> otServicesTableLib.inf
> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> index 6fdfba9a58..83909c6357 100644
> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> @@ -89,10 +89,11 @@ [LibraryClasses]
>
> PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BaseP
> eCoffExtraActionLibNull.inf
> !endif
>
> DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLi
> bNull.inf
>
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> PeCoffGetEntryPointLib.inf
> VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
> +
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.i
> nf
>
> #
> # UEFI & PI
> #
>
> UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo
> otServicesTableLib.inf
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
2021-03-16 14:54 ` [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: " Dandan Bi
@ 2021-03-16 15:05 ` Steele, Kelly
0 siblings, 0 replies; 50+ messages in thread
From: Steele, Kelly @ 2021-03-16 15:05 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io; +Cc: Kinney, Michael D
Reviewed-by: Kelly Steele <kelly.steele@intel.com>
> -----Original Message-----
> From: Bi, Dandan <dandan.bi@intel.com>
> Sent: Tuesday, March 16, 2021 7:54 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>
> Subject: [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: Consume
> RegisterFilterLibNull instance
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
> b/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
> index e743a5e272..5b9679f32f 100644
> --- a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
> +++ b/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
> @@ -2,11 +2,11 @@
> # INTEL Quark SoC Module Package Reference Implementations
> #
> # This DSC file is used for Package Level build.
> #
> # This Module provides FRAMEWORK reference implementation for INTEL
> Quark SoC.
> -# Copyright (c) 2013-2016 Intel Corporation.
> +# Copyright (c) 2013-2021 Intel Corporation.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
>
> @@ -62,10 +62,11 @@ [LibraryClasses]
> !if $(CFG_SOURCE_DEBUG) == 1
>
> PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLibD
> ebug/PeCoffExtraActionLibDebug.inf
> !else
>
> PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BaseP
> eCoffExtraActionLibNull.inf
> !endif
> +
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.i
> nf
> #
> # UEFI & PI
> #
>
> UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo
> otServicesTableLib.inf
>
> UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib
> /UefiRuntimeServicesTableLib.inf
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-16 15:00 ` [edk2-devel] [edk2-platforms] [patch 00/35] " Ard Biesheuvel
@ 2021-03-16 16:23 ` Laszlo Ersek
2021-03-17 3:04 ` 回复: " gaoliming
1 sibling, 0 replies; 50+ messages in thread
From: Laszlo Ersek @ 2021-03-16 16:23 UTC (permalink / raw)
To: Ard Biesheuvel, devel, dandan.bi, Andrew Fish
Cc: Leif Lindholm, Michael D Kinney, Liming Gao
On 03/16/21 16:00, Ard Biesheuvel wrote:
> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>> RFC: https://edk2.groups.io/g/devel/message/72530
>>
>>
>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo,
>> which will be consumed by IoLib and BaseLib.
>>
>> This is the following update in edk2-platforms repo for the change in edk2,
>> which will add RegisterFilterLib dependency for IoLib and BaseLib to filter/trace
>> port IO/MMIO/MSR access.
>> https://edk2.groups.io/g/devel/message/72754
>>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>
>
> It is a bit disappointing that we have to update every platform in
> existence again to apply a change to a core module.
>
> Is there really not a better way to provide a 'default' resolution for
> a library class? Maybe a change to the .DEC format, so that the file
> which defines the library class can provide a resolution that is used
> if none is provided by the .DSC file?
I vaguely remember this feature was raised earlier (maybe implemented
via cross-Pkg DSC !include files). I believe some patches were posted
even. I think I asked for a libclass-by-libclass conversion for existent
platform DSCs (so I could verify that the new DSC include file would
give OVMF and ArmVirt the same resolutions as before). I don't recall
updates afterwards.
Thanks
Laszlo
>
>
>
>> Dandan Bi (35):
>> Drivers/ASIX: Consume RegisterFilterLibNull instance
>> Drivers/DisplayLink: Consume RegisterFilterLibNull instance
>> Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
>> Features/Debugging: Consume RegisterFilterLibNull instance
>> Features/Network: Consume RegisterFilterLibNull instance
>> Features/OutOfBandManagement: Consume RegisterFilterLibNull instance
>> Features/PowerManagement: Consume RegisterFilterLibNull instance
>> Features/SystemInformation: Consume RegisterFilterLibNull instance
>> Features/UserInterface: Consume RegisterFilterLibNull instance
>> Platform/AMD: Consume RegisterFilterLibNull instance
>> Platform/ARM: Consume RegisterFilterLibNull instance
>> Platform/BeagleBoard: Consume RegisterFilterLibNull instance
>> Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
>> Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
>> Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
>> Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
>> Platform/LeMaker: Consume RegisterFilterLibNull instance
>> Platform/Qemu: Consume RegisterFilterLibNull instance
>> Platform/RaspberryPi: Consume RegisterFilterLibNull instance
>> Platform/RISC-V: Consume RegisterFilterLibNull instance
>> Platform/SiFive: Consume RegisterFilterLibNull instance
>> Platform/Socionext: Consume RegisterFilterLibNull instance
>> Platform/SoftIron: Consume RegisterFilterLibNull instance
>> Silicon/Hisilicon: Consume RegisterFilterLibNull instance
>> Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
>> Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
>> Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
>> Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
>> Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
>> Silicon/Marvell: Consume RegisterFilterLibNull instance
>> Silicon/NXP: Consume RegisterFilterLibNull instance
>> Silicon/Openmoko: Consume RegisterFilterLibNull instance
>> Silicon/RISC_V: Consume RegisterFilterLibNull instance
>> Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
>> Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
>>
>> Drivers/ASIX/Asix.dsc | 1 +
>> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 +
>> Drivers/OptionRomPkg/OptionRomPkg.dsc | 3 ++-
>> .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3 ++-
>> .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc | 3 ++-
>> .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3 ++-
>> .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc | 3 ++-
>> .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3 ++-
>> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3 ++-
>> .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc | 3 ++-
>> .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3 ++-
>> .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3 ++-
>> .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
>> .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3 ++-
>> .../Include/VirtualKeyboardFeature.dsc | 3 ++-
>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
>> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 1 +
>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++-
>> Platform/Intel/BoardModulePkg/BoardModulePkg.dsc | 3 ++-
>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3 ++-
>> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 ++-
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 ++-
>> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
>> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1 +
>> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
>> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 ++-
>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 +
>> .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
>> Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
>> Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
>> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++-
>> Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++-
>> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 ++-
>> Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
>> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
>> Silicon/Openmoko/Openmoko.dsc | 1 +
>> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
>> Silicon/Synopsys/DesignWare/DesignWare.dsc | 1 +
>> Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc | 1 +
>> 47 files changed, 70 insertions(+), 23 deletions(-)
>>
>> --
>> 2.18.0.windows.1
>>
>>
>>
>>
>>
>>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-16 15:00 ` [edk2-devel] [edk2-platforms] [patch 00/35] " Ard Biesheuvel
2021-03-16 16:23 ` Laszlo Ersek
@ 2021-03-17 3:04 ` gaoliming
2021-03-17 15:05 ` Dandan Bi
1 sibling, 1 reply; 50+ messages in thread
From: gaoliming @ 2021-03-17 3:04 UTC (permalink / raw)
To: devel, ardb, dandan.bi, 'Laszlo Ersek',
'Andrew Fish'
Cc: 'Leif Lindholm', 'Michael D Kinney'
Ard and Dandan:
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> Biesheuvel
> 发送时间: 2021年3月16日 23:01
> 收件人: devel@edk2.groups.io; dandan.bi@intel.com; Laszlo Ersek
> <lersek@redhat.com>; Andrew Fish <afish@apple.com>
> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> RegisterFilterLibNull instance
>
> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> > RFC: https://edk2.groups.io/g/devel/message/72530
> >
> >
> > Add RegisterFilterLibNull in dsc files in edk2-platforms repo,
> > which will be consumed by IoLib and BaseLib.
> >
> > This is the following update in edk2-platforms repo for the change in edk2,
> > which will add RegisterFilterLib dependency for IoLib and BaseLib to
> filter/trace
> > port IO/MMIO/MSR access.
> > https://edk2.groups.io/g/devel/message/72754
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >
>
> It is a bit disappointing that we have to update every platform in
> existence again to apply a change to a core module.
>
I suggest to add MdePkg.dsc.inc file to include the default library instance,
and update all Platform DSC to include it. Then, for the future change, no change is required for platform DSC.
Because this patch set updates every platform DSC, I suggest to introduce MdePkg.dsc.inc file in this patch set.
Thanks
Liming
> Is there really not a better way to provide a 'default' resolution for
> a library class? Maybe a change to the .DEC format, so that the file
> which defines the library class can provide a resolution that is used
> if none is provided by the .DSC file?
>
>
>
> > Dandan Bi (35):
> > Drivers/ASIX: Consume RegisterFilterLibNull instance
> > Drivers/DisplayLink: Consume RegisterFilterLibNull instance
> > Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
> > Features/Debugging: Consume RegisterFilterLibNull instance
> > Features/Network: Consume RegisterFilterLibNull instance
> > Features/OutOfBandManagement: Consume RegisterFilterLibNull
> instance
> > Features/PowerManagement: Consume RegisterFilterLibNull instance
> > Features/SystemInformation: Consume RegisterFilterLibNull instance
> > Features/UserInterface: Consume RegisterFilterLibNull instance
> > Platform/AMD: Consume RegisterFilterLibNull instance
> > Platform/ARM: Consume RegisterFilterLibNull instance
> > Platform/BeagleBoard: Consume RegisterFilterLibNull instance
> > Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
> > Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
> > Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
> > Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
> > Platform/LeMaker: Consume RegisterFilterLibNull instance
> > Platform/Qemu: Consume RegisterFilterLibNull instance
> > Platform/RaspberryPi: Consume RegisterFilterLibNull instance
> > Platform/RISC-V: Consume RegisterFilterLibNull instance
> > Platform/SiFive: Consume RegisterFilterLibNull instance
> > Platform/Socionext: Consume RegisterFilterLibNull instance
> > Platform/SoftIron: Consume RegisterFilterLibNull instance
> > Silicon/Hisilicon: Consume RegisterFilterLibNull instance
> > Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
> > Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
> > Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
> > Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
> > Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
> > Silicon/Marvell: Consume RegisterFilterLibNull instance
> > Silicon/NXP: Consume RegisterFilterLibNull instance
> > Silicon/Openmoko: Consume RegisterFilterLibNull instance
> > Silicon/RISC_V: Consume RegisterFilterLibNull instance
> > Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
> > Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
> >
> > Drivers/ASIX/Asix.dsc
> | 1 +
> > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 +
> > Drivers/OptionRomPkg/OptionRomPkg.dsc
> | 3 ++-
> > .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3
> ++-
> > .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc | 3
> ++-
> > .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3
> ++-
> > .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc | 3
> ++-
> > .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3
> ++-
> > .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3
> ++-
> > .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc | 3
> ++-
> > .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3
> ++-
> > .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3
> ++-
> > .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
> > .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3
> ++-
> > .../Include/VirtualKeyboardFeature.dsc | 3
> ++-
> > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> | 1 +
> > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> | 1 +
> > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> | 1 +
> > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc |
> 3 ++-
> > Platform/Intel/BoardModulePkg/BoardModulePkg.dsc |
> 3 ++-
> > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3
> ++-
> > Platform/Intel/QuarkPlatformPkg/Quark.dsc |
> 1 +
> > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc |
> 1 +
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3
> ++-
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3
> ++-
> > Platform/LeMaker/CelloBoard/CelloBoard.dsc |
> 1 +
> > Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> | 1 +
> > Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1
> +
> > Platform/RaspberryPi/RPi3/RPi3.dsc |
> 3 ++-
> > Platform/RaspberryPi/RPi4/RPi4.dsc |
> 3 ++-
> > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc |
> 1 +
> > .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc |
> 1 +
> > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1
> +
> > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1
> +
> > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1
> +
> > Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
> > Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
> > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++-
> > Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++-
> > Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc |
> 3 ++-
> > Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
> > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc |
> 1 +
> > Silicon/NXP/NxpQoriqLs.dsc.inc |
> 1 +
> > Silicon/Openmoko/Openmoko.dsc
> | 1 +
> > Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
> > Silicon/Synopsys/DesignWare/DesignWare.dsc |
> 1 +
> > Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
> | 1 +
> > 47 files changed, 70 insertions(+), 23 deletions(-)
> >
> > --
> > 2.18.0.windows.1
> >
> >
> >
> >
> >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-platforms] [patch 21/35] Platform/SiFive: Consume RegisterFilterLibNull instance
2021-03-16 14:54 ` [edk2-platforms] [patch 21/35] Platform/SiFive: " Dandan Bi
@ 2021-03-17 8:14 ` Abner Chang
0 siblings, 0 replies; 50+ messages in thread
From: Abner Chang @ 2021-03-17 8:14 UTC (permalink / raw)
To: Dandan Bi, devel@edk2.groups.io; +Cc: Schaefer, Daniel, Chen, Gilbert
Reviewed-by: Abner Chang <abner.chang@hpe.com>
> -----Original Message-----
> From: Dandan Bi [mailto:dandan.bi@intel.com]
> Sent: Tuesday, March 16, 2021 10:54 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> Schaefer, Daniel <daniel.schaefer@hpe.com>; Chen, Gilbert
> <gilbert.chen@hpe.com>
> Subject: [edk2-platforms] [patch 21/35] Platform/SiFive: Consume
> RegisterFilterLibNull instance
>
> REF: INVALID URI REMOVED
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D3246&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulks
> kz6qU3NYRO03nHp9P7Z5q59A3E&m=Cb0wvC-JhDZlZpoJFTmLyTkS-
> M7F7MNmmwgIftctJKo&s=3tK0RQxCfxSaNAkQVhCZMm9tSQ8UFZ0u6IhZL6
> Oa4M4&e=
>
> Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 +
> .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index 2d652d215f..9610f0613a 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -94,10 +94,11 @@ [LibraryClasses]
> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
>
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Custo
> mizedDisplayLib.inf
> SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
> FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.i
> nf
>
> # RISC-V Platform Library
> TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
>
> RealTimeClockLib|EmbeddedPkg//Library/VirtualRealTimeClockLib/VirtualRe
> alTimeClockLib.inf
>
> diff --git
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> index 9f60475189..b3d4427a8a 100644
> ---
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> +++
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> @@ -94,10 +94,11 @@ [LibraryClasses]
> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
>
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Custo
> mizedDisplayLib.inf
> SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
> FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.i
> nf
>
> # RISC-V Platform Library
> TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
>
> RealTimeClockLib|EmbeddedPkg//Library/VirtualRealTimeClockLib/VirtualRe
> alTimeClockLib.inf
>
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-platforms] [patch 33/35] Silicon/RISC_V: Consume RegisterFilterLibNull instance
2021-03-16 14:54 ` [edk2-platforms] [patch 33/35] Silicon/RISC_V: " Dandan Bi
@ 2021-03-17 8:14 ` Abner Chang
0 siblings, 0 replies; 50+ messages in thread
From: Abner Chang @ 2021-03-17 8:14 UTC (permalink / raw)
To: Dandan Bi, devel@edk2.groups.io; +Cc: Schaefer, Daniel, Chen, Gilbert
Reviewed-by: Abner Chang <abner.chang@hpe.com>
> -----Original Message-----
> From: Dandan Bi [mailto:dandan.bi@intel.com]
> Sent: Tuesday, March 16, 2021 10:54 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> Schaefer, Daniel <daniel.schaefer@hpe.com>; Chen, Gilbert
> <gilbert.chen@hpe.com>
> Subject: [edk2-platforms] [patch 33/35] Silicon/RISC_V: Consume
> RegisterFilterLibNull instance
>
> REF: INVALID URI REMOVED
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D3246&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulks
> kz6qU3NYRO03nHp9P7Z5q59A3E&m=MklchPJamBAu-
> fvB7UrrVH7jj_O6dpn1jjV-
> fgZb8oQ&s=w0BZz0ZKe9CvaDHbl3roWRtJm4j_PstLMOzgsjbR_Vc&e=
>
> Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
> b/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
> index 5f88f5e89f..da4083c81e 100644
> --- a/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
> +++ b/Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
> @@ -62,10 +62,11 @@ [LibraryClasses.common]
>
> UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiA
> pplicationEntryPoint.inf
> UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
>
> DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiD
> evicePathLibDevicePathProtocol.inf
> RiscVPlatformTimerLib|Silicon/RISC-
> V/ProcessorPkg/Library/RiscVPlatformTimerLibNull/RiscVPlatformTimerLib.in
> f
> PeiServicesTablePointerLib|Silicon/RISC-
> V/ProcessorPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTabl
> ePointerLibOpenSbi.inf
> +
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.i
> nf
>
> [LibraryClasses.common.PEI_CORE]
> PeiServicesTablePointerLib|Silicon/RISC-
> V/ProcessorPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTabl
> ePointerLibOpenSbi.inf
>
> [LibraryClasses.common.PEIM]
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-platforms] [patch 20/35] Platform/RISC-V: Consume RegisterFilterLibNull instance
2021-03-16 14:54 ` [edk2-platforms] [patch 20/35] Platform/RISC-V: " Dandan Bi
@ 2021-03-17 8:14 ` Abner Chang
0 siblings, 0 replies; 50+ messages in thread
From: Abner Chang @ 2021-03-17 8:14 UTC (permalink / raw)
To: Dandan Bi, devel@edk2.groups.io; +Cc: Schaefer, Daniel, Chen, Gilbert
Reviewed-by: Abner Chang <abner.chang@hpe.com>
> -----Original Message-----
> From: Dandan Bi [mailto:dandan.bi@intel.com]
> Sent: Tuesday, March 16, 2021 10:54 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> Schaefer, Daniel <daniel.schaefer@hpe.com>; Chen, Gilbert
> <gilbert.chen@hpe.com>
> Subject: [edk2-platforms] [patch 20/35] Platform/RISC-V: Consume
> RegisterFilterLibNull instance
>
> REF: INVALID URI REMOVED
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D3246&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulks
> kz6qU3NYRO03nHp9P7Z5q59A3E&m=I7cqLnSi748oQzvkydupz45EAffDQMtiQ
> Y8tZnG9bVk&s=ANUyqJkcOsuNjfM8eYL5LwrUhVliwmLoIV76k4KIEqA&e=
>
> Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> index 092717d2ef..961e1234e9 100644
> --- a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> +++ b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> @@ -53,10 +53,11 @@ [LibraryClasses.common]
> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in
> f
>
> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem
> plate.inf
>
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> PeCoffGetEntryPointLib.inf
> +
> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.i
> nf
>
> [LibraryClasses.common.PEIM]
> FirmwareContextProcessorSpecificLib|Platform/RISC-
> V/PlatformPkg/Library/FirmwareContextProcessorSpecificLib/FirmwareCont
> extProcessorSpecificLib.inf
> HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
>
> MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemory
> AllocationLib.inf
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-17 3:04 ` 回复: " gaoliming
@ 2021-03-17 15:05 ` Dandan Bi
2021-03-17 17:08 ` Laszlo Ersek
0 siblings, 1 reply; 50+ messages in thread
From: Dandan Bi @ 2021-03-17 15:05 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, ardb@kernel.org,
'Laszlo Ersek', 'Andrew Fish'
Cc: 'Leif Lindholm', Kinney, Michael D
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Wednesday, March 17, 2021 11:05 AM
> To: devel@edk2.groups.io; ardb@kernel.org; Bi, Dandan
> <dandan.bi@intel.com>; 'Laszlo Ersek' <lersek@redhat.com>; 'Andrew Fish'
> <afish@apple.com>
> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> RegisterFilterLibNull instance
>
> Ard and Dandan:
>
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> Biesheuvel
> > 发送时间: 2021年3月16日 23:01
> > 收件人: devel@edk2.groups.io; dandan.bi@intel.com; Laszlo Ersek
> > <lersek@redhat.com>; Andrew Fish <afish@apple.com>
> > 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> > RegisterFilterLibNull instance
> >
> > On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> > > RFC: https://edk2.groups.io/g/devel/message/72530
> > >
> > >
> > > Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which
> > > will be consumed by IoLib and BaseLib.
> > >
> > > This is the following update in edk2-platforms repo for the change
> > > in edk2, which will add RegisterFilterLib dependency for IoLib and
> > > BaseLib to
> > filter/trace
> > > port IO/MMIO/MSR access.
> > > https://edk2.groups.io/g/devel/message/72754
> > >
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >
> >
> > It is a bit disappointing that we have to update every platform in
> > existence again to apply a change to a core module.
> >
>
> I suggest to add MdePkg.dsc.inc file to include the default library instance,
> and update all Platform DSC to include it. Then, for the future change, no
> change is required for platform DSC.
>
> Because this patch set updates every platform DSC, I suggest to introduce
> MdePkg.dsc.inc file in this patch set.
Hi Liming,
I agree that add MdePkg.dsc.inc file to include the default library instance and make it consumed by platform dsc will benefit future similar incompatible changes.
But I wonder to know whether we could do it in a separated task/topic, as
1. It should be a code infrastructure design change/improvement in edk2.
2. Personally I don't hope the new solution will have much impact on my current schedule, but it seems have.
And we may need to:
1). Clarify the default library instances which should be added in MdePkg.dsc.inc
The library instances in MdePkg.dsc.inc should be generic enough to be widely included in platform dsc files.
2). Update dsc files in edk2 and edk2-platforms repo to include MdePkg.dsc.inc and cleanup the default Lib instance in dsc files.
Thanks,
Dandan
>
> Thanks
> Liming
> > Is there really not a better way to provide a 'default' resolution for
> > a library class? Maybe a change to the .DEC format, so that the file
> > which defines the library class can provide a resolution that is used
> > if none is provided by the .DSC file?
> >
> >
> >
> > > Dandan Bi (35):
> > > Drivers/ASIX: Consume RegisterFilterLibNull instance
> > > Drivers/DisplayLink: Consume RegisterFilterLibNull instance
> > > Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
> > > Features/Debugging: Consume RegisterFilterLibNull instance
> > > Features/Network: Consume RegisterFilterLibNull instance
> > > Features/OutOfBandManagement: Consume RegisterFilterLibNull
> > instance
> > > Features/PowerManagement: Consume RegisterFilterLibNull instance
> > > Features/SystemInformation: Consume RegisterFilterLibNull instance
> > > Features/UserInterface: Consume RegisterFilterLibNull instance
> > > Platform/AMD: Consume RegisterFilterLibNull instance
> > > Platform/ARM: Consume RegisterFilterLibNull instance
> > > Platform/BeagleBoard: Consume RegisterFilterLibNull instance
> > > Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
> > > Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
> > > Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
> > > Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
> > > Platform/LeMaker: Consume RegisterFilterLibNull instance
> > > Platform/Qemu: Consume RegisterFilterLibNull instance
> > > Platform/RaspberryPi: Consume RegisterFilterLibNull instance
> > > Platform/RISC-V: Consume RegisterFilterLibNull instance
> > > Platform/SiFive: Consume RegisterFilterLibNull instance
> > > Platform/Socionext: Consume RegisterFilterLibNull instance
> > > Platform/SoftIron: Consume RegisterFilterLibNull instance
> > > Silicon/Hisilicon: Consume RegisterFilterLibNull instance
> > > Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
> > > Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
> > > Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
> > > Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
> > > Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
> > > Silicon/Marvell: Consume RegisterFilterLibNull instance
> > > Silicon/NXP: Consume RegisterFilterLibNull instance
> > > Silicon/Openmoko: Consume RegisterFilterLibNull instance
> > > Silicon/RISC_V: Consume RegisterFilterLibNull instance
> > > Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
> > > Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
> > >
> > > Drivers/ASIX/Asix.dsc
> > | 1 +
> > > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 +
> > > Drivers/OptionRomPkg/OptionRomPkg.dsc
> > | 3 ++-
> > > .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3
> > ++-
> > > .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc |
> 3
> > ++-
> > > .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3
> > ++-
> > > .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc |
> 3
> > ++-
> > > .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3
> > ++-
> > > .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc |
> 3
> > ++-
> > > .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc |
> 3
> > ++-
> > > .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3
> > ++-
> > > .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3
> > ++-
> > > .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
> > > .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3
> > ++-
> > > .../Include/VirtualKeyboardFeature.dsc | 3
> > ++-
> > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > | 1 +
> > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > | 1 +
> > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> > | 1 +
> > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc |
> > 3 ++-
> > > Platform/Intel/BoardModulePkg/BoardModulePkg.dsc |
> > 3 ++-
> > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3
> > ++-
> > > Platform/Intel/QuarkPlatformPkg/Quark.dsc |
> > 1 +
> > > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc |
> > 1 +
> > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3
> > ++-
> > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3
> > ++-
> > > Platform/LeMaker/CelloBoard/CelloBoard.dsc |
> > 1 +
> > > Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> > | 1 +
> > > Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1
> > +
> > > Platform/RaspberryPi/RPi3/RPi3.dsc |
> > 3 ++-
> > > Platform/RaspberryPi/RPi4/RPi4.dsc |
> > 3 ++-
> > > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc |
> > 1 +
> > > .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc |
> > 1 +
> > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1
> > +
> > > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1
> > +
> > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1
> > +
> > > Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
> > > Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
> > > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++-
> > > Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++-
> > > Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc |
> > 3 ++-
> > > Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
> > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc |
> > 1 +
> > > Silicon/NXP/NxpQoriqLs.dsc.inc |
> > 1 +
> > > Silicon/Openmoko/Openmoko.dsc
> > | 1 +
> > > Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
> > > Silicon/Synopsys/DesignWare/DesignWare.dsc |
> > 1 +
> > > Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
> > | 1 +
> > > 47 files changed, 70 insertions(+), 23 deletions(-)
> > >
> > > --
> > > 2.18.0.windows.1
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-17 15:05 ` Dandan Bi
@ 2021-03-17 17:08 ` Laszlo Ersek
2021-03-18 4:43 ` 回复: " gaoliming
0 siblings, 1 reply; 50+ messages in thread
From: Laszlo Ersek @ 2021-03-17 17:08 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io, gaoliming@byosoft.com.cn,
ardb@kernel.org, 'Andrew Fish'
Cc: 'Leif Lindholm', Kinney, Michael D
On 03/17/21 16:05, Bi, Dandan wrote:
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>> gaoliming
>> Sent: Wednesday, March 17, 2021 11:05 AM
>> To: devel@edk2.groups.io; ardb@kernel.org; Bi, Dandan
>> <dandan.bi@intel.com>; 'Laszlo Ersek' <lersek@redhat.com>; 'Andrew Fish'
>> <afish@apple.com>
>> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
>> RegisterFilterLibNull instance
>>
>> Ard and Dandan:
>>
>>> -----邮件原件-----
>>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
>> Biesheuvel
>>> 发送时间: 2021年3月16日 23:01
>>> 收件人: devel@edk2.groups.io; dandan.bi@intel.com; Laszlo Ersek
>>> <lersek@redhat.com>; Andrew Fish <afish@apple.com>
>>> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
>>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
>>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
>>> RegisterFilterLibNull instance
>>>
>>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
>>>>
>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>>>> RFC: https://edk2.groups.io/g/devel/message/72530
>>>>
>>>>
>>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which
>>>> will be consumed by IoLib and BaseLib.
>>>>
>>>> This is the following update in edk2-platforms repo for the change
>>>> in edk2, which will add RegisterFilterLib dependency for IoLib and
>>>> BaseLib to
>>> filter/trace
>>>> port IO/MMIO/MSR access.
>>>> https://edk2.groups.io/g/devel/message/72754
>>>>
>>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>>
>>>
>>> It is a bit disappointing that we have to update every platform in
>>> existence again to apply a change to a core module.
>>>
>>
>> I suggest to add MdePkg.dsc.inc file to include the default library instance,
>> and update all Platform DSC to include it. Then, for the future change, no
>> change is required for platform DSC.
>>
>> Because this patch set updates every platform DSC, I suggest to introduce
>> MdePkg.dsc.inc file in this patch set.
>
> Hi Liming,
>
> I agree that add MdePkg.dsc.inc file to include the default library instance and make it consumed by platform dsc will benefit future similar incompatible changes.
> But I wonder to know whether we could do it in a separated task/topic, as
> 1. It should be a code infrastructure design change/improvement in edk2.
> 2. Personally I don't hope the new solution will have much impact on my current schedule, but it seems have.
> And we may need to:
> 1). Clarify the default library instances which should be added in MdePkg.dsc.inc
> The library instances in MdePkg.dsc.inc should be generic enough to be widely included in platform dsc files.
> 2). Update dsc files in edk2 and edk2-platforms repo to include MdePkg.dsc.inc and cleanup the default Lib instance in dsc files.
(1) The file name should be "MdeLibs.dsc.inc", and it should be
structured similarly "NetworkLibs.dsc.inc" -- no [LibraryClasses] header
should be part of the file.
(2) The introduction of "MdeLibs.dsc.inc" is a big task, in my opinion.
As I stated earlier, I wouldn't like to review a patch for OvmfPkg that
replaces (say) 50-100 lines of library class resolutions with a simple
!include directive. Such a patch is unreviewable, as I'd have no way of
carefully comparing the before-after state, let alone a way of *pointing
out* (in comments) where exactly a problem was.
So I think such an include file would require a patch set, and the lib
class resolutions should be migrated in small *topical* steps. Such as:
- introduce the DSC include file as empty
- add the !include directive to platform DSCs
- add a small set of libraries (with some topical coherence) to the
include file,
- remove the same set of resolutions from platform DSCs,
- repeat the last two steps until all "topics" have been covered.
Thanks
Laszlo
>
>
> Thanks,
> Dandan
>>
>> Thanks
>> Liming
>>> Is there really not a better way to provide a 'default' resolution for
>>> a library class? Maybe a change to the .DEC format, so that the file
>>> which defines the library class can provide a resolution that is used
>>> if none is provided by the .DSC file?
>>>
>>>
>>>
>>>> Dandan Bi (35):
>>>> Drivers/ASIX: Consume RegisterFilterLibNull instance
>>>> Drivers/DisplayLink: Consume RegisterFilterLibNull instance
>>>> Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
>>>> Features/Debugging: Consume RegisterFilterLibNull instance
>>>> Features/Network: Consume RegisterFilterLibNull instance
>>>> Features/OutOfBandManagement: Consume RegisterFilterLibNull
>>> instance
>>>> Features/PowerManagement: Consume RegisterFilterLibNull instance
>>>> Features/SystemInformation: Consume RegisterFilterLibNull instance
>>>> Features/UserInterface: Consume RegisterFilterLibNull instance
>>>> Platform/AMD: Consume RegisterFilterLibNull instance
>>>> Platform/ARM: Consume RegisterFilterLibNull instance
>>>> Platform/BeagleBoard: Consume RegisterFilterLibNull instance
>>>> Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
>>>> Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
>>>> Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
>>>> Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
>>>> Platform/LeMaker: Consume RegisterFilterLibNull instance
>>>> Platform/Qemu: Consume RegisterFilterLibNull instance
>>>> Platform/RaspberryPi: Consume RegisterFilterLibNull instance
>>>> Platform/RISC-V: Consume RegisterFilterLibNull instance
>>>> Platform/SiFive: Consume RegisterFilterLibNull instance
>>>> Platform/Socionext: Consume RegisterFilterLibNull instance
>>>> Platform/SoftIron: Consume RegisterFilterLibNull instance
>>>> Silicon/Hisilicon: Consume RegisterFilterLibNull instance
>>>> Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
>>>> Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
>>>> Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
>>>> Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
>>>> Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
>>>> Silicon/Marvell: Consume RegisterFilterLibNull instance
>>>> Silicon/NXP: Consume RegisterFilterLibNull instance
>>>> Silicon/Openmoko: Consume RegisterFilterLibNull instance
>>>> Silicon/RISC_V: Consume RegisterFilterLibNull instance
>>>> Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
>>>> Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
>>>>
>>>> Drivers/ASIX/Asix.dsc
>>> | 1 +
>>>> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 +
>>>> Drivers/OptionRomPkg/OptionRomPkg.dsc
>>> | 3 ++-
>>>> .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3
>>> ++-
>>>> .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc |
>> 3
>>> ++-
>>>> .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3
>>> ++-
>>>> .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc |
>> 3
>>> ++-
>>>> .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3
>>> ++-
>>>> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc |
>> 3
>>> ++-
>>>> .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc |
>> 3
>>> ++-
>>>> .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3
>>> ++-
>>>> .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3
>>> ++-
>>>> .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
>>>> .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc | 3
>>> ++-
>>>> .../Include/VirtualKeyboardFeature.dsc | 3
>>> ++-
>>>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>>> | 1 +
>>>> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
>>> | 1 +
>>>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
>>> | 1 +
>>>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc |
>>> 3 ++-
>>>> Platform/Intel/BoardModulePkg/BoardModulePkg.dsc |
>>> 3 ++-
>>>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3
>>> ++-
>>>> Platform/Intel/QuarkPlatformPkg/Quark.dsc |
>>> 1 +
>>>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc |
>>> 1 +
>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3
>>> ++-
>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3
>>> ++-
>>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc |
>>> 1 +
>>>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc
>>> | 1 +
>>>> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1
>>> +
>>>> Platform/RaspberryPi/RPi3/RPi3.dsc |
>>> 3 ++-
>>>> Platform/RaspberryPi/RPi4/RPi4.dsc |
>>> 3 ++-
>>>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc |
>>> 1 +
>>>> .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc |
>>> 1 +
>>>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1
>>> +
>>>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1
>>> +
>>>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1
>>> +
>>>> Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
>>>> Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
>>>> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++-
>>>> Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++-
>>>> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc |
>>> 3 ++-
>>>> Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
>>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc |
>>> 1 +
>>>> Silicon/NXP/NxpQoriqLs.dsc.inc |
>>> 1 +
>>>> Silicon/Openmoko/Openmoko.dsc
>>> | 1 +
>>>> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 +
>>>> Silicon/Synopsys/DesignWare/DesignWare.dsc |
>>> 1 +
>>>> Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
>>> | 1 +
>>>> 47 files changed, 70 insertions(+), 23 deletions(-)
>>>>
>>>> --
>>>> 2.18.0.windows.1
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
>>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-17 17:08 ` Laszlo Ersek
@ 2021-03-18 4:43 ` gaoliming
2021-03-18 13:25 ` Laszlo Ersek
0 siblings, 1 reply; 50+ messages in thread
From: gaoliming @ 2021-03-18 4:43 UTC (permalink / raw)
To: 'Laszlo Ersek', 'Bi, Dandan', devel, ardb,
'Andrew Fish'
Cc: 'Leif Lindholm', 'Kinney, Michael D'
Laszlo and Dandan:
> -----邮件原件-----
> 发件人: Laszlo Ersek <lersek@redhat.com>
> 发送时间: 2021年3月18日 1:08
> 收件人: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io;
> gaoliming@byosoft.com.cn; ardb@kernel.org; 'Andrew Fish'
> <afish@apple.com>
> 抄送: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> RegisterFilterLibNull instance
>
> On 03/17/21 16:05, Bi, Dandan wrote:
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> >> gaoliming
> >> Sent: Wednesday, March 17, 2021 11:05 AM
> >> To: devel@edk2.groups.io; ardb@kernel.org; Bi, Dandan
> >> <dandan.bi@intel.com>; 'Laszlo Ersek' <lersek@redhat.com>; 'Andrew
> Fish'
> >> <afish@apple.com>
> >> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> >> <michael.d.kinney@intel.com>
> >> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> >> RegisterFilterLibNull instance
> >>
> >> Ard and Dandan:
> >>
> >>> -----邮件原件-----
> >>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> >> Biesheuvel
> >>> 发送时间: 2021年3月16日 23:01
> >>> 收件人: devel@edk2.groups.io; dandan.bi@intel.com; Laszlo Ersek
> >>> <lersek@redhat.com>; Andrew Fish <afish@apple.com>
> >>> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> >>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> >>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> >>> RegisterFilterLibNull instance
> >>>
> >>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
> >>>>
> >>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> >>>> RFC: https://edk2.groups.io/g/devel/message/72530
> >>>>
> >>>>
> >>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which
> >>>> will be consumed by IoLib and BaseLib.
> >>>>
> >>>> This is the following update in edk2-platforms repo for the change
> >>>> in edk2, which will add RegisterFilterLib dependency for IoLib and
> >>>> BaseLib to
> >>> filter/trace
> >>>> port IO/MMIO/MSR access.
> >>>> https://edk2.groups.io/g/devel/message/72754
> >>>>
> >>>> Cc: Leif Lindholm <leif@nuviainc.com>
> >>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >>>>
> >>>
> >>> It is a bit disappointing that we have to update every platform in
> >>> existence again to apply a change to a core module.
> >>>
> >>
> >> I suggest to add MdePkg.dsc.inc file to include the default library instance,
> >> and update all Platform DSC to include it. Then, for the future change, no
> >> change is required for platform DSC.
> >>
> >> Because this patch set updates every platform DSC, I suggest to introduce
> >> MdePkg.dsc.inc file in this patch set.
> >
> > Hi Liming,
> >
> > I agree that add MdePkg.dsc.inc file to include the default library instance
> and make it consumed by platform dsc will benefit future similar incompatible
> changes.
> > But I wonder to know whether we could do it in a separated task/topic, as
> > 1. It should be a code infrastructure design change/improvement in edk2.
> > 2. Personally I don't hope the new solution will have much impact on my
> current schedule, but it seems have.
> > And we may need to:
> > 1). Clarify the default library instances which should be added in
> MdePkg.dsc.inc
> > The library instances in MdePkg.dsc.inc should be generic enough to
> be widely included in platform dsc files.
> > 2). Update dsc files in edk2 and edk2-platforms repo to include
> MdePkg.dsc.inc and cleanup the default Lib instance in dsc files.
>
> (1) The file name should be "MdeLibs.dsc.inc", and it should be
> structured similarly "NetworkLibs.dsc.inc" -- no [LibraryClasses] header
> should be part of the file.
>
I agree.
> (2) The introduction of "MdeLibs.dsc.inc" is a big task, in my opinion.
>
The full MdeLibs.dsc.inc is a big task. But, it should be a separate task.
For this patch set, the first version MdeLibs.dsc.inc can be added. It only includes RegisterFilterLibNull library instance.
And, this patch set will update every platform DSC to include MdeLibs.dsc.inc.
The future incompatible change can update MdeLibs.dsc.inc only, and avoid the change in each platform DSC.
I would like to resolve the potential incompatible change by MdeLibs.dsc.inc on the first step.
Thanks
Liming
> As I stated earlier, I wouldn't like to review a patch for OvmfPkg that
> replaces (say) 50-100 lines of library class resolutions with a simple
> !include directive. Such a patch is unreviewable, as I'd have no way of
> carefully comparing the before-after state, let alone a way of *pointing
> out* (in comments) where exactly a problem was.
>
> So I think such an include file would require a patch set, and the lib
> class resolutions should be migrated in small *topical* steps. Such as:
>
> - introduce the DSC include file as empty
> - add the !include directive to platform DSCs
> - add a small set of libraries (with some topical coherence) to the
> include file,
> - remove the same set of resolutions from platform DSCs,
> - repeat the last two steps until all "topics" have been covered.
>
> Thanks
> Laszlo
>
>
> >
> >
> > Thanks,
> > Dandan
> >>
> >> Thanks
> >> Liming
> >>> Is there really not a better way to provide a 'default' resolution for
> >>> a library class? Maybe a change to the .DEC format, so that the file
> >>> which defines the library class can provide a resolution that is used
> >>> if none is provided by the .DSC file?
> >>>
> >>>
> >>>
> >>>> Dandan Bi (35):
> >>>> Drivers/ASIX: Consume RegisterFilterLibNull instance
> >>>> Drivers/DisplayLink: Consume RegisterFilterLibNull instance
> >>>> Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
> >>>> Features/Debugging: Consume RegisterFilterLibNull instance
> >>>> Features/Network: Consume RegisterFilterLibNull instance
> >>>> Features/OutOfBandManagement: Consume RegisterFilterLibNull
> >>> instance
> >>>> Features/PowerManagement: Consume RegisterFilterLibNull
> instance
> >>>> Features/SystemInformation: Consume RegisterFilterLibNull instance
> >>>> Features/UserInterface: Consume RegisterFilterLibNull instance
> >>>> Platform/AMD: Consume RegisterFilterLibNull instance
> >>>> Platform/ARM: Consume RegisterFilterLibNull instance
> >>>> Platform/BeagleBoard: Consume RegisterFilterLibNull instance
> >>>> Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
> >>>> Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
> >>>> Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
> >>>> Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
> >>>> Platform/LeMaker: Consume RegisterFilterLibNull instance
> >>>> Platform/Qemu: Consume RegisterFilterLibNull instance
> >>>> Platform/RaspberryPi: Consume RegisterFilterLibNull instance
> >>>> Platform/RISC-V: Consume RegisterFilterLibNull instance
> >>>> Platform/SiFive: Consume RegisterFilterLibNull instance
> >>>> Platform/Socionext: Consume RegisterFilterLibNull instance
> >>>> Platform/SoftIron: Consume RegisterFilterLibNull instance
> >>>> Silicon/Hisilicon: Consume RegisterFilterLibNull instance
> >>>> Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
> >>>> Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
> >>>> Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
> >>>> Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
> >>>> Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
> >>>> Silicon/Marvell: Consume RegisterFilterLibNull instance
> >>>> Silicon/NXP: Consume RegisterFilterLibNull instance
> >>>> Silicon/Openmoko: Consume RegisterFilterLibNull instance
> >>>> Silicon/RISC_V: Consume RegisterFilterLibNull instance
> >>>> Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull
> instance
> >>>> Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
> >>>>
> >>>> Drivers/ASIX/Asix.dsc
> >>> | 1 +
> >>>> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1
> +
> >>>> Drivers/OptionRomPkg/OptionRomPkg.dsc
> >>> | 3 ++-
> >>>> .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc |
> 3
> >>> ++-
> >>>> .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc
> |
> >> 3
> >>> ++-
> >>>> .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc
> | 3
> >>> ++-
> >>>> .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc
> |
> >> 3
> >>> ++-
> >>>> .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc |
> 3
> >>> ++-
> >>>> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> |
> >> 3
> >>> ++-
> >>>> .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc
> |
> >> 3
> >>> ++-
> >>>> .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
> | 3
> >>> ++-
> >>>> .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc
> | 3
> >>> ++-
> >>>> .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3
> ++-
> >>>> .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc
> | 3
> >>> ++-
> >>>> .../Include/VirtualKeyboardFeature.dsc
> | 3
> >>> ++-
> >>>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> >>> | 1 +
> >>>> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> >>> | 1 +
> >>>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> >>> | 1 +
> >>>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> |
> >>> 3 ++-
> >>>> Platform/Intel/BoardModulePkg/BoardModulePkg.dsc
> |
> >>> 3 ++-
> >>>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> | 3
> >>> ++-
> >>>> Platform/Intel/QuarkPlatformPkg/Quark.dsc
> |
> >>> 1 +
> >>>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> |
> >>> 1 +
> >>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc |
> 3
> >>> ++-
> >>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc |
> 3
> >>> ++-
> >>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc
> |
> >>> 1 +
> >>>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> >>> | 1 +
> >>>> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> | 1
> >>> +
> >>>> Platform/RaspberryPi/RPi3/RPi3.dsc
> |
> >>> 3 ++-
> >>>> Platform/RaspberryPi/RPi4/RPi4.dsc
> |
> >>> 3 ++-
> >>>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> |
> >>> 1 +
> >>>> .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> |
> >>> 1 +
> >>>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> | 1
> >>> +
> >>>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> | 1
> >>> +
> >>>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> | 1
> >>> +
> >>>> Silicon/Hisilicon/Hisilicon.dsc.inc | 1
> +
> >>>> Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
> >>>> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3
> ++-
> >>>> Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3
> ++-
> >>>> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
> |
> >>> 3 ++-
> >>>> Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
> >>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> |
> >>> 1 +
> >>>> Silicon/NXP/NxpQoriqLs.dsc.inc
> |
> >>> 1 +
> >>>> Silicon/Openmoko/Openmoko.dsc
> >>> | 1 +
> >>>> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc |
> 1 +
> >>>> Silicon/Synopsys/DesignWare/DesignWare.dsc
> |
> >>> 1 +
> >>>> Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
> >>> | 1 +
> >>>> 47 files changed, 70 insertions(+), 23 deletions(-)
> >>>>
> >>>> --
> >>>> 2.18.0.windows.1
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-18 4:43 ` 回复: " gaoliming
@ 2021-03-18 13:25 ` Laszlo Ersek
2021-03-18 13:42 ` Ni, Ray
0 siblings, 1 reply; 50+ messages in thread
From: Laszlo Ersek @ 2021-03-18 13:25 UTC (permalink / raw)
To: gaoliming, 'Bi, Dandan', devel, ardb,
'Andrew Fish'
Cc: 'Leif Lindholm', 'Kinney, Michael D'
On 03/18/21 05:43, gaoliming wrote:
> Laszlo and Dandan:
>
>> -----邮件原件-----
>> 发件人: Laszlo Ersek <lersek@redhat.com>
>> 发送时间: 2021年3月18日 1:08
>> 收件人: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io;
>> gaoliming@byosoft.com.cn; ardb@kernel.org; 'Andrew Fish'
>> <afish@apple.com>
>> 抄送: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
>> RegisterFilterLibNull instance
>>
>> On 03/17/21 16:05, Bi, Dandan wrote:
>>>> -----Original Message-----
>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>>>> gaoliming
>>>> Sent: Wednesday, March 17, 2021 11:05 AM
>>>> To: devel@edk2.groups.io; ardb@kernel.org; Bi, Dandan
>>>> <dandan.bi@intel.com>; 'Laszlo Ersek' <lersek@redhat.com>; 'Andrew
>> Fish'
>>>> <afish@apple.com>
>>>> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
>>>> <michael.d.kinney@intel.com>
>>>> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
>>>> RegisterFilterLibNull instance
>>>>
>>>> Ard and Dandan:
>>>>
>>>>> -----邮件原件-----
>>>>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
>>>> Biesheuvel
>>>>> 发送时间: 2021年3月16日 23:01
>>>>> 收件人: devel@edk2.groups.io; dandan.bi@intel.com; Laszlo Ersek
>>>>> <lersek@redhat.com>; Andrew Fish <afish@apple.com>
>>>>> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
>>>>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
>>>>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
>>>>> RegisterFilterLibNull instance
>>>>>
>>>>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
>>>>>>
>>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>>>>>> RFC: https://edk2.groups.io/g/devel/message/72530
>>>>>>
>>>>>>
>>>>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which
>>>>>> will be consumed by IoLib and BaseLib.
>>>>>>
>>>>>> This is the following update in edk2-platforms repo for the change
>>>>>> in edk2, which will add RegisterFilterLib dependency for IoLib and
>>>>>> BaseLib to
>>>>> filter/trace
>>>>>> port IO/MMIO/MSR access.
>>>>>> https://edk2.groups.io/g/devel/message/72754
>>>>>>
>>>>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>>>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>>>>
>>>>>
>>>>> It is a bit disappointing that we have to update every platform in
>>>>> existence again to apply a change to a core module.
>>>>>
>>>>
>>>> I suggest to add MdePkg.dsc.inc file to include the default library instance,
>>>> and update all Platform DSC to include it. Then, for the future change, no
>>>> change is required for platform DSC.
>>>>
>>>> Because this patch set updates every platform DSC, I suggest to introduce
>>>> MdePkg.dsc.inc file in this patch set.
>>>
>>> Hi Liming,
>>>
>>> I agree that add MdePkg.dsc.inc file to include the default library instance
>> and make it consumed by platform dsc will benefit future similar incompatible
>> changes.
>>> But I wonder to know whether we could do it in a separated task/topic, as
>>> 1. It should be a code infrastructure design change/improvement in edk2.
>>> 2. Personally I don't hope the new solution will have much impact on my
>> current schedule, but it seems have.
>>> And we may need to:
>>> 1). Clarify the default library instances which should be added in
>> MdePkg.dsc.inc
>>> The library instances in MdePkg.dsc.inc should be generic enough to
>> be widely included in platform dsc files.
>>> 2). Update dsc files in edk2 and edk2-platforms repo to include
>> MdePkg.dsc.inc and cleanup the default Lib instance in dsc files.
>>
>> (1) The file name should be "MdeLibs.dsc.inc", and it should be
>> structured similarly "NetworkLibs.dsc.inc" -- no [LibraryClasses] header
>> should be part of the file.
>>
> I agree.
>
>> (2) The introduction of "MdeLibs.dsc.inc" is a big task, in my opinion.
>>
> The full MdeLibs.dsc.inc is a big task. But, it should be a separate task.
>
> For this patch set, the first version MdeLibs.dsc.inc can be added. It only includes RegisterFilterLibNull library instance.
> And, this patch set will update every platform DSC to include MdeLibs.dsc.inc.
> The future incompatible change can update MdeLibs.dsc.inc only, and avoid the change in each platform DSC.
> I would like to resolve the potential incompatible change by MdeLibs.dsc.inc on the first step.
That's a good idea!
Dandan is touching up a bunch of DSC files already, so we might even use
this opportunity to introduce "MdeLibs.dsc.inc". And, at this time,
"MdeLibs.dsc.inc" would be really small, and not hard to review for
individual platforms -- in particular it wouldn't attempt to *replace*
existent lib class resolutions. So indeed this looks like a nice
approach to me.
Thanks!
Laszlo
>
> Thanks
> Liming
>> As I stated earlier, I wouldn't like to review a patch for OvmfPkg that
>> replaces (say) 50-100 lines of library class resolutions with a simple
>> !include directive. Such a patch is unreviewable, as I'd have no way of
>> carefully comparing the before-after state, let alone a way of *pointing
>> out* (in comments) where exactly a problem was.
>>
>> So I think such an include file would require a patch set, and the lib
>> class resolutions should be migrated in small *topical* steps. Such as:
>>
>> - introduce the DSC include file as empty
>> - add the !include directive to platform DSCs
>> - add a small set of libraries (with some topical coherence) to the
>> include file,
>> - remove the same set of resolutions from platform DSCs,
>> - repeat the last two steps until all "topics" have been covered.
>>
>> Thanks
>> Laszlo
>>
>>
>>>
>>>
>>> Thanks,
>>> Dandan
>>>>
>>>> Thanks
>>>> Liming
>>>>> Is there really not a better way to provide a 'default' resolution for
>>>>> a library class? Maybe a change to the .DEC format, so that the file
>>>>> which defines the library class can provide a resolution that is used
>>>>> if none is provided by the .DSC file?
>>>>>
>>>>>
>>>>>
>>>>>> Dandan Bi (35):
>>>>>> Drivers/ASIX: Consume RegisterFilterLibNull instance
>>>>>> Drivers/DisplayLink: Consume RegisterFilterLibNull instance
>>>>>> Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
>>>>>> Features/Debugging: Consume RegisterFilterLibNull instance
>>>>>> Features/Network: Consume RegisterFilterLibNull instance
>>>>>> Features/OutOfBandManagement: Consume RegisterFilterLibNull
>>>>> instance
>>>>>> Features/PowerManagement: Consume RegisterFilterLibNull
>> instance
>>>>>> Features/SystemInformation: Consume RegisterFilterLibNull instance
>>>>>> Features/UserInterface: Consume RegisterFilterLibNull instance
>>>>>> Platform/AMD: Consume RegisterFilterLibNull instance
>>>>>> Platform/ARM: Consume RegisterFilterLibNull instance
>>>>>> Platform/BeagleBoard: Consume RegisterFilterLibNull instance
>>>>>> Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
>>>>>> Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
>>>>>> Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
>>>>>> Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
>>>>>> Platform/LeMaker: Consume RegisterFilterLibNull instance
>>>>>> Platform/Qemu: Consume RegisterFilterLibNull instance
>>>>>> Platform/RaspberryPi: Consume RegisterFilterLibNull instance
>>>>>> Platform/RISC-V: Consume RegisterFilterLibNull instance
>>>>>> Platform/SiFive: Consume RegisterFilterLibNull instance
>>>>>> Platform/Socionext: Consume RegisterFilterLibNull instance
>>>>>> Platform/SoftIron: Consume RegisterFilterLibNull instance
>>>>>> Silicon/Hisilicon: Consume RegisterFilterLibNull instance
>>>>>> Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
>>>>>> Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
>>>>>> Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
>>>>>> Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
>>>>>> Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
>>>>>> Silicon/Marvell: Consume RegisterFilterLibNull instance
>>>>>> Silicon/NXP: Consume RegisterFilterLibNull instance
>>>>>> Silicon/Openmoko: Consume RegisterFilterLibNull instance
>>>>>> Silicon/RISC_V: Consume RegisterFilterLibNull instance
>>>>>> Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull
>> instance
>>>>>> Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
>>>>>>
>>>>>> Drivers/ASIX/Asix.dsc
>>>>> | 1 +
>>>>>> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1
>> +
>>>>>> Drivers/OptionRomPkg/OptionRomPkg.dsc
>>>>> | 3 ++-
>>>>>> .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc |
>> 3
>>>>> ++-
>>>>>> .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc
>> |
>>>> 3
>>>>> ++-
>>>>>> .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc
>> | 3
>>>>> ++-
>>>>>> .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc
>> |
>>>> 3
>>>>> ++-
>>>>>> .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc |
>> 3
>>>>> ++-
>>>>>> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
>> |
>>>> 3
>>>>> ++-
>>>>>> .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc
>> |
>>>> 3
>>>>> ++-
>>>>>> .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
>> | 3
>>>>> ++-
>>>>>> .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc
>> | 3
>>>>> ++-
>>>>>> .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3
>> ++-
>>>>>> .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc
>> | 3
>>>>> ++-
>>>>>> .../Include/VirtualKeyboardFeature.dsc
>> | 3
>>>>> ++-
>>>>>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>>>>> | 1 +
>>>>>> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
>>>>> | 1 +
>>>>>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
>>>>> | 1 +
>>>>>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
>> |
>>>>> 3 ++-
>>>>>> Platform/Intel/BoardModulePkg/BoardModulePkg.dsc
>> |
>>>>> 3 ++-
>>>>>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> | 3
>>>>> ++-
>>>>>> Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> |
>>>>> 1 +
>>>>>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> |
>>>>> 1 +
>>>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc |
>> 3
>>>>> ++-
>>>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc |
>> 3
>>>>> ++-
>>>>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc
>> |
>>>>> 1 +
>>>>>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc
>>>>> | 1 +
>>>>>> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
>> | 1
>>>>> +
>>>>>> Platform/RaspberryPi/RPi3/RPi3.dsc
>> |
>>>>> 3 ++-
>>>>>> Platform/RaspberryPi/RPi4/RPi4.dsc
>> |
>>>>> 3 ++-
>>>>>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>> |
>>>>> 1 +
>>>>>> .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>> |
>>>>> 1 +
>>>>>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>> | 1
>>>>> +
>>>>>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
>> | 1
>>>>> +
>>>>>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
>> | 1
>>>>> +
>>>>>> Silicon/Hisilicon/Hisilicon.dsc.inc | 1
>> +
>>>>>> Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
>>>>>> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3
>> ++-
>>>>>> Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3
>> ++-
>>>>>> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
>> |
>>>>> 3 ++-
>>>>>> Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
>>>>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> |
>>>>> 1 +
>>>>>> Silicon/NXP/NxpQoriqLs.dsc.inc
>> |
>>>>> 1 +
>>>>>> Silicon/Openmoko/Openmoko.dsc
>>>>> | 1 +
>>>>>> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc |
>> 1 +
>>>>>> Silicon/Synopsys/DesignWare/DesignWare.dsc
>> |
>>>>> 1 +
>>>>>> Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
>>>>> | 1 +
>>>>>> 47 files changed, 70 insertions(+), 23 deletions(-)
>>>>>>
>>>>>> --
>>>>>> 2.18.0.windows.1
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-18 13:25 ` Laszlo Ersek
@ 2021-03-18 13:42 ` Ni, Ray
2021-03-19 1:20 ` 回复: " gaoliming
0 siblings, 1 reply; 50+ messages in thread
From: Ni, Ray @ 2021-03-18 13:42 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com, gaoliming, Bi, Dandan,
ardb@kernel.org, 'Andrew Fish'
Cc: 'Leif Lindholm', Kinney, Michael D
I know that NetworkPkg already provided a case of DSC header file.
But NetworkPkg provides drivers and the dependent libs. Multiple instances of a single lib class are not common in NetworkPkg. So, for NetworkPkg, the consumer can simplify include the DSC header files.
But for MdePkg, there are so many lib instances for a single lib class. I am not sure how we create the DSC header file (which lib instance should be chosen).
Maybe having a DSC header file can avoid changing lots of code in each platform DSC *today*. But imagine that we look at the platform DSC file after couple years/months, we might be more frustrated about which lib instances are used in the platform.
Still, I am open to see what the final MdePkg DSC header will be like.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Thursday, March 18, 2021 9:25 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io; ardb@kernel.org;
> 'Andrew Fish' <afish@apple.com>
> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
>
> On 03/18/21 05:43, gaoliming wrote:
> > Laszlo and Dandan:
> >
> >> -----邮件原件-----
> >> 发件人: Laszlo Ersek <lersek@redhat.com>
> >> 发送时间: 2021年3月18日 1:08
> >> 收件人: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io;
> >> gaoliming@byosoft.com.cn; ardb@kernel.org; 'Andrew Fish'
> >> <afish@apple.com>
> >> 抄送: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> >> <michael.d.kinney@intel.com>
> >> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> >> RegisterFilterLibNull instance
> >>
> >> On 03/17/21 16:05, Bi, Dandan wrote:
> >>>> -----Original Message-----
> >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> >>>> gaoliming
> >>>> Sent: Wednesday, March 17, 2021 11:05 AM
> >>>> To: devel@edk2.groups.io; ardb@kernel.org; Bi, Dandan
> >>>> <dandan.bi@intel.com>; 'Laszlo Ersek' <lersek@redhat.com>; 'Andrew
> >> Fish'
> >>>> <afish@apple.com>
> >>>> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> >>>> <michael.d.kinney@intel.com>
> >>>> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> >>>> RegisterFilterLibNull instance
> >>>>
> >>>> Ard and Dandan:
> >>>>
> >>>>> -----邮件原件-----
> >>>>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> >>>> Biesheuvel
> >>>>> 发送时间: 2021年3月16日 23:01
> >>>>> 收件人: devel@edk2.groups.io; dandan.bi@intel.com; Laszlo Ersek
> >>>>> <lersek@redhat.com>; Andrew Fish <afish@apple.com>
> >>>>> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> >>>>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> >>>>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> >>>>> RegisterFilterLibNull instance
> >>>>>
> >>>>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com> wrote:
> >>>>>>
> >>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> >>>>>> RFC: https://edk2.groups.io/g/devel/message/72530
> >>>>>>
> >>>>>>
> >>>>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which
> >>>>>> will be consumed by IoLib and BaseLib.
> >>>>>>
> >>>>>> This is the following update in edk2-platforms repo for the change
> >>>>>> in edk2, which will add RegisterFilterLib dependency for IoLib and
> >>>>>> BaseLib to
> >>>>> filter/trace
> >>>>>> port IO/MMIO/MSR access.
> >>>>>> https://edk2.groups.io/g/devel/message/72754
> >>>>>>
> >>>>>> Cc: Leif Lindholm <leif@nuviainc.com>
> >>>>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >>>>>>
> >>>>>
> >>>>> It is a bit disappointing that we have to update every platform in
> >>>>> existence again to apply a change to a core module.
> >>>>>
> >>>>
> >>>> I suggest to add MdePkg.dsc.inc file to include the default library instance,
> >>>> and update all Platform DSC to include it. Then, for the future change, no
> >>>> change is required for platform DSC.
> >>>>
> >>>> Because this patch set updates every platform DSC, I suggest to introduce
> >>>> MdePkg.dsc.inc file in this patch set.
> >>>
> >>> Hi Liming,
> >>>
> >>> I agree that add MdePkg.dsc.inc file to include the default library instance
> >> and make it consumed by platform dsc will benefit future similar incompatible
> >> changes.
> >>> But I wonder to know whether we could do it in a separated task/topic, as
> >>> 1. It should be a code infrastructure design change/improvement in edk2.
> >>> 2. Personally I don't hope the new solution will have much impact on my
> >> current schedule, but it seems have.
> >>> And we may need to:
> >>> 1). Clarify the default library instances which should be added in
> >> MdePkg.dsc.inc
> >>> The library instances in MdePkg.dsc.inc should be generic enough to
> >> be widely included in platform dsc files.
> >>> 2). Update dsc files in edk2 and edk2-platforms repo to include
> >> MdePkg.dsc.inc and cleanup the default Lib instance in dsc files.
> >>
> >> (1) The file name should be "MdeLibs.dsc.inc", and it should be
> >> structured similarly "NetworkLibs.dsc.inc" -- no [LibraryClasses] header
> >> should be part of the file.
> >>
> > I agree.
> >
> >> (2) The introduction of "MdeLibs.dsc.inc" is a big task, in my opinion.
> >>
> > The full MdeLibs.dsc.inc is a big task. But, it should be a separate task.
> >
> > For this patch set, the first version MdeLibs.dsc.inc can be added. It only includes RegisterFilterLibNull library instance.
> > And, this patch set will update every platform DSC to include MdeLibs.dsc.inc.
> > The future incompatible change can update MdeLibs.dsc.inc only, and avoid the change in each platform DSC.
> > I would like to resolve the potential incompatible change by MdeLibs.dsc.inc on the first step.
>
> That's a good idea!
>
> Dandan is touching up a bunch of DSC files already, so we might even use
> this opportunity to introduce "MdeLibs.dsc.inc". And, at this time,
> "MdeLibs.dsc.inc" would be really small, and not hard to review for
> individual platforms -- in particular it wouldn't attempt to *replace*
> existent lib class resolutions. So indeed this looks like a nice
> approach to me.
>
> Thanks!
> Laszlo
>
> >
> > Thanks
> > Liming
> >> As I stated earlier, I wouldn't like to review a patch for OvmfPkg that
> >> replaces (say) 50-100 lines of library class resolutions with a simple
> >> !include directive. Such a patch is unreviewable, as I'd have no way of
> >> carefully comparing the before-after state, let alone a way of *pointing
> >> out* (in comments) where exactly a problem was.
> >>
> >> So I think such an include file would require a patch set, and the lib
> >> class resolutions should be migrated in small *topical* steps. Such as:
> >>
> >> - introduce the DSC include file as empty
> >> - add the !include directive to platform DSCs
> >> - add a small set of libraries (with some topical coherence) to the
> >> include file,
> >> - remove the same set of resolutions from platform DSCs,
> >> - repeat the last two steps until all "topics" have been covered.
> >>
> >> Thanks
> >> Laszlo
> >>
> >>
> >>>
> >>>
> >>> Thanks,
> >>> Dandan
> >>>>
> >>>> Thanks
> >>>> Liming
> >>>>> Is there really not a better way to provide a 'default' resolution for
> >>>>> a library class? Maybe a change to the .DEC format, so that the file
> >>>>> which defines the library class can provide a resolution that is used
> >>>>> if none is provided by the .DSC file?
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Dandan Bi (35):
> >>>>>> Drivers/ASIX: Consume RegisterFilterLibNull instance
> >>>>>> Drivers/DisplayLink: Consume RegisterFilterLibNull instance
> >>>>>> Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
> >>>>>> Features/Debugging: Consume RegisterFilterLibNull instance
> >>>>>> Features/Network: Consume RegisterFilterLibNull instance
> >>>>>> Features/OutOfBandManagement: Consume RegisterFilterLibNull
> >>>>> instance
> >>>>>> Features/PowerManagement: Consume RegisterFilterLibNull
> >> instance
> >>>>>> Features/SystemInformation: Consume RegisterFilterLibNull instance
> >>>>>> Features/UserInterface: Consume RegisterFilterLibNull instance
> >>>>>> Platform/AMD: Consume RegisterFilterLibNull instance
> >>>>>> Platform/ARM: Consume RegisterFilterLibNull instance
> >>>>>> Platform/BeagleBoard: Consume RegisterFilterLibNull instance
> >>>>>> Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
> >>>>>> Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
> >>>>>> Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
> >>>>>> Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
> >>>>>> Platform/LeMaker: Consume RegisterFilterLibNull instance
> >>>>>> Platform/Qemu: Consume RegisterFilterLibNull instance
> >>>>>> Platform/RaspberryPi: Consume RegisterFilterLibNull instance
> >>>>>> Platform/RISC-V: Consume RegisterFilterLibNull instance
> >>>>>> Platform/SiFive: Consume RegisterFilterLibNull instance
> >>>>>> Platform/Socionext: Consume RegisterFilterLibNull instance
> >>>>>> Platform/SoftIron: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/Hisilicon: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/Marvell: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/NXP: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/Openmoko: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/RISC_V: Consume RegisterFilterLibNull instance
> >>>>>> Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull
> >> instance
> >>>>>> Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
> >>>>>>
> >>>>>> Drivers/ASIX/Asix.dsc
> >>>>> | 1 +
> >>>>>> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1
> >> +
> >>>>>> Drivers/OptionRomPkg/OptionRomPkg.dsc
> >>>>> | 3 ++-
> >>>>>> .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc |
> >> 3
> >>>>> ++-
> >>>>>> .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc
> >> |
> >>>> 3
> >>>>> ++-
> >>>>>> .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc
> >> | 3
> >>>>> ++-
> >>>>>> .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc
> >> |
> >>>> 3
> >>>>> ++-
> >>>>>> .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc |
> >> 3
> >>>>> ++-
> >>>>>> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
> >> |
> >>>> 3
> >>>>> ++-
> >>>>>> .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc
> >> |
> >>>> 3
> >>>>> ++-
> >>>>>> .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
> >> | 3
> >>>>> ++-
> >>>>>> .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc
> >> | 3
> >>>>> ++-
> >>>>>> .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3
> >> ++-
> >>>>>> .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc
> >> | 3
> >>>>> ++-
> >>>>>> .../Include/VirtualKeyboardFeature.dsc
> >> | 3
> >>>>> ++-
> >>>>>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> >>>>> | 1 +
> >>>>>> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> >>>>> | 1 +
> >>>>>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> >>>>> | 1 +
> >>>>>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> >> |
> >>>>> 3 ++-
> >>>>>> Platform/Intel/BoardModulePkg/BoardModulePkg.dsc
> >> |
> >>>>> 3 ++-
> >>>>>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> >> | 3
> >>>>> ++-
> >>>>>> Platform/Intel/QuarkPlatformPkg/Quark.dsc
> >> |
> >>>>> 1 +
> >>>>>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> >> |
> >>>>> 1 +
> >>>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc |
> >> 3
> >>>>> ++-
> >>>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc |
> >> 3
> >>>>> ++-
> >>>>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc
> >> |
> >>>>> 1 +
> >>>>>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> >>>>> | 1 +
> >>>>>> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> >> | 1
> >>>>> +
> >>>>>> Platform/RaspberryPi/RPi3/RPi3.dsc
> >> |
> >>>>> 3 ++-
> >>>>>> Platform/RaspberryPi/RPi4/RPi4.dsc
> >> |
> >>>>> 3 ++-
> >>>>>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> >> |
> >>>>> 1 +
> >>>>>> .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> >> |
> >>>>> 1 +
> >>>>>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> >> | 1
> >>>>> +
> >>>>>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> >> | 1
> >>>>> +
> >>>>>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> >> | 1
> >>>>> +
> >>>>>> Silicon/Hisilicon/Hisilicon.dsc.inc | 1
> >> +
> >>>>>> Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 +
> >>>>>> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3
> >> ++-
> >>>>>> Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3
> >> ++-
> >>>>>> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
> >> |
> >>>>> 3 ++-
> >>>>>> Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 +
> >>>>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> >> |
> >>>>> 1 +
> >>>>>> Silicon/NXP/NxpQoriqLs.dsc.inc
> >> |
> >>>>> 1 +
> >>>>>> Silicon/Openmoko/Openmoko.dsc
> >>>>> | 1 +
> >>>>>> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc |
> >> 1 +
> >>>>>> Silicon/Synopsys/DesignWare/DesignWare.dsc
> >> |
> >>>>> 1 +
> >>>>>> Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
> >>>>> | 1 +
> >>>>>> 47 files changed, 70 insertions(+), 23 deletions(-)
> >>>>>>
> >>>>>> --
> >>>>>> 2.18.0.windows.1
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* 回复: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
2021-03-18 13:42 ` Ni, Ray
@ 2021-03-19 1:20 ` gaoliming
0 siblings, 0 replies; 50+ messages in thread
From: gaoliming @ 2021-03-19 1:20 UTC (permalink / raw)
To: devel, ray.ni, lersek, 'Bi, Dandan', ardb,
'Andrew Fish'
Cc: 'Leif Lindholm', 'Kinney, Michael D'
Ray:
For now, this one MdeLibs.dsc.inc is introduced to mainly resolve the future incompatible change.
For long term, this one MdeLibs.dsc.inc includes the default library instance from MdePkg. The platform DSC can still specify its library instance after include MdeLibs.dsc.inc.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ni, Ray
> 发送时间: 2021年3月18日 21:42
> 收件人: devel@edk2.groups.io; lersek@redhat.com; gaoliming
> <gaoliming@byosoft.com.cn>; Bi, Dandan <dandan.bi@intel.com>;
> ardb@kernel.org; 'Andrew Fish' <afish@apple.com>
> 抄送: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 主题: Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> RegisterFilterLibNull instance
>
> I know that NetworkPkg already provided a case of DSC header file.
> But NetworkPkg provides drivers and the dependent libs. Multiple instances
> of a single lib class are not common in NetworkPkg. So, for NetworkPkg, the
> consumer can simplify include the DSC header files.
>
>
> But for MdePkg, there are so many lib instances for a single lib class. I am not
> sure how we create the DSC header file (which lib instance should be chosen).
>
> Maybe having a DSC header file can avoid changing lots of code in each
> platform DSC *today*. But imagine that we look at the platform DSC file after
> couple years/months, we might be more frustrated about which lib instances
> are used in the platform.
>
> Still, I am open to see what the final MdePkg DSC header will be like.
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> > Sent: Thursday, March 18, 2021 9:25 PM
> > To: gaoliming <gaoliming@byosoft.com.cn>; Bi, Dandan
> <dandan.bi@intel.com>; devel@edk2.groups.io; ardb@kernel.org;
> > 'Andrew Fish' <afish@apple.com>
> > Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> > Subject: Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> RegisterFilterLibNull instance
> >
> > On 03/18/21 05:43, gaoliming wrote:
> > > Laszlo and Dandan:
> > >
> > >> -----邮件原件-----
> > >> 发件人: Laszlo Ersek <lersek@redhat.com>
> > >> 发送时间: 2021年3月18日 1:08
> > >> 收件人: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io;
> > >> gaoliming@byosoft.com.cn; ardb@kernel.org; 'Andrew Fish'
> > >> <afish@apple.com>
> > >> 抄送: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> > >> <michael.d.kinney@intel.com>
> > >> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> > >> RegisterFilterLibNull instance
> > >>
> > >> On 03/17/21 16:05, Bi, Dandan wrote:
> > >>>> -----Original Message-----
> > >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > >>>> gaoliming
> > >>>> Sent: Wednesday, March 17, 2021 11:05 AM
> > >>>> To: devel@edk2.groups.io; ardb@kernel.org; Bi, Dandan
> > >>>> <dandan.bi@intel.com>; 'Laszlo Ersek' <lersek@redhat.com>;
> 'Andrew
> > >> Fish'
> > >>>> <afish@apple.com>
> > >>>> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> > >>>> <michael.d.kinney@intel.com>
> > >>>> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> > >>>> RegisterFilterLibNull instance
> > >>>>
> > >>>> Ard and Dandan:
> > >>>>
> > >>>>> -----邮件原件-----
> > >>>>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> > >>>> Biesheuvel
> > >>>>> 发送时间: 2021年3月16日 23:01
> > >>>>> 收件人: devel@edk2.groups.io; dandan.bi@intel.com; Laszlo Ersek
> > >>>>> <lersek@redhat.com>; Andrew Fish <afish@apple.com>
> > >>>>> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> > >>>>> <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> > >>>>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> > >>>>> RegisterFilterLibNull instance
> > >>>>>
> > >>>>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi@intel.com>
> wrote:
> > >>>>>>
> > >>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> > >>>>>> RFC: https://edk2.groups.io/g/devel/message/72530
> > >>>>>>
> > >>>>>>
> > >>>>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which
> > >>>>>> will be consumed by IoLib and BaseLib.
> > >>>>>>
> > >>>>>> This is the following update in edk2-platforms repo for the change
> > >>>>>> in edk2, which will add RegisterFilterLib dependency for IoLib and
> > >>>>>> BaseLib to
> > >>>>> filter/trace
> > >>>>>> port IO/MMIO/MSR access.
> > >>>>>> https://edk2.groups.io/g/devel/message/72754
> > >>>>>>
> > >>>>>> Cc: Leif Lindholm <leif@nuviainc.com>
> > >>>>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >>>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >>>>>>
> > >>>>>
> > >>>>> It is a bit disappointing that we have to update every platform in
> > >>>>> existence again to apply a change to a core module.
> > >>>>>
> > >>>>
> > >>>> I suggest to add MdePkg.dsc.inc file to include the default library
> instance,
> > >>>> and update all Platform DSC to include it. Then, for the future change,
> no
> > >>>> change is required for platform DSC.
> > >>>>
> > >>>> Because this patch set updates every platform DSC, I suggest to
> introduce
> > >>>> MdePkg.dsc.inc file in this patch set.
> > >>>
> > >>> Hi Liming,
> > >>>
> > >>> I agree that add MdePkg.dsc.inc file to include the default library
> instance
> > >> and make it consumed by platform dsc will benefit future similar
> incompatible
> > >> changes.
> > >>> But I wonder to know whether we could do it in a separated task/topic,
> as
> > >>> 1. It should be a code infrastructure design change/improvement in
> edk2.
> > >>> 2. Personally I don't hope the new solution will have much impact on
> my
> > >> current schedule, but it seems have.
> > >>> And we may need to:
> > >>> 1). Clarify the default library instances which should be added in
> > >> MdePkg.dsc.inc
> > >>> The library instances in MdePkg.dsc.inc should be generic enough
> to
> > >> be widely included in platform dsc files.
> > >>> 2). Update dsc files in edk2 and edk2-platforms repo to include
> > >> MdePkg.dsc.inc and cleanup the default Lib instance in dsc files.
> > >>
> > >> (1) The file name should be "MdeLibs.dsc.inc", and it should be
> > >> structured similarly "NetworkLibs.dsc.inc" -- no [LibraryClasses] header
> > >> should be part of the file.
> > >>
> > > I agree.
> > >
> > >> (2) The introduction of "MdeLibs.dsc.inc" is a big task, in my opinion.
> > >>
> > > The full MdeLibs.dsc.inc is a big task. But, it should be a separate task.
> > >
> > > For this patch set, the first version MdeLibs.dsc.inc can be added. It only
> includes RegisterFilterLibNull library instance.
> > > And, this patch set will update every platform DSC to include
> MdeLibs.dsc.inc.
> > > The future incompatible change can update MdeLibs.dsc.inc only, and
> avoid the change in each platform DSC.
> > > I would like to resolve the potential incompatible change by
> MdeLibs.dsc.inc on the first step.
> >
> > That's a good idea!
> >
> > Dandan is touching up a bunch of DSC files already, so we might even use
> > this opportunity to introduce "MdeLibs.dsc.inc". And, at this time,
> > "MdeLibs.dsc.inc" would be really small, and not hard to review for
> > individual platforms -- in particular it wouldn't attempt to *replace*
> > existent lib class resolutions. So indeed this looks like a nice
> > approach to me.
> >
> > Thanks!
> > Laszlo
> >
> > >
> > > Thanks
> > > Liming
> > >> As I stated earlier, I wouldn't like to review a patch for OvmfPkg that
> > >> replaces (say) 50-100 lines of library class resolutions with a simple
> > >> !include directive. Such a patch is unreviewable, as I'd have no way of
> > >> carefully comparing the before-after state, let alone a way of *pointing
> > >> out* (in comments) where exactly a problem was.
> > >>
> > >> So I think such an include file would require a patch set, and the lib
> > >> class resolutions should be migrated in small *topical* steps. Such as:
> > >>
> > >> - introduce the DSC include file as empty
> > >> - add the !include directive to platform DSCs
> > >> - add a small set of libraries (with some topical coherence) to the
> > >> include file,
> > >> - remove the same set of resolutions from platform DSCs,
> > >> - repeat the last two steps until all "topics" have been covered.
> > >>
> > >> Thanks
> > >> Laszlo
> > >>
> > >>
> > >>>
> > >>>
> > >>> Thanks,
> > >>> Dandan
> > >>>>
> > >>>> Thanks
> > >>>> Liming
> > >>>>> Is there really not a better way to provide a 'default' resolution for
> > >>>>> a library class? Maybe a change to the .DEC format, so that the file
> > >>>>> which defines the library class can provide a resolution that is used
> > >>>>> if none is provided by the .DSC file?
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>> Dandan Bi (35):
> > >>>>>> Drivers/ASIX: Consume RegisterFilterLibNull instance
> > >>>>>> Drivers/DisplayLink: Consume RegisterFilterLibNull instance
> > >>>>>> Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
> > >>>>>> Features/Debugging: Consume RegisterFilterLibNull instance
> > >>>>>> Features/Network: Consume RegisterFilterLibNull instance
> > >>>>>> Features/OutOfBandManagement: Consume
> RegisterFilterLibNull
> > >>>>> instance
> > >>>>>> Features/PowerManagement: Consume RegisterFilterLibNull
> > >> instance
> > >>>>>> Features/SystemInformation: Consume RegisterFilterLibNull
> instance
> > >>>>>> Features/UserInterface: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/AMD: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/ARM: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/BeagleBoard: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/BoardModulePkg: Consume RegisterFilterLibNull
> instance
> > >>>>>> Platform/MinPlatformPkg: Consume RegisterFilterLibNull
> instance
> > >>>>>> Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull
> instance
> > >>>>>> Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull
> instance
> > >>>>>> Platform/LeMaker: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/Qemu: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/RaspberryPi: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/RISC-V: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/SiFive: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/Socionext: Consume RegisterFilterLibNull instance
> > >>>>>> Platform/SoftIron: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/Hisilicon: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull
> instance
> > >>>>>> Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull
> instance
> > >>>>>> Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull
> instance
> > >>>>>> Silicon/Marvell: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/NXP: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/Openmoko: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/RISC_V: Consume RegisterFilterLibNull instance
> > >>>>>> Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull
> > >> instance
> > >>>>>> Silicon/TexasInstruments: Consume RegisterFilterLibNull
> instance
> > >>>>>>
> > >>>>>> Drivers/ASIX/Asix.dsc
> > >>>>> | 1 +
> > >>>>>> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc
> | 1
> > >> +
> > >>>>>> Drivers/OptionRomPkg/OptionRomPkg.dsc
> > >>>>> | 3 ++-
> > >>>>>> .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.d
> sc |
> > >> 3
> > >>>>> ++-
> > >>>>>> .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature
> .dsc
> > >> |
> > >>>> 3
> > >>>>> ++-
> > >>>>>> .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.ds
> c
> > >> | 3
> > >>>>> ++-
> > >>>>>> .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature
> .dsc
> > >> |
> > >>>> 3
> > >>>>> ++-
> > >>>>>> .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.d
> sc |
> > >> 3
> > >>>>> ++-
> > >>>>>> .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature
> .dsc
> > >> |
> > >>>> 3
> > >>>>> ++-
> > >>>>>> .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature
> .dsc
> > >> |
> > >>>> 3
> > >>>>> ++-
> > >>>>>> .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.ds
> c
> > >> | 3
> > >>>>> ++-
> > >>>>>> .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc
> > >> | 3
> > >>>>> ++-
> > >>>>>> .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> | 3
> > >> ++-
> > >>>>>> .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc
> > >> | 3
> > >>>>> ++-
> > >>>>>> .../Include/VirtualKeyboardFeature.dsc
> > >> | 3
> > >>>>> ++-
> > >>>>>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > >>>>> | 1 +
> > >>>>>> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > >>>>> | 1 +
> > >>>>>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> > >>>>> | 1 +
> > >>>>>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > >> |
> > >>>>> 3 ++-
> > >>>>>> Platform/Intel/BoardModulePkg/BoardModulePkg.dsc
> > >> |
> > >>>>> 3 ++-
> > >>>>>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > >> | 3
> > >>>>> ++-
> > >>>>>> Platform/Intel/QuarkPlatformPkg/Quark.dsc
> > >> |
> > >>>>> 1 +
> > >>>>>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> > >> |
> > >>>>> 1 +
> > >>>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> |
> > >> 3
> > >>>>> ++-
> > >>>>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> |
> > >> 3
> > >>>>> ++-
> > >>>>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc
> > >> |
> > >>>>> 1 +
> > >>>>>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> > >>>>> | 1 +
> > >>>>>> Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> > >> | 1
> > >>>>> +
> > >>>>>> Platform/RaspberryPi/RPi3/RPi3.dsc
> > >> |
> > >>>>> 3 ++-
> > >>>>>> Platform/RaspberryPi/RPi4/RPi4.dsc
> > >> |
> > >>>>> 3 ++-
> > >>>>>>
> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> > >> |
> > >>>>> 1 +
> > >>>>>> .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> > >> |
> > >>>>> 1 +
> > >>>>>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> > >> | 1
> > >>>>> +
> > >>>>>>
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> > >> | 1
> > >>>>> +
> > >>>>>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> > >> | 1
> > >>>>> +
> > >>>>>> Silicon/Hisilicon/Hisilicon.dsc.inc
> | 1
> > >> +
> > >>>>>> Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc |
> 1 +
> > >>>>>> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc |
> 3
> > >> ++-
> > >>>>>> Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> | 3
> > >> ++-
> > >>>>>> Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc
> > >> |
> > >>>>> 3 ++-
> > >>>>>> Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1
> +
> > >>>>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > >> |
> > >>>>> 1 +
> > >>>>>> Silicon/NXP/NxpQoriqLs.dsc.inc
> > >> |
> > >>>>> 1 +
> > >>>>>> Silicon/Openmoko/Openmoko.dsc
> > >>>>> | 1 +
> > >>>>>> Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc
> |
> > >> 1 +
> > >>>>>> Silicon/Synopsys/DesignWare/DesignWare.dsc
> > >> |
> > >>>>> 1 +
> > >>>>>> Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
> > >>>>> | 1 +
> > >>>>>> 47 files changed, 70 insertions(+), 23 deletions(-)
> > >>>>>>
> > >>>>>> --
> > >>>>>> 2.18.0.windows.1
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
end of thread, other threads:[~2021-03-19 1:21 UTC | newest]
Thread overview: 50+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-16 14:53 [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 01/35] Drivers/ASIX: " Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 02/35] Drivers/DisplayLink: " Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 03/35] Drivers/OptionRomPkg: " Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 04/35] Features/Debugging: " Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 05/35] Features/Network: " Dandan Bi
2021-03-16 14:53 ` [edk2-platforms] [patch 06/35] Features/OutOfBandManagement: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 07/35] Features/PowerManagement: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 08/35] Features/SystemInformation: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 09/35] Features/UserInterface: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 10/35] Platform/AMD: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 11/35] Platform/ARM: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 12/35] Platform/BeagleBoard: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 13/35] Platform/BoardModulePkg: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 14/35] Platform/MinPlatformPkg: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: " Dandan Bi
2021-03-16 15:04 ` Steele, Kelly
2021-03-16 14:54 ` [edk2-platforms] [patch 16/35] Platform/Vlv2TbltDevicePkg: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 17/35] Platform/LeMaker: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 18/35] Platform/Qemu: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 19/35] Platform/RaspberryPi: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 20/35] Platform/RISC-V: " Dandan Bi
2021-03-17 8:14 ` Abner Chang
2021-03-16 14:54 ` [edk2-platforms] [patch 21/35] Platform/SiFive: " Dandan Bi
2021-03-17 8:14 ` Abner Chang
2021-03-16 14:54 ` [edk2-platforms] [patch 22/35] Platform/Socionext: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 23/35] Platform/SoftIron: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 24/35] Silicon/Hisilicon: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 25/35] Silicon/CoffeelakeSiliconPkg: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 26/35] Silicon/IntelSiliconPkg: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 27/35] Silicon/KabylakeSiliconPkg: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: " Dandan Bi
2021-03-16 15:05 ` Steele, Kelly
2021-03-16 14:54 ` [edk2-platforms] [patch 29/35] Silicon/TigerlakeSiliconPkg: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 30/35] Silicon/Marvell: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 31/35] Silicon/NXP: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 32/35] Silicon/Openmoko: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 33/35] Silicon/RISC_V: " Dandan Bi
2021-03-17 8:14 ` Abner Chang
2021-03-16 14:54 ` [edk2-platforms] [patch 34/35] Silicon/Synopsys/DesignWare: " Dandan Bi
2021-03-16 14:54 ` [edk2-platforms] [patch 35/35] Silicon/TexasInstruments: " Dandan Bi
2021-03-16 15:00 ` [edk2-devel] [edk2-platforms] [patch 00/35] " Ard Biesheuvel
2021-03-16 16:23 ` Laszlo Ersek
2021-03-17 3:04 ` 回复: " gaoliming
2021-03-17 15:05 ` Dandan Bi
2021-03-17 17:08 ` Laszlo Ersek
2021-03-18 4:43 ` 回复: " gaoliming
2021-03-18 13:25 ` Laszlo Ersek
2021-03-18 13:42 ` Ni, Ray
2021-03-19 1:20 ` 回复: " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox