From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.2654.1616462139305883014 for ; Mon, 22 Mar 2021 18:15:39 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) IronPort-SDR: 3xn5fqpMz54QT9xBRH2fHtjUsY6kXx3WYLROCWqY39Mx16xwEGPBBQ2JC4hxQs3ExGVIISm1Kc pUCmBkjOohdA== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="210455645" X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="210455645" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 18:15:38 -0700 IronPort-SDR: 5xYU9ih2wIyfxql2JGk4U6/HdznZ6fxs3lJgvgGVugr3YlDoVdHGXadhwLOR9ToG+maEDwYaRw TDVCJ0+zwXjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="390687434" Received: from ray-dev.ccr.corp.intel.com ([10.239.158.87]) by orsmga002.jf.intel.com with ESMTP; 22 Mar 2021 18:15:36 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Eric Dong , Laszlo Ersek , Rahul Kumar Subject: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments Date: Tue, 23 Mar 2021 09:15:27 +0800 Message-Id: <20210323011527.437-1-ray.ni@intel.com> X-Mailer: git-send-email 2.27.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The comments in PiSmmCommunicationPei.c describe the whole memory layout of the SMRAM regarding the SMM communication. But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table removed the code that produces the ACPI Table. This change updates the accordingly comments. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- .../PiSmmCommunication/PiSmmCommunicationPei.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCp= uPkg/PiSmmCommunication/PiSmmCommunicationPei.c index 68e5003ad4..110165b20b 100644 --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c @@ -1,7 +1,7 @@ /** @file=0D PiSmmCommunication PEI Driver.=0D =0D -Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
=0D +Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D @@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent +----------------------------------+<--=0D | EFI_SMM_COMMUNICATION_CONTEXT |=0D | SwSmiNumber | <- SMRAM=0D - | BufferPtrAddress |----------------=0D - +----------------------------------+ |=0D - |=0D - +----------------------------------+ |=0D - | EFI_SMM_COMMUNICATION_ACPI_TABLE | |=0D - | SwSmiNumber | <- AcpiTable |=0D - | BufferPtrAddress |--- |=0D - +----------------------------------+ | |=0D - | |=0D - +----------------------------------+<---------------=0D + | BufferPtrAddress |---=0D + +----------------------------------+ |=0D + |=0D + +----------------------------------+<--=0D | Communication Buffer Pointer | <- AcpiNvs=0D +----------------------------------+---=0D |=0D --=20 2.27.0.windows.1