From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mx.groups.io with SMTP id smtpd.web08.1292.1617156988309078484 for ; Tue, 30 Mar 2021 19:16:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=QmgD9u7Z; spf=pass (domain: nuviainc.com, ip: 209.85.210.45, mailfrom: rebecca@nuviainc.com) Received: by mail-ot1-f45.google.com with SMTP id g8-20020a9d6c480000b02901b65ca2432cso17548700otq.3 for ; Tue, 30 Mar 2021 19:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IhmR8tFhYKRrKs/jZMuhcJzIBKvwv8QeVOfiRiK/NDg=; b=QmgD9u7ZcR7y1F+Yv5u5lKlsn/oLK4j5fbYKFvXJesOXUWT0ftv44/NfM1MmRPsWXv i9jUElfiSJISEq/OGEJ1V4GUZ/GRw+UBAUqDigE5q3hYkgVH0pJ5hOtmomk5Aa4l1aAQ DQfvK/yD1tndIk9cmayooj6KX/tuXFLMMKYQWLxMh/5bhLCYz7zP2XZDmq9YHNjwbFk5 65f+p4mJFg0UCDeYBrcSf0BSehkXMiSySnnDVyl4IwVMSy2y/shcXJaOHCFVPvMCu96s p6iNC5tWCPXQ+0M0OnaxxaOYraVAYr11sjYxLFiqK8+AQNOZ7n+7UwjM8h7XsnEWvobI j3lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IhmR8tFhYKRrKs/jZMuhcJzIBKvwv8QeVOfiRiK/NDg=; b=ndBqRYiBhmCb+gujTwxtpTfv+wEavFc8n0cWCo9yhQUtMrZtcUqPmZBDLHsnWyEAQj 0pDpLF/s8ogkS4dWkr1hQ3QgtLnjSYLYwhluqM5nDi3rj//FLofY73+adniJhUAAQvxM YkIw8jUpKq9cCURTPDAmRZA8nRmWEWJNQe4hdlCAcw6HnjxsdrnY02W5suZ+trdGu4ts SZlUfrNx2Vn41Ei1HeZbMLVmEh7mgYeIRoCGPSwXj5RNFS5eCMBVZM3IJdDNoPgf8zPh 3xyS7KUEiIsUWv/dW7BOyO2bR7N7FYtP5b4zl1iqiqw/5uIYOhG2NIJiDEHEdwS8+IJI wSiQ== X-Gm-Message-State: AOAM53369DhbV13r1M0mEfSpAR3gH6ey0HfjqP8JdAO76yDwEtvu+nXS NP7vSxQKiD33+U7u0J4X77HGw3YS+IY2FoI7ikzsQApAoHrcdl/2q543GLVCtMf4A4g47GkxmuI cWk9HLqH15922R2wRn76jLIPibPZWfA0iK+ZF9p8i1/JQJfbwIH7I6ITiORxzRl7Ch2bDrQ== X-Google-Smtp-Source: ABdhPJy3txurvX/o8t8x2szJDmgELPS3+R1W8asode8aapQ5g/wGua+ko6fZRzphKalZCNw7DBnXTw== X-Received: by 2002:a05:6830:210e:: with SMTP id i14mr705443otc.229.1617156987431; Tue, 30 Mar 2021 19:16:27 -0700 (PDT) Return-Path: Received: from cube.nuviainc.com (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id u11sm199996oif.10.2021.03.30.19.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 19:16:27 -0700 (PDT) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel Subject: [PATCH 1/5] ArmPkg: Allow platforms to override PCI supported state in SmbiosMiscDxe Date: Tue, 30 Mar 2021 20:16:15 -0600 Message-Id: <20210331021619.19761-2-rebecca@nuviainc.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210331021619.19761-1-rebecca@nuviainc.com> References: <20210331021619.19761-1-rebecca@nuviainc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Not all platforms support PCI, so introduce a PCD to allow platforms to specify whether they support it. Signed-off-by: Rebecca Cran --- ArmPkg/ArmPkg.dec | 1 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index a8a22c649ff8..51ac2191c85a 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -125,6 +125,7 @@ [PcdsFixedAtBuild.common] # # SMBIOS PCDs # + gArmTokenSpaceGuid.PcdPlatformSupportsPCI|TRUE|BOOLEAN|0x30000052 gArmTokenSpaceGuid.PcdSystemProductName|L""|VOID*|0x30000053 gArmTokenSpaceGuid.PcdSystemVersion|L""|VOID*|0x30000054 gArmTokenSpaceGuid.PcdBaseBoardManufacturer|L""|VOID*|0x30000055 diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf index 60d8fe31c219..ebc4c99ac436 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf @@ -71,6 +71,7 @@ [Pcd] gArmTokenSpaceGuid.PcdFdSize gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString + gArmTokenSpaceGuid.PcdPlatformSupportsPCI gArmTokenSpaceGuid.PcdSystemBiosRelease gArmTokenSpaceGuid.PcdEmbeddedControllerFirmwareRelease gArmTokenSpaceGuid.PcdSystemProductName diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c index 5aea32521bd3..a06f814aeb7c 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include @@ -264,6 +265,9 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) UnicodeStrToAsciiStrS (Version, StrStart, VerStrLen + 1); StrStart += VerStrLen + 1; UnicodeStrToAsciiStrS (ReleaseDate, StrStart, DateStrLen + 1); + + SmbiosRecord->BiosCharacteristics.PciIsSupported = FixedPcdGetBool (PcdPlatformSupportsPCI); + // // Now we have got the full smbios record, call smbios protocol to add this record. // -- 2.26.2