[PATCH v1 1/1] DynamicTablesPkg: Fix generated _HID value for SBSA

[PATCH v1 1/1] DynamicTablesPkg: Fix generated _HID value for SBSA

[PierreGondois]

From: Pierre Gondois <Pierre.Gondois@arm.com>

SSDT tables describing an SBSA compatible serial port receive an '_HID'
value of 'ARMH0011'. This value represents a PL011 serial port.

This patch:
 - Generates an 'ARMHB000' instead
 - References the 'ACPI for Arm Components 1.0 - 2020' document
   specifying the '_HID' values to use.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1699_Fix_serial_port_hid_v1

 .../Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
index 3c4356097c3b..f5e4a5a99f49 100644
--- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
+++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
@@ -8,6 +8,7 @@
   @par Reference(s):
   - Arm Server Base Boot Requirements (SBBR), s4.2.1.8 "SPCR".
   - Microsoft Debug Port Table 2 (DBG2) Specification - December 10, 2015.
+  - ACPI for Arm Components 1.0 - 2020
 **/
 
 #include <IndustryStandard/DebugPort2Table.h>
@@ -165,7 +166,7 @@ FixupIds (
     case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART:
     case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X:
     {
-      HidString = "ARMH0011";
+      HidString = "ARMHB000";
       CidString = "";
       break;
     }
-- 
2.17.1

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix generated _HID value for SBSA

[Sami Mujawar]

Hi Pierre,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 07/04/2021, 15:44, "devel@edk2.groups.io on behalf of PierreGondois via groups.io" <devel@edk2.groups.io on behalf of pierre.gondois=arm.com@groups.io> wrote:

    From: Pierre Gondois <Pierre.Gondois@arm.com>

    SSDT tables describing an SBSA compatible serial port receive an '_HID'
    value of 'ARMH0011'. This value represents a PL011 serial port.

    This patch:
     - Generates an 'ARMHB000' instead
     - References the 'ACPI for Arm Components 1.0 - 2020' document
       specifying the '_HID' values to use.

    Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
    ---
    The changes can be seen at: https://github.com/PierreARM/edk2/tree/1699_Fix_serial_port_hid_v1

     .../Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c     | 3 ++-
     1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
    index 3c4356097c3b..f5e4a5a99f49 100644
    --- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
    +++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
    @@ -8,6 +8,7 @@
       @par Reference(s):
       - Arm Server Base Boot Requirements (SBBR), s4.2.1.8 "SPCR".
       - Microsoft Debug Port Table 2 (DBG2) Specification - December 10, 2015.
    +  - ACPI for Arm Components 1.0 - 2020
     **/

     #include <IndustryStandard/DebugPort2Table.h>
    @@ -165,7 +166,7 @@ FixupIds (
         case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART:
         case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X:
         {
    -      HidString = "ARMH0011";
    +      HidString = "ARMHB000";
           CidString = "";
           break;
         }
    --
    2.17.1



    



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.