From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.8221.1617806631096004084 for ; Wed, 07 Apr 2021 07:43:51 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 979C61424; Wed, 7 Apr 2021 07:43:49 -0700 (PDT) Received: from e120189.arm.com (unknown [10.57.54.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7546E3F792; Wed, 7 Apr 2021 07:43:48 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io, Sami.Mujawar@arm.com, Alexei.Fedorov@arm.com Subject: [PATCH v1 1/1] DynamicTablesPkg: Fix generated _HID value for SBSA Date: Wed, 7 Apr 2021 15:43:39 +0100 Message-Id: <20210407144339.16199-1-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 From: Pierre Gondois SSDT tables describing an SBSA compatible serial port receive an '_HID' value of 'ARMH0011'. This value represents a PL011 serial port. This patch: - Generates an 'ARMHB000' instead - References the 'ACPI for Arm Components 1.0 - 2020' document specifying the '_HID' values to use. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1699_Fix_serial_port_hid_v1 .../Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c index 3c4356097c3b..f5e4a5a99f49 100644 --- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c +++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c @@ -8,6 +8,7 @@ @par Reference(s): - Arm Server Base Boot Requirements (SBBR), s4.2.1.8 "SPCR". - Microsoft Debug Port Table 2 (DBG2) Specification - December 10, 2015. + - ACPI for Arm Components 1.0 - 2020 **/ #include @@ -165,7 +166,7 @@ FixupIds ( case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART: case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X: { - HidString = "ARMH0011"; + HidString = "ARMHB000"; CidString = ""; break; } -- 2.17.1