From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.293.1617917092504192057 for ; Thu, 08 Apr 2021 14:24:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=UEh4ilk+; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id BA07820B5680; Thu, 8 Apr 2021 14:24:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BA07820B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1617917091; bh=uk04vHhufXTp9PGda+tlmkmckJKfgwopi9xUrZSZYn0=; h=From:To:Cc:Subject:Date:From; b=UEh4ilk+HsqZkCfjgpeYvg/v/tWMJrCNlie7cC9pan40MjOV1yoA7WDLc/xWneFu+ PzWQ2cro1zaCrJOHME7qyizkaO/dIUsCTlQJVzQHfaBqrGUKfnal3/4ABPvKlicQNm Pg4bIIbgr85n0HV4IK5pd9QJ58q1lQ0ssT7kh5QU= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability Date: Thu, 8 Apr 2021 14:24:31 -0700 Message-Id: <20210408212433.632-1-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki This series makes some simple changes to the organization of BoardAcpiEnableLibNull and BoardAcpiTableLibNull to better align the library instances with patterns typically used so they are easier to integrate into platforms. The following issues are resolved: 1. Sharing of a directory with another unrelated library instance. 2. The directory name "BoardAcpiLibNull" is not directly related to either library instance name in the directory. 3. The library instances have unnecessary dependencies. 4. The BASE_NAME does not indicate the library instance is the NULL instance. 5. The C source file names do not match the INF file name making finding the C source by search more cumbersome than needed. V2 changes: 1. Remove Base.h from BoardAcpiEnableLibNull.c and BoardAcpiTableLibNull.c Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki Michael Kubacki (2): MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability MinPlatformPkg/BoardAcpiTableLibNull: Improve maintainability Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEn= ableLib.c =3D> BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} | 3 --- Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTa= bleLib.c =3D> BoardAcpiTableLibNull/BoardAcpiTableLibNull.c} | 3 --- Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D> BoardA= cpiEnableLibNull}/BoardAcpiEnableLibNull.inf | 12 ++++= -------- Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D> BoardA= cpiTableLibNull}/BoardAcpiTableLibNull.inf | 12 ++++= -------- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc = | 8 ++++--= -- 5 files changed, 12 insertions(+), 26 deletions(-) rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/Boar= dAcpiEnableLib.c =3D> BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} (7= 3%) rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/Boar= dAcpiTableLib.c =3D> BoardAcpiTableLibNull/BoardAcpiTableLibNull.c} (73%) rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D>= BoardAcpiEnableLibNull}/BoardAcpiEnableLibNull.inf (67%) rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D>= BoardAcpiTableLibNull}/BoardAcpiTableLibNull.inf (67%) --=20 2.28.0.windows.1