public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability
@ 2021-04-08 21:24 Michael Kubacki
  2021-04-08 21:24 ` [edk2-platforms][PATCH v2 1/2] MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability Michael Kubacki
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Michael Kubacki @ 2021-04-08 21:24 UTC (permalink / raw)
  To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong

From: Michael Kubacki <michael.kubacki@microsoft.com>

This series makes some simple changes to the organization of
BoardAcpiEnableLibNull and BoardAcpiTableLibNull to better align
the library instances with patterns typically used so they are
easier to integrate into platforms.

The following issues are resolved:
1. Sharing of a directory with another unrelated library instance.
2. The directory name "BoardAcpiLibNull" is not directly related to
   either library instance name in the directory.
3. The library instances have unnecessary dependencies.
4. The BASE_NAME does not indicate the library instance is the NULL
   instance.
5. The C source file names do not match the INF file name making
   finding the C source by search more cumbersome than needed.

V2 changes:
1. Remove Base.h from BoardAcpiEnableLibNull.c and
   BoardAcpiTableLibNull.c

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (2):
  MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability
  MinPlatformPkg/BoardAcpiTableLibNull: Improve maintainability

 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEnableLib.c => BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} |  3 ---
 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTableLib.c => BoardAcpiTableLibNull/BoardAcpiTableLibNull.c}    |  3 ---
 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiEnableLibNull}/BoardAcpiEnableLibNull.inf                    | 12 ++++--------
 Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiTableLibNull}/BoardAcpiTableLibNull.inf                      | 12 ++++--------
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc                                                                                      |  8 ++++----
 5 files changed, 12 insertions(+), 26 deletions(-)
 rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEnableLib.c => BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} (73%)
 rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTableLib.c => BoardAcpiTableLibNull/BoardAcpiTableLibNull.c} (73%)
 rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiEnableLibNull}/BoardAcpiEnableLibNull.inf (67%)
 rename Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull => BoardAcpiTableLibNull}/BoardAcpiTableLibNull.inf (67%)

-- 
2.28.0.windows.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-09 21:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-08 21:24 [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability Michael Kubacki
2021-04-08 21:24 ` [edk2-platforms][PATCH v2 1/2] MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability Michael Kubacki
2021-04-08 21:24 ` [edk2-platforms][PATCH v2 2/2] MinPlatformPkg/BoardAcpiTableLibNull: " Michael Kubacki
2021-04-09 21:19 ` [edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability Nate DeSimone
2021-04-09 21:50 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox