From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mx.groups.io with SMTP id smtpd.web10.410.1617992730227272619 for ; Fri, 09 Apr 2021 11:25:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@corthon-com.20150623.gappssmtp.com header.s=20150623 header.b=JzKg6DRp; spf=none, err=permanent DNS error (domain: corthon.com, ip: 209.85.216.47, mailfrom: bret@corthon.com) Received: by mail-pj1-f47.google.com with SMTP id x21-20020a17090a5315b029012c4a622e4aso3619117pjh.2 for ; Fri, 09 Apr 2021 11:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corthon-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XpMVdwpeqpeITY25PfwxcLJIP681b3jEqfL5jeWDhJY=; b=JzKg6DRpH7npLlZaoYtZXmZb0guCr+bQh7Lyd9sxcyUSB6M6EL6gQ3hhLhDlTx/t60 gdcV7EEzjFL923VnIRteal//NVPKVcLCiPPP2jJFLCULOVHDYj/kB6mrhkfb9K/IIyzL ffUK9rABUHD07L9h9uUA+lzG60u6YTY1XGc0zi5H+byBSOM5ezd4Mu/+fAIVuQC9fsbq nnTXDmOv5XcfrCqtak+pkJr0Z8+KtTF4uF4HTs6HFIBeIeK8a1wnaD36w1TrUT+qmrpk XDgZLezvrIKvDfg8lhdJUShQPuT7+7zO6AZDE9qqmyCp+h5kxR4mWyNdmrgzICB3axSE z9Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XpMVdwpeqpeITY25PfwxcLJIP681b3jEqfL5jeWDhJY=; b=tQq6zay+OeDXWp3k3Fn/yCNP2Uxo6+mUYiO05GuWg3F9VCW6kPHJX1eH7QVkAWphSr VW+1shHIRvnLC5qG/2XueKbadVx66ao+dsgTIvmfXzofHjzQKPBN4DKEPFkoNk/f15Xo vvW29z/QbltyB6w/8727eDCBNCZoOXOhBNxMAq/JqDPlTI2g9HbCy9niDev19b7GKXdm JxWNPYv4jeqhcMNoDe/SvxT4CQvbPp/Ndd3HvDJeqxLB8+BQd6gg3LUgvGA0X/AwDl6v GZV9zEpUdrdE2g+pz43cPQMWRwG5P+ommUsDmxeEUCHpRSTNt0Epaeg63AhwsUAg2Ffo MqhA== X-Gm-Message-State: AOAM530WMGfJL6sRwXF6FQxPTMaq0y/JggEvNihGX1Otg8Gm6yrtwMpQ GE22JLyFKjcKocA7J1htMskfPR7ieDWtTH/R X-Google-Smtp-Source: ABdhPJzsu68/KFjtOCgtIfOeFLn+tZ5YsNa7Zi5+IP7xT+/h2olOiJPe2RsXW5BOYtZlO/ePDn1yHg== X-Received: by 2002:a17:902:9b8b:b029:e6:b027:2f96 with SMTP id y11-20020a1709029b8bb02900e6b0272f96mr14565613plp.28.1617992729450; Fri, 09 Apr 2021 11:25:29 -0700 (PDT) Return-Path: Received: from localhost.localdomain (174-21-70-23.tukw.qwest.net. [174.21.70.23]) by smtp.gmail.com with ESMTPSA id e190sm2962802pfe.3.2021.04.09.11.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 11:25:29 -0700 (PDT) From: "Bret Barkelew" X-Google-Original-From: Bret Barkelew To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu Subject: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib Date: Fri, 9 Apr 2021 11:25:11 -0700 Message-Id: <20210409182511.620-1-bret.barkelew@microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DumpVariablePolicy() will return EFI_INVALID_PARAMETER if the Buffer pointer is NULL and the indirect Size is anything but 0. Since this TempSize was not being initialized it is very likely that this sequence would not return the total buffer size as expected. Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3310 Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Bret Barkelew --- MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c index 14e1904e96d3..e50edb4ffc5a 100644 --- a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c +++ b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c @@ -216,6 +216,7 @@ VarCheckPolicyLibMmiHandler ( DumpParamsOut->TotalSize = 0; DumpParamsOut->PageSize = 0; DumpParamsOut->HasMore = FALSE; + TempSize = 0; SubCommandStatus = DumpVariablePolicy (NULL, &TempSize); if (SubCommandStatus == EFI_BUFFER_TOO_SMALL && TempSize > 0) { mCurrentPaginationCommand = VAR_CHECK_POLICY_COMMAND_DUMP; -- 2.28.0.windows.1