From: "Leif Lindholm" <leif@nuviainc.com>
To: 贾玲 <jialing@phytium.com.cn>
Cc: 舒奕棋 <shuyiqi@phytium.com.cn>, 谢鹏 <xiepeng@phytium.com.cn>,
devel@edk2.groups.io
Subject: Re: [PATCH v3 00/10] Added support for FT2000/4 chip
Date: Tue, 13 Apr 2021 17:11:37 +0100 [thread overview]
Message-ID: <20210413161137.GA1664@vanye> (raw)
In-Reply-To: <34705082.38e.178c91524ed.Coremail.jialing@phytium.com.cn>
Hi Ling,
Many apologies.
Qualcomm's acquisition of NUVIA closed on 16 March, which caused a lot
of initial disruption. Then I took last week as holiday. I am back
now, and will start going through my review backlog.
Best Regards,
Leif
On Tue, Apr 13, 2021 at 10:35:09 +0800, 贾玲 wrote:
> Hi Leif,
>
> It's been a few days since I sent V3 patches. Do you have any suggestions for this patches? Looking forward to your reply！
>
> Best Regards,
>
> Ling
> > -----原始邮件-----
> > 发件人: "Ling Jia" <jialing@phytium.com.cn>
> > 发送时间: 2021-03-17 15:26:37 (星期三)
> > 收件人: devel@edk2.groups.io
> > 抄送: "Leif Lindholm" <leif@nuviainc.com>, "Ling Jia" <jialing@phytium.com.cn>
> > 主题: [PATCH v3 00/10] Added support for FT2000/4 chip
> >
> > This series added packages to support FT2000/4 chip.
> > Platform/Phytium: Added DurianPkg, include DurianPkg.dsc and DurianPkg.fdf.
> > Silicon/Phytium: Added FT2000-4Pkg and PhytiumCommonPkg.
> >
> > The modules could be runed at the silicon of FT2000/4.
> > They supported Acpi parameter configuration, Pci bus scaning,
> > flash read-write and erase abd operating system boot function.
> > Maintainers.txt: Added maintainers and reviewers for the DurianPkg.
> >
> > The public git repository is :
> > https://github.com/jialing2020/edk2-platforms/tree/Phytium_Opensource_For_FT2000-4_v3
> >
> > v3:
> > Optimized the codes to meet the edk2 coding specification.
> >
> > Ling Jia (10):
> > Silicon/Phytium: Added PlatformLib to FT2000/4
> > Silicon/Phytium: Added Acpi support to FT2000/4
> > Silicon/Phytium: Added SMBIOS support to FT2000/4
> > Silicon/Phytium: Added PciSegmentLib to FT2000/4
> > Silicon/Phytium: Added PciHostBridgeLib to FT2000/4
> > Silicon/Phytium: Added Spi driver support to FT2000/4
> > Silicon/Phytium: Added flash driver support to Phytium Silicon
> > Silicon/Phytium: Added fvb driver for norflash
> > Silicon/Phytium: Added Rtc driver to FT2000/4
> > Maintainers.txt: Added maintainers and reviewers for the DurianPkg
> >
> > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 52 +
> > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 345 +++++
> > Platform/Phytium/DurianPkg/DurianPkg.dsc | 331 +++++
> > Platform/Phytium/DurianPkg/DurianPkg.fdf | 235 ++++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiTables.inf | 56 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 47 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.inf | 44 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.inf | 48 +
> > Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 47 +
> > Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf | 28 +
> > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf | 55 +
> > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.inf | 39 +
> > Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 53 +
> > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf | 61 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.h | 64 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.h | 99 ++
> > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.h | 24 +
> > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.h | 104 ++
> > Silicon/Phytium/PhytiumCommonPkg/Include/Platform.h | 80 ++
> > Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiNorFlashProtocol.h | 74 +
> > Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiProtocol.h | 51 +
> > Silicon/Phytium/PhytiumCommonPkg/Include/SystemServiceInterface.h | 112 ++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 943 +++++++++++++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.c | 198 +++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.c | 424 ++++++
> > Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 181 +++
> > Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.c | 1434 ++++++++++++++++++++
> > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c | 137 ++
> > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLibMem.c | 156 +++
> > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 462 +++++++
> > Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 250 ++++
> > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.c | 1304 ++++++++++++++++++
> > Maintainers.txt | 8 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiSsdtRootPci.asl | 209 +++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dbg2.aslc | 80 ++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Cpu.asl | 85 ++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Dsdt.asl | 15 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Uart.asl | 65 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Fadt.aslc | 77 ++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Gtdt.aslc | 83 ++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 89 ++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Madt.aslc | 67 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Mcfg.aslc | 65 +
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 219 +++
> > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Spcr.aslc | 73 +
> > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/AArch64/PhytiumPlatformHelper.S | 76 ++
> > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.fdf.inc | 119 ++
> > 47 files changed, 8868 insertions(+)
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
> > create mode 100644 Platform/Phytium/DurianPkg/DurianPkg.dsc
> > create mode 100644 Platform/Phytium/DurianPkg/DurianPkg.fdf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiTables.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.inf
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.h
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.h
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.h
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.h
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Platform.h
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiNorFlashProtocol.h
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiProtocol.h
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/SystemServiceInterface.h
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLibMem.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatform.c
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.c
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiSsdtRootPci.asl
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dbg2.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Cpu.asl
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Dsdt.asl
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Uart.asl
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Fadt.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Gtdt.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Madt.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Mcfg.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Spcr.aslc
> > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/AArch64/PhytiumPlatformHelper.S
> > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.fdf.inc
> >
> > --
> > 2.25.1
>
>
>
>
>
next prev parent reply other threads:[~2021-04-13 16:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 7:26 [PATCH v3 00/10] Added support for FT2000/4 chip jialing
2021-03-17 7:26 ` [PATCH v3 01/10] Silicon/Phytium: Added PlatformLib to FT2000/4 jialing
2021-04-13 18:00 ` Leif Lindholm
2021-05-06 3:14 ` Ling Jia
2021-03-17 7:26 ` [PATCH v3 02/10] Silicon/Phytium: Added Acpi support " jialing
2021-03-17 7:26 ` [PATCH v3 03/10] Silicon/Phytium: Added SMBIOS " jialing
2021-03-17 7:26 ` [PATCH v3 04/10] Silicon/Phytium: Added PciSegmentLib " jialing
2021-03-17 7:26 ` [PATCH v3 05/10] Silicon/Phytium: Added PciHostBridgeLib " jialing
2021-03-17 7:26 ` [PATCH v3 06/10] Silicon/Phytium: Added Spi driver support " jialing
2021-03-17 7:26 ` [PATCH v3 07/10] Silicon/Phytium: Added flash driver support to Phytium Silicon jialing
2021-03-17 7:26 ` [PATCH v3 08/10] Silicon/Phytium: Added fvb driver for norflash Ling Jia
2021-03-17 7:26 ` [PATCH v3 09/10] Silicon/Phytium: Added Rtc driver to FT2000/4 Ling Jia
2021-03-17 7:26 ` [PATCH v3 10/10] Maintainers.txt: Added maintainers and reviewers for the DurianPkg Ling Jia
2021-04-13 2:35 ` [PATCH v3 00/10] Added support for FT2000/4 chip Ling Jia
2021-04-13 16:11 ` Leif Lindholm [this message]
2021-05-27 12:43 ` Leif Lindholm
2021-09-07 11:59 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413161137.GA1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox