From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mx.groups.io with SMTP id smtpd.web12.174.1618330301778328714 for ; Tue, 13 Apr 2021 09:11:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=eQbLrOyb; spf=pass (domain: nuviainc.com, ip: 209.85.218.52, mailfrom: leif@nuviainc.com) Received: by mail-ej1-f52.google.com with SMTP id n2so26814572ejy.7 for ; Tue, 13 Apr 2021 09:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=biXveDrnkJ+/xvevyl77IYmSQR2xXDBcdqdUTOmOK0c=; b=eQbLrOyb6/LeQTDn5zIxkFeAadsO8ELHC+3QqimWTa+Bo7vQ3fZWSe5lYw8wPog8pN 4JYshwdjYw3WnFBBxeMTbNmJkyzrKFc/pBKuryvnq8dmFdPOKby8/0DwAHrLPdcdkOfl KbrYY5fN+PBwKT5gBpVn9wmPeTQIqmdjtXtYo8DBOGYPGakXSm44SJV2MoQ/Fny7uwiF KBq8Q43qRv/J/fBsI3VqPZPcZM9I1/VpYvu+LcBqwmJ6tpXCjbDxvm2Mgk50I+oBHLPB UZvnI9q4uG5lPtztnQVSZNYmaU8gFwbx1+xotIM0D2rofZAT6w8PL1tTqEhDn3SE+bPy Hw9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=biXveDrnkJ+/xvevyl77IYmSQR2xXDBcdqdUTOmOK0c=; b=dV+YVfWRSC12CqRTrAq3HqK74dLvFXBshClsCMUYiEfeDbIsy6hwVgSaVEWnFzAjLU fBeb1lPl+mbX6ZY+zVEy96JliPAArzLENSeVX1LsnO7anJlammi6cEamtb8dHoh0jpnc LSlsS3vThSgzNd5/Hlrd1m20wXk+IwKXfJj+pCtEbdFQky23GXjyAq+9loN0XGh6wqlb 2tnAPnkMWfyYjPI58sM49AWf/uGNus8R1l2pXUm4IaohuC/9lVkXP8ycwDMFwUE/BeEf 1aMRBTR2TEVJzmLWOzoUbJEHVxPyu5UEuMSXZncMKfIYCFOqBNiX2eku57BkAXI+vycN M5VA== X-Gm-Message-State: AOAM532D4RqzdkcuEjN8MVUpVRm9UDbOOQt702DnagRdDbRPHfBJt7a7 tFxqagVy8QR5hmxLesIscm+rpr1ylBZbLIcE X-Google-Smtp-Source: ABdhPJy03kn+PcPYR/oLONrc1td4RkZoVEnQMD14fitWwNFj2KIHl0IxFONlcC3Uv0dQ0tW6xNvS1Q== X-Received: by 2002:a17:906:11ce:: with SMTP id o14mr12015858eja.113.1618330300230; Tue, 13 Apr 2021 09:11:40 -0700 (PDT) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id qo16sm6058336ejb.64.2021.04.13.09.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 09:11:39 -0700 (PDT) Date: Tue, 13 Apr 2021 17:11:37 +0100 From: "Leif Lindholm" To: =?utf-8?B?6LS+546y?= Cc: =?utf-8?B?6IiS5aWV5qOL?= , =?utf-8?B?6LCi6bmP?= , devel@edk2.groups.io Subject: Re: [PATCH v3 00/10] Added support for FT2000/4 chip Message-ID: <20210413161137.GA1664@vanye> References: <20210317072647.77340-1-jialing@phytium.com.cn> <34705082.38e.178c91524ed.Coremail.jialing@phytium.com.cn> MIME-Version: 1.0 In-Reply-To: <34705082.38e.178c91524ed.Coremail.jialing@phytium.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Ling, Many apologies. Qualcomm's acquisition of NUVIA closed on 16 March, which caused a lot of initial disruption. Then I took last week as holiday. I am back now, and will start going through my review backlog. Best Regards, Leif On Tue, Apr 13, 2021 at 10:35:09 +0800, 贾玲 wrote: > Hi Leif, > > It's been a few days since I sent V3 patches. Do you have any suggestions for this patches? Looking forward to your reply！ > > Best Regards, > > Ling > > -----原始邮件----- > > 发件人: "Ling Jia" > > 发送时间: 2021-03-17 15:26:37 (星期三) > > 收件人: devel@edk2.groups.io > > 抄送: "Leif Lindholm" , "Ling Jia" > > 主题: [PATCH v3 00/10] Added support for FT2000/4 chip > > > > This series added packages to support FT2000/4 chip. > > Platform/Phytium: Added DurianPkg, include DurianPkg.dsc and DurianPkg.fdf. > > Silicon/Phytium: Added FT2000-4Pkg and PhytiumCommonPkg. > > > > The modules could be runed at the silicon of FT2000/4. > > They supported Acpi parameter configuration, Pci bus scaning, > > flash read-write and erase abd operating system boot function. > > Maintainers.txt: Added maintainers and reviewers for the DurianPkg. > > > > The public git repository is : > > https://github.com/jialing2020/edk2-platforms/tree/Phytium_Opensource_For_FT2000-4_v3 > > > > v3: > > Optimized the codes to meet the edk2 coding specification. > > > > Ling Jia (10): > > Silicon/Phytium: Added PlatformLib to FT2000/4 > > Silicon/Phytium: Added Acpi support to FT2000/4 > > Silicon/Phytium: Added SMBIOS support to FT2000/4 > > Silicon/Phytium: Added PciSegmentLib to FT2000/4 > > Silicon/Phytium: Added PciHostBridgeLib to FT2000/4 > > Silicon/Phytium: Added Spi driver support to FT2000/4 > > Silicon/Phytium: Added flash driver support to Phytium Silicon > > Silicon/Phytium: Added fvb driver for norflash > > Silicon/Phytium: Added Rtc driver to FT2000/4 > > Maintainers.txt: Added maintainers and reviewers for the DurianPkg > > > > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 52 + > > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 345 +++++ > > Platform/Phytium/DurianPkg/DurianPkg.dsc | 331 +++++ > > Platform/Phytium/DurianPkg/DurianPkg.fdf | 235 ++++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiTables.inf | 56 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 47 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.inf | 44 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.inf | 48 + > > Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 47 + > > Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf | 28 + > > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf | 55 + > > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.inf | 39 + > > Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 53 + > > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf | 61 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.h | 64 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.h | 99 ++ > > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.h | 24 + > > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.h | 104 ++ > > Silicon/Phytium/PhytiumCommonPkg/Include/Platform.h | 80 ++ > > Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiNorFlashProtocol.h | 74 + > > Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiProtocol.h | 51 + > > Silicon/Phytium/PhytiumCommonPkg/Include/SystemServiceInterface.h | 112 ++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 943 +++++++++++++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.c | 198 +++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.c | 424 ++++++ > > Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 181 +++ > > Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.c | 1434 ++++++++++++++++++++ > > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c | 137 ++ > > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLibMem.c | 156 +++ > > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 462 +++++++ > > Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 250 ++++ > > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.c | 1304 ++++++++++++++++++ > > Maintainers.txt | 8 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiSsdtRootPci.asl | 209 +++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dbg2.aslc | 80 ++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Cpu.asl | 85 ++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Dsdt.asl | 15 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Uart.asl | 65 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Fadt.aslc | 77 ++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Gtdt.aslc | 83 ++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 89 ++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Madt.aslc | 67 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Mcfg.aslc | 65 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 219 +++ > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Spcr.aslc | 73 + > > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/AArch64/PhytiumPlatformHelper.S | 76 ++ > > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.fdf.inc | 119 ++ > > 47 files changed, 8868 insertions(+) > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc > > create mode 100644 Platform/Phytium/DurianPkg/DurianPkg.dsc > > create mode 100644 Platform/Phytium/DurianPkg/DurianPkg.fdf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiTables.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.inf > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.h > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.h > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.h > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.h > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Platform.h > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiNorFlashProtocol.h > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiProtocol.h > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/SystemServiceInterface.h > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLibMem.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatform.c > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.c > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiSsdtRootPci.asl > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dbg2.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Cpu.asl > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Dsdt.asl > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Uart.asl > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Fadt.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Gtdt.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Madt.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Mcfg.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Spcr.aslc > > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/AArch64/PhytiumPlatformHelper.S > > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.fdf.inc > > > > -- > > 2.25.1 > > > > >