From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by mx.groups.io with SMTP id smtpd.web08.425.1618332680990855760 for ; Tue, 13 Apr 2021 09:51:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=cSnZD1dS; spf=pass (domain: nuviainc.com, ip: 209.85.218.46, mailfrom: leif@nuviainc.com) Received: by mail-ej1-f46.google.com with SMTP id mh2so5485716ejb.8 for ; Tue, 13 Apr 2021 09:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7G6oY16B4Zb+CDFEkYiz05Yu5pcNEOBzDgc7l9Ibojs=; b=cSnZD1dSEjVwa/OuWDiZiLyQPH3LLroYgfwJWGvXUVBxXocafAYYz0PF8o9LTyR3xX NEZBGfA0TEffYaQMoycK3JCUiwe4ZvPdoJXW8ae6pI0E7HqGjQIEramhiBWfwCmmK4XQ krP1KnPshjjE6nkYRfaJA7QFD0CY47KWmsjN2bYEVc7suYp1uz9bbbt0H2MSc6rLTp50 EXxY5CzWy5cHPsOPwkwNckqvzO9f2j7k83vxxX1jaRtoPWZCwOr+3SJF/acEEsHDlchp W05/nk7gqhetvdi+VUbpm8cHjdo/Z3vIkkrM1eg6yV+uThWmEh6yTsvrpwLZQV0d5qgG 5kHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7G6oY16B4Zb+CDFEkYiz05Yu5pcNEOBzDgc7l9Ibojs=; b=PUFEcrNKQAZi6ymKWCdiiffwYFZEbJqWJ5UJzvDpewuuLVnBS7+DWf8j6aPA/x15Gx n+dgcA1kf8dtG6eVcpX9OtrzsRmZS7veAJmT3heX0zy2VmiJPWf0EKmHGzvJond8adZP PrTnqN0Z2BNTYeH6EsUG4FCQ1tCCHnJ3LKW0JzUlg8APAsPvhjqQjcVBkzX5Xr3Ni9fZ wqNyGRIp8Ot66JSQQlsn+cK+oq3ClGKvIVKLy6GBx+icueiL9Valvq41DKMhTSXVdRvF qhNP4oiRvwQWlJiW6J+xq/jpnfBxgo9ydtrOB2LNnrto9s3RhykZFVCv0eV/ga41aV4m MHzA== X-Gm-Message-State: AOAM533z1paOGMf55ZxkfRdUBGe02ckP6NnpWU5VjK6Hizo2X/TJQoSl bNctn+NQXtuukH/Lq+HOpEiOBQ== X-Google-Smtp-Source: ABdhPJz5lFcHuVxRHDHcvl+4tiGAFdIcSk21q3JwURJ2sQvzq146aAAfRfvwyK3WMSr5+J1cz6jBrg== X-Received: by 2002:a17:906:5906:: with SMTP id h6mr34246007ejq.288.1618332679485; Tue, 13 Apr 2021 09:51:19 -0700 (PDT) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id q19sm8200432ejy.50.2021.04.13.09.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 09:51:19 -0700 (PDT) Date: Tue, 13 Apr 2021 17:51:17 +0100 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH 1/5] ArmPkg: Allow platforms to override PCI supported state in SmbiosMiscDxe Message-ID: <20210413165117.GC1664@vanye> References: <20210331021619.19761-1-rebecca@nuviainc.com> <20210331021619.19761-2-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210331021619.19761-2-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 30, 2021 at 20:16:15 -0600, Rebecca Cran wrote: > Not all platforms support PCI, so introduce a PCD to allow platforms to > specify whether they support it. Are we planning to add one? If not, I'd rather skip this until we do. These days, I would expect any platform providing SMBIOS tables to have PCI. No further comments on this set. / Leif > Signed-off-by: Rebecca Cran > --- > ArmPkg/ArmPkg.dec | 1 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 4 ++++ > 3 files changed, 6 insertions(+) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index a8a22c649ff8..51ac2191c85a 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -125,6 +125,7 @@ [PcdsFixedAtBuild.common] > # > # SMBIOS PCDs > # > + gArmTokenSpaceGuid.PcdPlatformSupportsPCI|TRUE|BOOLEAN|0x30000052 > gArmTokenSpaceGuid.PcdSystemProductName|L""|VOID*|0x30000053 > gArmTokenSpaceGuid.PcdSystemVersion|L""|VOID*|0x30000054 > gArmTokenSpaceGuid.PcdBaseBoardManufacturer|L""|VOID*|0x30000055 > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > index 60d8fe31c219..ebc4c99ac436 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > @@ -71,6 +71,7 @@ [Pcd] > gArmTokenSpaceGuid.PcdFdSize > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > + gArmTokenSpaceGuid.PcdPlatformSupportsPCI > gArmTokenSpaceGuid.PcdSystemBiosRelease > gArmTokenSpaceGuid.PcdEmbeddedControllerFirmwareRelease > gArmTokenSpaceGuid.PcdSystemProductName > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > index 5aea32521bd3..a06f814aeb7c 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -264,6 +265,9 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) > UnicodeStrToAsciiStrS (Version, StrStart, VerStrLen + 1); > StrStart += VerStrLen + 1; > UnicodeStrToAsciiStrS (ReleaseDate, StrStart, DateStrLen + 1); > + > + SmbiosRecord->BiosCharacteristics.PciIsSupported = FixedPcdGetBool (PcdPlatformSupportsPCI); > + > // > // Now we have got the full smbios record, call smbios protocol to add this record. > // > -- > 2.26.2 >