From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mx.groups.io with SMTP id smtpd.web12.7802.1618369173954664829 for ; Tue, 13 Apr 2021 19:59:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ut0SvyfU; spf=pass (domain: gmail.com, ip: 209.85.210.175, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f175.google.com with SMTP id a12so12755953pfc.7 for ; Tue, 13 Apr 2021 19:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0v9CVMeObNsstBRAdoytulczVkSn5R73s4OZWROkUOo=; b=ut0SvyfUEQABLGnxFyGHB8qJb3CZi67yjnN4aMjD7M9qBFW5YH5fINBPRoljG1O7Mv J4ie0N69WNpyKAm0o5nKxijX4erP3WSyHwlgy48vTEvNz3vuHBNnKpsb2Jhy+Lu58R7a UWRWXmsJB9n75yNPGJRwYAoo3yKdUDZhohP7bm/jxqXNPgb2ZImOiTWc8PGdCD0TMKvY UzK7SLUIRkjrGtSrz8LWC5zap8oHFGdCOGZrIpAF6E8MVgBMH5J99yQz8ahJDJL75hm1 hymVqTfIDkJ5rF6azldAkO8gpNhYbWa9HgrixWP1HjQGwZ/8iaWkM3WtsKRBJSXn7l+i 3ZzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0v9CVMeObNsstBRAdoytulczVkSn5R73s4OZWROkUOo=; b=DHz/PcXBUSFKisqKCnYu/IEqXVzTnsecmv6rMqT8v7K7LqWsxsfvi+Ju2G1nFTGYhB 7y84xfTSQTFdopdalAZe4nxvcM8uXpF6pUo8NGaEg+11Ww3YvF2puFyarKVqeXYZZsQd 95O3Y5FTwtoTN5Y291tUF/ksYUM6ovBhHMNQJlg4auKf79NLm/KI7dOhzjzCvhfBynp1 NeIaG0iIZkTBCqK9n/c7MghBuiND8cFr3VBj5WaHy13511Xxuf400LiAwxwR8qyE6QyR fbgITr7jrqHkUR4N36iNX3b/y4TSTa1cG9ON6ny47Hp1tqZJtycYgpWiY9XpB1vaot8h MYWw== X-Gm-Message-State: AOAM532vkVYmv1Dc1ovdpjHsASB8vWqUTc9VNa36CO2XOOdAusfbImGw vBArV4O4V4oVikr++yO7s/4az2hf9mk= X-Google-Smtp-Source: ABdhPJx6Kt4fEOgosyRHTC1PFxC8a/3b6xHMfFoA0n+HFR+qQhC6JCUAUNDCB4m+d60nsIvOw5fZWA== X-Received: by 2002:aa7:9798:0:b029:24c:b3b9:46f4 with SMTP id o24-20020aa797980000b029024cb3b946f4mr12844884pfp.24.1618369173262; Tue, 13 Apr 2021 19:59:33 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id q19sm15292442pgv.38.2021.04.13.19.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 19:59:32 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Laszlo Ersek , Rahul Kumar Subject: [PATCH v1 0/1] Not to Update Bitwidth Variable in Static Paging Date: Tue, 13 Apr 2021 19:59:21 -0700 Message-Id: <20210414025922.850-1-kuqin12@gmail.com> X-Mailer: git-send-email 2.31.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3300 Current implementation of SetStaticPageTable routine in PiSmmCpuDxeSmm driver will check a global variable mPhysicalAddressBits, and eventually cap any value larger than 39 at 39. However, this global variable is used in ConvertMemoryPageAttributes, which backs SmmSetMemoryAttributes and SmmClearMemoryAttributes. Thus for a processor that supports more than 39 bits width, trying to mark page table regions higher than 39-bit will always return EFI_UNSUPPROTED. As a result, access rights to pages residing higher than 39 bits in the physical address space will not be correctly configured (i.e. restricted) in the SMM page table entries. This change attempts to fix this issue by switching to caching the global bitwidth variable in local variable for SetStaticPageTable routine. Patch v1 branch: https://github.com/kuqin12/edk2/tree/bitwidth_paging Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Kun Qin (1): UefiCpuPkg: PiSmmCpuDxeSmm: Not to Change Bitwidth During Static Paging UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 25 +++++++++++--------- 1 file changed, 14 insertions(+), 11 deletions(-) -- 2.31.0.windows.1