From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mx.groups.io with SMTP id smtpd.web09.7543.1618572891307436285 for ; Fri, 16 Apr 2021 04:34:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=0sYPUrgt; spf=pass (domain: nuviainc.com, ip: 209.85.208.53, mailfrom: leif@nuviainc.com) Received: by mail-ed1-f53.google.com with SMTP id x4so31884163edd.2 for ; Fri, 16 Apr 2021 04:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Z67x0zOTLoP3jhXoZEE9slgQk5IU2AouPOP/99OjfDs=; b=0sYPUrgt06GIyJbjkC1cwLWOUvwage0I425C6QYGDk82dCB+cKzS455Ms2jyluPgJs Gf09UwmedJT1+WI7WycqCu15TfvVautnJismOXZNdaO4vr+xfohBeWKuXjlA8FtybxTJ YN08cMbErl9y/WfnT3Q+NOGd7ab9zaH/XWz7jz+b3i8zSUCscn5J6lCVrDKqCsHJjqcd xPB+tH2/LNZhy6spS1XnmmseN/hDaiotnirDRim1VJbrZvUl5WtDgxAsX30vQZi7PfQJ 67sIDTE2cYkxQEQwAb+YaFjIRwslADcE6phHZgur3yCOxOUkRSWt6BI93y9gdb2fijTP G0Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Z67x0zOTLoP3jhXoZEE9slgQk5IU2AouPOP/99OjfDs=; b=VgMcrUAn6lnuHk82lRF4aHDupw2gJtENW3GP2Rp1Z/gSyAsUSdgBj6/movKtnkNp8f D0wIjuyFJ3mFeIGTDvVCOmzhQbtLTdQvpTngU7yfe1oc5tn0sXuJRZzlZgt9Q7UAsKkY jMNw6dq2x0625mNK19KizOtw5oKnd7KiySUEdQ+QmZdTxQVRGGfqnUaUotA1gb8knu0q NLJ3iUB849NQ5BFTA35+mXGEnC4pchhWha63mTx/T36ODuAw2x3bkKUr190CeFC2xGFO dz5KppG+ritsAvPfyv1em2R49naWky1KEOj1kl+0hVdItOGSVMyKM78daNSHJQjch8L2 kteA== X-Gm-Message-State: AOAM532JVhM3x3W3bDDg2JTlKeZLuVHf1R05mlPE+O/TZQu7/Kp8Vst1 WgzWCQRw6LeoRnlf3QucAYziEA== X-Google-Smtp-Source: ABdhPJzs/M1FWt8mNiXq2OhoEcnSeyESpoYKBAWJ0YJ3pTni43YGk6Ig+5P3C0ijP7kkA/BbbbQ8mA== X-Received: by 2002:a05:6402:453:: with SMTP id p19mr2430584edw.88.1618572889755; Fri, 16 Apr 2021 04:34:49 -0700 (PDT) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id hc43sm4204956ejc.97.2021.04.16.04.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 04:34:49 -0700 (PDT) Date: Fri, 16 Apr 2021 12:34:47 +0100 From: "Leif Lindholm" To: Ethin Probst Cc: devel@edk2.groups.io, afish@apple.com, mcb30@ipxe.org, Mike Kinney , Laszlo Ersek , "Desimone, Nathaniel L" , Rafael Rodrigues Machado , Gerd Hoffmann Subject: Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021) Message-ID: <20210416113447.GG1664@vanye> References: <4AEC1784-99AF-47EF-B7DD-77F91EA3D7E9@apple.com> <309cc5ca-2ecd-79dd-b183-eec0572ea982@ipxe.org> <33e37977-2d27-36a0-89a6-36e513d06b2f@ipxe.org> <6F69BEA6-5B7A-42E5-B6DA-D819ECC85EE5@apple.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Ethin, I think we also want to have a SetMode function, even if we don't get around to implement proper support for it as part of GSoC (although I expect at least for virtio, that should be pretty straightforward). It's quite likely that speech for UI would be stored as 8kHz (or 20kHz) in some systems, whereas the example for playing a tune in GRUB would more likely be a 44.1 kHz mp3/wav/ogg/flac. For the GSoC project, I think it would be quite reasonable to pre-generate pure PCM streams for testing rather than decoding anything on the fly. Porting/writing decoders is really a separate task from enabling the output. I would much rather see USB *and* HDA support able to play pcm streams before worrying about decoding. / Leif On Fri, Apr 16, 2021 at 00:33:06 -0500, Ethin Probst wrote: > Thanks for that explanation (I missed Mike's message). Earlier I sent > a summary of those things that we can agree on: mainly, that we have > mute, volume control, a load buffer, (maybe) an unload buffer, and a > start/stop stream function. Now that I fully understand the > ramifications of this I don't mind settling for a specific format and > sample rate, and signed 16-bit PCM audio is, I think, the most widely > used one out there, besides 64-bit floating point samples, which I've > only seen used in DAWs, and that's something we don't need. > Are you sure you want the firmware itself to handle the decoding of > WAV audio? I can make a library class for that, but I'll definitely > need help with the security aspect. > > On 4/16/21, Andrew Fish via groups.io wrote: > > > > > >> On Apr 15, 2021, at 5:59 PM, Michael Brown wrote: > >> > >> On 16/04/2021 00:42, Ethin Probst wrote: > >>> Forcing a particular channel mapping, sample rate and sample format on > >>> everyone would complicate application code. From an application point > >>> of view, one would, with that type of protocol, need to do the > >>> following: > >>> 1) Load an audio file in any audio file format from any storage > >>> mechanism. > >>> 2) Decode the audio file format to extract the samples and audio > >>> metadata. > >>> 3) Resample the (now decoded) audio samples and convert (quantize) the > >>> audio samples into signed 16-bit PCM audio. > >>> 4) forward the samples onto the EFI audio protocol. > >> > >> You have made an incorrect assumption that there exists a requirement to > >> be able to play audio files in arbitrary formats. This requirement does > >> not exist. > >> > >> With a protocol-mandated fixed baseline set of audio parameters (sample > >> rate etc), what would happen in practice is that the audio files would be > >> encoded in that format at *build* time, using tools entirely external to > >> UEFI. The application code is then trivially simple: it just does "load > >> blob, pass blob to audio protocol". > >> > > > > > > Ethin, > > > > Given the goal is an industry standard we value interoperability more that > > flexibility. > > > > How about another use case. Lets say the Linux OS loader (Grub) wants to > > have an accessible UI so it decides to sore sound files on the EFI System > > Partition and use our new fancy UEFI Audio Protocol to add audio to the OS > > loader GUI. So that version of Grub needs to work on 1,000 of different PCs > > and a wide range of UEFI Audio driver implementations. It is a much easier > > world if Wave PCM 16 bit just works every place. You could add a lot of > > complexity and try to encode the audio on the fly, maybe even in Linux > > proper but that falls down if you are booting from read only media like a > > DVD or backup tape (yes people still do that in server land). > > > > The other problem with flexibility is you just made the test matrix very > > large for every driver that needs to get implemented. For something as > > complex as Intel HDA how you hook up the hardware and what CODECs you use > > may impact the quality of the playback for a given board. Your EFI is likely > > going to pick a single encoding at that will get tested all the time if your > > system has audio, but all 50 other things you support not so much. So that > > will required testing, and some one with audiophile ears (or an AI program) > > to test all the combinations. I’m not kidding I get BZs on the quality of > > the boot bong on our systems. > > > > > >>> typedef struct EFI_SIMPLE_AUDIO_PROTOCOL { > >>> EFI_SIMPLE_AUDIO_PROTOCOL_RESET Reset; > >>> EFI_SIMPLE_AUDIO_PROTOCOL_START Start; > >>> EFI_SIMPLE_AUDIO_PROTOCOL_STOP Stop; > >>> } EFI_SIMPLE_AUDIO_PROTOCOL; > >> > >> This is now starting to look like something that belongs in boot-time > >> firmware. :) > >> > > > > I think that got a little too simple I’d go back and look at the example I > > posted to the thread but add an API to load the buffer, and then play the > > buffer (that way we can an API in the future to twiddle knobs). That API > > also implements the async EFI interface. Trust me the 1st thing that is > > going to happen when we add audio is some one is going to complain in xyz > > state we should mute audio, or we should honer audio volume and mute > > settings from setup, or from values set in the OS. Or some one is going to > > want the volume keys on the keyboard to work in EFI. > > > > Also if you need to pick apart the Wave PCM 16 byte file to feed it into the > > audio hardware that probably means we should have a library that does that > > work, so other Audio drivers can share that code. Also having a library > > makes it easier to write a unit test. We need to be security conscious as we > > need to treat the Audo file as attacker controlled data. > > > > Thanks, > > > > Andrew Fish > > > >> Michael > >> > >> > >> > >> > >> > > > > > > > > > > > > > > > > > -- > Signed, > Ethin D. Probst