public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Steven Shi" <steven.shi@intel.com>
To: devel@edk2.groups.io
Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn,
	Steven Shi <steven.shi@intel.com>
Subject: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string
Date: Sat, 17 Apr 2021 20:21:33 +0800	[thread overview]
Message-ID: <20210417122133.1879-1-steven.shi@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3341

Current CLANG_BIN env variable is set without double quote
around the LLVM default installation path string in windows,
which causes some CI build service cannot find the LLVM path
in windows.
This patch enhance it to add double quote around it.

Signed-off-by: Steven Shi <steven.shi@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 edksetup.bat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edksetup.bat b/edksetup.bat
index 7b9377aaa5c2..7ad137bb3e9b 100755
--- a/edksetup.bat
+++ b/edksetup.bat
@@ -120,7 +120,7 @@ if not defined CLANG_BIN (
     @echo.
     @echo !!! WARNING !!! CLANG_BIN environment variable is not set
     @if exist "C:\Program Files\LLVM\bin\clang.exe" (
-        @set CLANG_BIN=C:\Program Files\LLVM\bin\
+        @set "CLANG_BIN=C:\Program Files\LLVM\bin\"
         @echo   Found LLVM, setting CLANG_BIN environment variable to C:\Program Files\LLVM\bin\
     )
 )
-- 
2.28.0.windows.1


             reply	other threads:[~2021-04-17 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17 12:21 Steven Shi [this message]
2021-04-19  1:06 ` 回复: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string gaoliming
2021-04-19  8:34 ` Bob Feng
2021-04-19  8:47   ` Steven Shi
2021-04-19  9:12     ` Bob Feng
     [not found]     ` <167737869DB0B53D.14647@groups.io>
2021-04-20 10:17       ` [edk2-devel] " Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210417122133.1879-1-steven.shi@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox