From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mx.groups.io with SMTP id smtpd.web10.1274.1619206039408718767 for ; Fri, 23 Apr 2021 12:27:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=B3b2eGDw; spf=pass (domain: nuviainc.com, ip: 209.85.218.41, mailfrom: leif@nuviainc.com) Received: by mail-ej1-f41.google.com with SMTP id w3so75474399ejc.4 for ; Fri, 23 Apr 2021 12:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nyhynTynUwKZyeqyFw6Gi9vRtfaGXUYUUZ1lrZR5bm0=; b=B3b2eGDwXT/mNyli9ouZmdoVKiPQn6EdsyHduZcTRX2uSHDfnTZl08QTpzXM3zX1nK lkIkOUXKNBvIvXWz5AoIDUyIYcs+xfp7Y2MThxz5s8MvERd4mXttXbmO/p+pRhrPfUSZ a6N6AypEBgtZkm9t9j5LX+X8sV6SiMMkwNsx4HeU3yqgVdTHylgbPJ0PNpL8soDkcc2/ L6ADYT52VPowAtBZZOxv1zOjR+ThxzLIiUelvxxpE8pk2Zs0kHxt3rAOeJN9mfdnykhe pflmkFceHlXR0QhePavURNDCILafZgq6qb/swYXRimALbb8Mm1/qMyAeBQOFiCYMnhfC x7Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nyhynTynUwKZyeqyFw6Gi9vRtfaGXUYUUZ1lrZR5bm0=; b=ReYHOJWs70KswfyhAJ/z8978O0Drm4jATk1ikNJGDSUXoQcWYL0DwK2TpaWrM3XWGD avEciBhh++citrpI+9Kb+4zjQ5b6ncHW6LMML60kwomHLeuaZAKQIodUvf67hhw8kCfy RlyL7YYpDblRYIZN3cXyU0Qn982HTidJm2KA3zJZPA2Rx10sKA9W0uvHYaIX9u5Q1UWk 0HI790A2nRNQe86QYrcP6QDvszvqwJ+9TeHxTahHrfYQc66M7OY+Zr4B6RvR0YxmIjN2 ZqSubKT8QybeKJEgRSYNybL0AyH2IAbE5J2sEpxtlgoNFHH/Jw938Emc3D5ojVFZtjPa XrzQ== X-Gm-Message-State: AOAM531MGgFcmL5Dnn7VPZMfSoPL/6Mc/nxwnaNX8jmfM17J/dKMwIfZ 1gouRsNfAQzh8TTfn9Sa5rZ/lA== X-Google-Smtp-Source: ABdhPJxmF5vjk4xNXLvgrlyRXd08o/JYcYwj1C01FrYBWNKTao64b1PyRCbn1cw1UfvbCjlHTWhGAg== X-Received: by 2002:a17:906:3c1b:: with SMTP id h27mr6121249ejg.182.1619206037872; Fri, 23 Apr 2021 12:27:17 -0700 (PDT) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id i2sm4720945ejv.99.2021.04.23.12.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 12:27:17 -0700 (PDT) Date: Fri, 23 Apr 2021 20:27:15 +0100 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki Subject: Re: [edk2-platforms PATCH 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions Message-ID: <20210423192715.GL1664@vanye> References: <20210416222649.3697-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210416222649.3697-1-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 16, 2021 at 16:26:49 -0600, Rebecca Cran wrote: > Add new SMBIOS Type 32 boot information and Type 3 chassis status > functions that have been added to OemMiscLib in ArmPkg. > > Since this is a virtual platform, return fixed values for the chassis > statuses. > > Signed-off-by: Rebecca Cran > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 91 ++++++++++++++++++++ > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 2 +- > 2 files changed, 92 insertions(+), 1 deletion(-) > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > index eb405b259848..b543045de3b7 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > @@ -239,3 +239,94 @@ OemUpdateSmbiosInfo ( > HiiSetString (HiiHandle, TokenToUpdate, String, NULL); > } > } > + > +/** Fetches the Type 32 boot information status. > + > + @return Boot status. > +**/ > +MISC_BOOT_INFORMATION_STATUS_DATA_TYPE > +EFIAPI > +OemGetBootStatus ( > + VOID > + ) > +{ > + return BootInformationStatusNoError; > +} > + > +/** Fetches the chassis status when it was last booted. > + > + @return Chassis status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisBootupState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis power supply/supplies status when last booted. > + > + @return Chassis power supply/supplies status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisPowerSupplyState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis thermal status when last booted. > + > + @return Chassis thermal status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisThermalState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis security status when last booted. > + > + @return Chassis security status. > +**/ > +MISC_CHASSIS_SECURITY_STATE > +EFIAPI > +OemGetChassisSecurityStatus ( > + VOID > + ) > +{ > + return ChassisSecurityStatusNone; > +} > + > +/** Fetches the chassis height in RMUs (Rack Mount Units). > + > + @return The height of the chassis. > +**/ > +UINT8 > +EFIAPI > +OemGetChassisHeight ( > + VOID > + ) > +{ > + return 1U; > +} > + > +/** Fetches the number of power cords. > + > + @return The number of power cords. > +**/ > +UINT8 > +EFIAPI > +OemGetChassisNumPowerCords ( > + VOID > + ) > +{ > + return 1; > +} > \ No newline at end of file > diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec > index 9448852967b6..6051fabd683a 100644 > --- a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec > +++ b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec > @@ -66,4 +66,4 @@ > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdChassisVersion|L""|VOID*|0x0000011A > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdChassisManufacturer|L""|VOID*|0x0000011B > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdChassisAssetTag|L""|VOID*|0x0000011C > - gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdChassisSKU|L""|VOID*|0x0000011D > + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdChassisSKU|L""|VOID*|0x0000011D > \ No newline at end of file Code looks fine, but can you please resend with the two 'no newline at end of file's fixed? / Leif > -- > 2.26.2 >