From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web12.7674.1619526696120276955 for ; Tue, 27 Apr 2021 05:31:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=IRpK+OxS; spf=pass (domain: nuviainc.com, ip: 209.85.128.49, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f49.google.com with SMTP id y124-20020a1c32820000b029010c93864955so7005160wmy.5 for ; Tue, 27 Apr 2021 05:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hzGdEPsobqG1Ckom7aleg8ITtWvbe4pxC9lQPc7IYmg=; b=IRpK+OxS9ZCpsMTo5zS9OLHSt+nz6syBxpCJAO+LX4nKjLR66+mEtimeroA2ingpkk V686JLgKg/Bx9tzYTzp0piUE88Quqq1cqvmUFY759P93Ulj5dKNzIaebslC4P8ThMIkD tdnmHqdiy+ErdplY1eycsf3yW34T22vHEh0bc7EK7T5FthLHbNDr3F3lJnl8GztC56Q0 3fJCviD9s22K9VHxDdrSq43kq3/7WHK1CuSxp9byiZ6Hp2fm5t1+WJhprFZ2aDeRmQoE vEuscWTh5jFvrgF1v2/fnwhHL11Jf5Mj5jrJKQIpyvChlzBJvjFnmLcnleCVr7BVGrt+ J3vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hzGdEPsobqG1Ckom7aleg8ITtWvbe4pxC9lQPc7IYmg=; b=smQtpZgd7SVqtkgoPW6AJVn7PXjN0U6S6QDN795T0c6eYeOxeH7lpjdyzkNm+myYFZ F69B+BQyf1UP5JjVDbzquB80Svs2h5p6a44bkU4qohrHa+mdH0o8uo1n2hbvGv2/MPW6 KgslRkXjTtRbrD9WITEQUyy5YIYn9G2Hu1koA8h+TUoW7K1yMuF+riTYy6ZTVV3NNQE8 sCjTW+hJnf+X9S383k2p5hppT7GpL941jGKZOabNswbifxdqzTDE97g1OPijpWwzA9+u iEoOjggeBRc4COGZgCoKhEbf/dXNNIUYk35Y1j5+cEVLgkeM2UZgfmNcy9ABhPeEDBrP C/cw== X-Gm-Message-State: AOAM5311/EEdYAFzf3QFaP77GVQoxGD+yHVVbbLHI3SPyb0s+xbFxLnt eZLCmI6mU+wQbripwpTqqEB8Aw== X-Google-Smtp-Source: ABdhPJy3Cj/Ol9mutJU6WZ7uzyUUXlLyXUBtUWRX5kX1ml8Qo5pqeNfA2XCbNaTezbRuiY1GFh3d/w== X-Received: by 2002:a1c:7f4a:: with SMTP id a71mr4049023wmd.60.1619526694671; Tue, 27 Apr 2021 05:31:34 -0700 (PDT) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id y8sm4384445wru.27.2021.04.27.05.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 05:31:34 -0700 (PDT) Date: Tue, 27 Apr 2021 13:31:32 +0100 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki Subject: Re: [edk2-platforms PATCH v2 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions Message-ID: <20210427123132.GM1664@vanye> References: <20210423215719.5256-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210423215719.5256-1-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 23, 2021 at 15:57:19 -0600, Rebecca Cran wrote: > Add new SMBIOS Type 32 boot information and Type 3 chassis status > functions that have been added to OemMiscLib in ArmPkg. > > Since this is a virtual platform, return fixed values for the chassis > statuses. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm I will push this patch (with Graeme's r-b added) once the edk2 OemMiscLib set is successfully merged. / Leif > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 91 ++++++++++++++++++++ > 1 file changed, 91 insertions(+) > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > index eb405b259848..326bb56bcfa3 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > @@ -239,3 +239,94 @@ OemUpdateSmbiosInfo ( > HiiSetString (HiiHandle, TokenToUpdate, String, NULL); > } > } > + > +/** Fetches the Type 32 boot information status. > + > + @return Boot status. > +**/ > +MISC_BOOT_INFORMATION_STATUS_DATA_TYPE > +EFIAPI > +OemGetBootStatus ( > + VOID > + ) > +{ > + return BootInformationStatusNoError; > +} > + > +/** Fetches the chassis status when it was last booted. > + > + @return Chassis status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisBootupState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis power supply/supplies status when last booted. > + > + @return Chassis power supply/supplies status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisPowerSupplyState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis thermal status when last booted. > + > + @return Chassis thermal status. > +**/ > +MISC_CHASSIS_STATE > +EFIAPI > +OemGetChassisThermalState ( > + VOID > + ) > +{ > + return ChassisStateSafe; > +} > + > +/** Fetches the chassis security status when last booted. > + > + @return Chassis security status. > +**/ > +MISC_CHASSIS_SECURITY_STATE > +EFIAPI > +OemGetChassisSecurityStatus ( > + VOID > + ) > +{ > + return ChassisSecurityStatusNone; > +} > + > +/** Fetches the chassis height in RMUs (Rack Mount Units). > + > + @return The height of the chassis. > +**/ > +UINT8 > +EFIAPI > +OemGetChassisHeight ( > + VOID > + ) > +{ > + return 1U; > +} > + > +/** Fetches the number of power cords. > + > + @return The number of power cords. > +**/ > +UINT8 > +EFIAPI > +OemGetChassisNumPowerCords ( > + VOID > + ) > +{ > + return 1; > +} > -- > 2.26.2 >