Re: [edk2-platforms PATCH v2 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions

["Leif Lindholm" <leif@nuviainc.com>]

On Tue, Apr 27, 2021 at 13:31:32 +0100, Leif Lindholm wrote:
> On Fri, Apr 23, 2021 at 15:57:19 -0600, Rebecca Cran wrote:
> > Add new SMBIOS Type 32 boot information and Type 3 chassis status
> > functions that have been added to OemMiscLib in ArmPkg.
> > 
> > Since this is a virtual platform, return fixed values for the chassis
> > statuses.
> > 
> > Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> 
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 
> I will push this patch (with Graeme's r-b added) once the edk2
> OemMiscLib set is successfully merged.

Pushed as a996c765008d.

> /
>     Leif
> 
> > ---
> >  Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 91 ++++++++++++++++++++
> >  1 file changed, 91 insertions(+)
> > 
> > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
> > index eb405b259848..326bb56bcfa3 100644
> > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
> > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
> > @@ -239,3 +239,94 @@ OemUpdateSmbiosInfo (
> >      HiiSetString (HiiHandle, TokenToUpdate, String, NULL);
> >    }
> >  }
> > +
> > +/** Fetches the Type 32 boot information status.
> > +
> > +  @return Boot status.
> > +**/
> > +MISC_BOOT_INFORMATION_STATUS_DATA_TYPE
> > +EFIAPI
> > +OemGetBootStatus (
> > +  VOID
> > +  )
> > +{
> > +  return BootInformationStatusNoError;
> > +}
> > +
> > +/** Fetches the chassis status when it was last booted.
> > +
> > + @return Chassis status.
> > +**/
> > +MISC_CHASSIS_STATE
> > +EFIAPI
> > +OemGetChassisBootupState (
> > +  VOID
> > +  )
> > +{
> > +  return ChassisStateSafe;
> > +}
> > +
> > +/** Fetches the chassis power supply/supplies status when last booted.
> > +
> > + @return Chassis power supply/supplies status.
> > +**/
> > +MISC_CHASSIS_STATE
> > +EFIAPI
> > +OemGetChassisPowerSupplyState (
> > +  VOID
> > +  )
> > +{
> > +  return ChassisStateSafe;
> > +}
> > +
> > +/** Fetches the chassis thermal status when last booted.
> > +
> > + @return Chassis thermal status.
> > +**/
> > +MISC_CHASSIS_STATE
> > +EFIAPI
> > +OemGetChassisThermalState (
> > +  VOID
> > +  )
> > +{
> > +  return ChassisStateSafe;
> > +}
> > +
> > +/** Fetches the chassis security status when last booted.
> > +
> > + @return Chassis security status.
> > +**/
> > +MISC_CHASSIS_SECURITY_STATE
> > +EFIAPI
> > +OemGetChassisSecurityStatus (
> > +  VOID
> > +  )
> > +{
> > +  return ChassisSecurityStatusNone;
> > +}
> > +
> > +/** Fetches the chassis height in RMUs (Rack Mount Units).
> > +
> > +  @return The height of the chassis.
> > +**/
> > +UINT8
> > +EFIAPI
> > +OemGetChassisHeight (
> > +  VOID
> > +  )
> > +{
> > +  return 1U;
> > +}
> > +
> > +/** Fetches the number of power cords.
> > +
> > +  @return The number of power cords.
> > +**/
> > +UINT8
> > +EFIAPI
> > +OemGetChassisNumPowerCords (
> > +  VOID
> > +  )
> > +{
> > +  return 1;
> > +}
> > -- 
> > 2.26.2
> >