From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.groups.io with SMTP id smtpd.web10.7810.1619528049051284940 for ; Tue, 27 Apr 2021 05:54:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=udMStlPa; spf=pass (domain: nuviainc.com, ip: 209.85.221.54, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f54.google.com with SMTP id x7so59322674wrw.10 for ; Tue, 27 Apr 2021 05:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4lRZXHwUQuYBNJdL9VuPYvL8ELppImeu/AHVPFeoZRw=; b=udMStlPa2dpB4cI53k9boa8ccWTJrou5UKwnarQmk2fUocbTlNpKjKwiczN81+b7Js 2HuPVsOiDS/VmPDRFUf9lDzIV+uq2xXG7l0SoYgiuzPTO8hB/KWA6hGfqO4uuL8WTeml QPSfq3rtTPXe1TtCJzeHrUmG/+PnJEv5qG8aVQi17D5MwET8hn9y147yN5QAPbHb56YR IGG1V/o3ZholkMkQyO2o2LnvJjVss2QrGS9/ap0F2K4F6Pe2//CsQsUzbjzypW0zYimW X9VwuSID7SOH9aABMlU/j1/qJPjX61ov7X0bQe4eXqOzZbKZmlItHTD3ovL1xmtBtDT5 C2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4lRZXHwUQuYBNJdL9VuPYvL8ELppImeu/AHVPFeoZRw=; b=SFTMBp0IP0I1FkS/mBzEaElYwhQAXFBwwt2sZ9HoSGCLXQuVivonWRea2BTJk8KuH8 NedJW3XD3vTPFmYMKz76sJmgbA6Qt30KcENCFhYF/K3UIjkuJjHbiM521UAQOld7paR6 y5hLkw4bA8Ig9s2Z4ZzjA+v/FsUhul6qbjHIUtVaK1XsCjvnETEfWKDIdeiMd+XNkWd+ JoMx40nqc+fUGGpn0T/es5I/yjeqFcKxBKTf/0luKEJMNnzdeSQbu0HocKEJWAM2wQJR s4h68WCbQTMnO1wGEy29zbGBZvI2Fg6aZvbSuZ1QWY9eBMmVWrZ5xjSUZ7QmBs7sDd2h QMHg== X-Gm-Message-State: AOAM533BbPjNa3Dvy320E4J+8cvKaSWEaFsQr9RUza4fxhkDrfi48nxg fzpgsxbqg+WWkW7WwzzoHmMfTA== X-Google-Smtp-Source: ABdhPJxjdqh4bzVVDU2VjWWxkZP+GHWmgHWXN4i0aIV7uShCx3t4q9CFTb5vMacOv0GtYC3dkSC+Pg== X-Received: by 2002:a5d:6d0f:: with SMTP id e15mr29931763wrq.302.1619528047664; Tue, 27 Apr 2021 05:54:07 -0700 (PDT) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id n9sm19512984wmo.27.2021.04.27.05.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 05:54:07 -0700 (PDT) Date: Tue, 27 Apr 2021 13:54:05 +0100 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki Subject: Re: [edk2-platforms PATCH v2 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions Message-ID: <20210427125405.GN1664@vanye> References: <20210423215719.5256-1-rebecca@nuviainc.com> <20210427123132.GM1664@vanye> MIME-Version: 1.0 In-Reply-To: <20210427123132.GM1664@vanye> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 27, 2021 at 13:31:32 +0100, Leif Lindholm wrote: > On Fri, Apr 23, 2021 at 15:57:19 -0600, Rebecca Cran wrote: > > Add new SMBIOS Type 32 boot information and Type 3 chassis status > > functions that have been added to OemMiscLib in ArmPkg. > > > > Since this is a virtual platform, return fixed values for the chassis > > statuses. > > > > Signed-off-by: Rebecca Cran > > Reviewed-by: Leif Lindholm > > I will push this patch (with Graeme's r-b added) once the edk2 > OemMiscLib set is successfully merged. Pushed as a996c765008d. > / > Leif > > > --- > > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 91 ++++++++++++++++++++ > > 1 file changed, 91 insertions(+) > > > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > > index eb405b259848..326bb56bcfa3 100644 > > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > > @@ -239,3 +239,94 @@ OemUpdateSmbiosInfo ( > > HiiSetString (HiiHandle, TokenToUpdate, String, NULL); > > } > > } > > + > > +/** Fetches the Type 32 boot information status. > > + > > + @return Boot status. > > +**/ > > +MISC_BOOT_INFORMATION_STATUS_DATA_TYPE > > +EFIAPI > > +OemGetBootStatus ( > > + VOID > > + ) > > +{ > > + return BootInformationStatusNoError; > > +} > > + > > +/** Fetches the chassis status when it was last booted. > > + > > + @return Chassis status. > > +**/ > > +MISC_CHASSIS_STATE > > +EFIAPI > > +OemGetChassisBootupState ( > > + VOID > > + ) > > +{ > > + return ChassisStateSafe; > > +} > > + > > +/** Fetches the chassis power supply/supplies status when last booted. > > + > > + @return Chassis power supply/supplies status. > > +**/ > > +MISC_CHASSIS_STATE > > +EFIAPI > > +OemGetChassisPowerSupplyState ( > > + VOID > > + ) > > +{ > > + return ChassisStateSafe; > > +} > > + > > +/** Fetches the chassis thermal status when last booted. > > + > > + @return Chassis thermal status. > > +**/ > > +MISC_CHASSIS_STATE > > +EFIAPI > > +OemGetChassisThermalState ( > > + VOID > > + ) > > +{ > > + return ChassisStateSafe; > > +} > > + > > +/** Fetches the chassis security status when last booted. > > + > > + @return Chassis security status. > > +**/ > > +MISC_CHASSIS_SECURITY_STATE > > +EFIAPI > > +OemGetChassisSecurityStatus ( > > + VOID > > + ) > > +{ > > + return ChassisSecurityStatusNone; > > +} > > + > > +/** Fetches the chassis height in RMUs (Rack Mount Units). > > + > > + @return The height of the chassis. > > +**/ > > +UINT8 > > +EFIAPI > > +OemGetChassisHeight ( > > + VOID > > + ) > > +{ > > + return 1U; > > +} > > + > > +/** Fetches the number of power cords. > > + > > + @return The number of power cords. > > +**/ > > +UINT8 > > +EFIAPI > > +OemGetChassisNumPowerCords ( > > + VOID > > + ) > > +{ > > + return 1; > > +} > > -- > > 2.26.2 > >