public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes
Date: Tue, 27 Apr 2021 13:56:31 +0100	[thread overview]
Message-ID: <20210427125631.GO1664@vanye> (raw)
In-Reply-To: <20210331021619.19761-1-rebecca@nuviainc.com>

On Tue, Mar 30, 2021 at 20:16:14 -0600, Rebecca Cran wrote:
> Add the set of improvements requested during the initial series to move
> closer to a full/proper implementation, fix the
> chassis SKU number string, and fix a typo in a comment.
> 
> This is a breaking change wrt SbsaQemu in edk2-platforms.
> 
> Rebecca Cran (5):
>   ArmPkg: Allow platforms to override PCI supported state in
>     SmbiosMiscDxe
>   ArmPkg: Allow platforms to supply more data for SMBIOS Type3 record
>   ArmPkg: Allow platforms to report their boot status via OemMiscLib
>     call
>   ArmPkg: Fix calculation of offset of chassis SKU Number in
>     SmbiosMiscDxe
>   ArmPkg: Fix typo of Manufacturer in comment in SmbiosMiscDxe

As discussed on list, patch 1/5 was dropped.

I fixed up a trailing newline in
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c from 2/5.

For the remainder of the set:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 8d2012035db3..5b90b8abb404.

>  ArmPkg/ArmPkg.dec                                                              |  1 +
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf                        |  1 +
>  ArmPkg/Include/Library/OemMiscLib.h                                            | 70 ++++++++++++++
>  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                            | 99 ++++++++++++++++++++
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c          |  4 +
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c     |  2 +-
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 20 +++-
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c     |  3 +
>  8 files changed, 194 insertions(+), 6 deletions(-)
> 
> -- 
> 2.26.2
> 

      parent reply	other threads:[~2021-04-27 12:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  2:16 [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes Rebecca Cran
2021-03-31  2:16 ` [PATCH 1/5] ArmPkg: Allow platforms to override PCI supported state in SmbiosMiscDxe Rebecca Cran
2021-04-13 16:51   ` Leif Lindholm
2021-04-13 16:53     ` Ard Biesheuvel
2021-04-14  1:44       ` Rebecca Cran
2021-04-14  1:41     ` Rebecca Cran
2021-03-31  2:16 ` [PATCH 2/5] ArmPkg: Allow platforms to supply more data for SMBIOS Type3 record Rebecca Cran
2021-03-31  2:16 ` [PATCH 3/5] ArmPkg: Allow platforms to report their boot status via OemMiscLib call Rebecca Cran
2021-03-31  2:16 ` [PATCH 4/5] ArmPkg: Fix calculation of offset of chassis SKU Number in SmbiosMiscDxe Rebecca Cran
2021-03-31  2:16 ` [PATCH 5/5] ArmPkg: Fix typo of Manufacturer in comment " Rebecca Cran
2021-04-13 16:25 ` [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes Leif Lindholm
2021-04-14  1:42   ` Rebecca Cran
2021-04-27 12:56 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427125631.GO1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox