From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web08.7775.1619528195413504885 for ; Tue, 27 Apr 2021 05:56:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=U+Bk0Ln5; spf=pass (domain: nuviainc.com, ip: 209.85.128.44, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f44.google.com with SMTP id o21-20020a1c4d150000b029012e52898006so6814483wmh.0 for ; Tue, 27 Apr 2021 05:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oIvwivwPEie1VOcRcRuZTD+U++JYXT8GqM0srxUCgLQ=; b=U+Bk0Ln5oc0LyBX051yR7juuSjD23LKicBwR7RAMNjGdnIJtnQ155PaUqnLLpb9Bn2 g2nf0gEYx5aq3Y8+ROugNjaml2/XnPEX6MEMoDYzzpJExjM+uBykIQMJKS4iwpihCNbq Jqk8MkukFcYKQS20wGfVaemZ4C7+zD5lhGRtz8fYAEoE5dlJgKxAMGuo3VLeIYAMjfMs kv/AGo3jduKCFjorM68va3bRd2aBnk+Fzp2mpBGpvCB34EobaaKirWV+Qhk8s6ktVsLp kqaZ6vkdzTWIOPOd8dVoI1eeAfGrpqNfHGN6ISs4A7k6KA0T3D+YRB0t1rEJ5nCC1EdI tLRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oIvwivwPEie1VOcRcRuZTD+U++JYXT8GqM0srxUCgLQ=; b=pgS0DM5V6EmwU9mfxjXs+/OiOfRjpn+XPG+T6liMFM4+TdhdObWjjFGgORz96+MTAW 75LG2t0xLCbtvP55L3yasM3pGU2ZNzdWdsaks6Y/uO8k7j6zDcPwatnRUihqpOlMCvmQ /nl+M4WwMP0F7QpTs83vV/oATCc6XTwS1yfVfZFWLjCSDXr+Sl/4XNkSiFXCazdOa3u0 9lmkXBw7Y/aX80EBatPYgWBo4Z3FW+FU2I8rlL71IdSbfWW6XPL2bAtIvRfR0n/3boyA O+9FRuTS1z/syx8mJC8vaQRixN5nQj6P6OAkaBelDNLya4nCXSTn6liaVkrqHcs5OAT3 85NQ== X-Gm-Message-State: AOAM531pbMB0z0qVI15hasiX/SiY0lYzGlQiybvYWzGEQf8yrZlG3VjW IlXgCd6faEPCrACwiNkW8oK3kg== X-Google-Smtp-Source: ABdhPJx+5DiyWRtIEGLyiGVqicINU54+D0YnG73guEsQ32Bjev9YYltzqnAysW7kXJmhNkUAWgQb0A== X-Received: by 2002:a1c:2041:: with SMTP id g62mr21918548wmg.145.1619528193919; Tue, 27 Apr 2021 05:56:33 -0700 (PDT) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id q128sm2685345wma.39.2021.04.27.05.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 05:56:33 -0700 (PDT) Date: Tue, 27 Apr 2021 13:56:31 +0100 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH 0/5] ArmPkg: OemMiscLib and Universal/Smbios improvements and fixes Message-ID: <20210427125631.GO1664@vanye> References: <20210331021619.19761-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210331021619.19761-1-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 30, 2021 at 20:16:14 -0600, Rebecca Cran wrote: > Add the set of improvements requested during the initial series to move > closer to a full/proper implementation, fix the > chassis SKU number string, and fix a typo in a comment. > > This is a breaking change wrt SbsaQemu in edk2-platforms. > > Rebecca Cran (5): > ArmPkg: Allow platforms to override PCI supported state in > SmbiosMiscDxe > ArmPkg: Allow platforms to supply more data for SMBIOS Type3 record > ArmPkg: Allow platforms to report their boot status via OemMiscLib > call > ArmPkg: Fix calculation of offset of chassis SKU Number in > SmbiosMiscDxe > ArmPkg: Fix typo of Manufacturer in comment in SmbiosMiscDxe As discussed on list, patch 1/5 was dropped. I fixed up a trailing newline in ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c from 2/5. For the remainder of the set: Reviewed-by: Leif Lindholm Pushed as 8d2012035db3..5b90b8abb404. > ArmPkg/ArmPkg.dec | 1 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 + > ArmPkg/Include/Library/OemMiscLib.h | 70 ++++++++++++++ > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 99 ++++++++++++++++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 4 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 2 +- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 20 +++- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 3 + > 8 files changed, 194 insertions(+), 6 deletions(-) > > -- > 2.26.2 >