public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, sami.mujawar@arm.com, leif@nuviainc.com,
	ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
	Bret.Barkelew@microsoft.com
Subject: [PATCH v3 02/15] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib
Date: Wed, 28 Apr 2021 11:20:07 +0100	[thread overview]
Message-ID: <20210428102020.2311-3-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210428102020.2311-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
Non-Boolean comparisons should use a compare operator
(==, !=, >, < >=, <=)

Cc: Bret Barkelew <bret.barkelew@microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---
 .../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
index 5f453d18e415..31672ae5cf4d 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
@@ -101,7 +101,7 @@ SendMemoryPermissionRequest (
   }
 
   // Check error response from Callee.
-  if (*RetVal & BIT31) {
+  if ((*RetVal & BIT31) != 0) {
     // Bit 31 set means there is an error retured
     // See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and
     // Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64.
-- 
2.17.1


  parent reply	other threads:[~2021-04-28 10:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 10:20 [PATCH v3 00/15] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
2021-04-28 10:20 ` [PATCH v3 01/15] ArmPkg: Fix Ecc error 8003 PierreGondois
2021-04-28 10:20 ` PierreGondois [this message]
2021-04-28 10:20 ` [PATCH v3 03/15] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
2021-04-28 10:20 ` [PATCH v3 04/15] ArmPlatformPkg: Document libraries in ArmPlatformPkg.dec PierreGondois
2021-04-28 10:20 ` [PATCH v3 05/15] ArmPkg: Document libraries in ArmPkg.dec PierreGondois
2021-04-28 10:20 ` [PATCH v3 06/15] ArmPkg: Re-order " PierreGondois
2021-04-28 10:20 ` [PATCH v3 07/15] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
2021-04-28 10:20 ` [PATCH v3 08/15] ArmPkg: Correct small typos PierreGondois
2021-04-28 10:20 ` [PATCH v3 09/15] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
2021-04-28 10:20 ` [PATCH v3 10/15] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
2021-04-28 10:20 ` [PATCH v3 11/15] .pytool: Enable CI for ArmPkg PierreGondois
2021-04-28 10:20 ` [PATCH v3 12/15] .pytool: Enable CI for ArmPlatformPkg PierreGondois
2021-04-28 10:20 ` [PATCH v3 13/15] .pytool: Document LicenseCheck and EccCheck PierreGondois
2021-04-28 10:20 ` [PATCH v3 14/15] AzurePipelines: Add support for ArmPkg PierreGondois
2021-04-28 10:20 ` [PATCH v3 15/15] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
2021-04-28 13:00 ` [PATCH v3 00/15] ArmPkg/ArmPlatformPkg CI enablement Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210428102020.2311-3-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox