public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, sami.mujawar@arm.com, leif@nuviainc.com,
	ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
	Bret.Barkelew@microsoft.com
Subject: [PATCH v3 03/15] ArmPkg: Add missing library headers to ArmPkg.dec
Date: Wed, 28 Apr 2021 11:20:08 +0100	[thread overview]
Message-ID: <20210428102020.2311-4-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210428102020.2311-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <Pierre.Gondois@arm.com>

Some library headers are missing/incorrect in ArmPkg.dec.
This makes the 'LibraryClassCheck' CI test fail. This patch
adds/corrects them.

According to .pytool/Readme about the 'LibraryClassCheck' test:
This test scans at all library header files found in the
`Library` folders in all of the package's declared include
directories and ensures that all files have a matching
LibraryClass declaration in the DEC file for the package.

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3254
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3258
Cc: Bret Barkelew <bret.barkelew@microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---
 ArmPkg/ArmPkg.dec | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
index a8a22c649ff8..496f588bd0ca 100644
--- a/ArmPkg/ArmPkg.dec
+++ b/ArmPkg/ArmPkg.dec
@@ -2,7 +2,7 @@
 # ARM processor package.
 #
 # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
-# Copyright (c) 2011 - 2018, ARM Limited. All rights reserved.
+# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved.
 #
 #    SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -29,14 +29,20 @@ [Includes.common]
 [LibraryClasses.common]
   ArmLib|Include/Library/ArmLib.h
   ArmMmuLib|Include/Library/ArmMmuLib.h
-  SemihostLib|Include/Library/Semihosting.h
+  SemihostLib|Include/Library/SemihostLib.h
   DefaultExceptionHandlerLib|Include/Library/DefaultExceptionHandlerLib.h
   ArmDisassemblerLib|Include/Library/ArmDisassemblerLib.h
   ArmGicArchLib|Include/Library/ArmGicArchLib.h
-  ArmMtlLib|ArmPlatformPkg/Include/Library/ArmMtlLib.h
+  ArmMtlLib|Include/Library/ArmMtlLib.h
   ArmSvcLib|Include/Library/ArmSvcLib.h
   OpteeLib|Include/Library/OpteeLib.h
   StandaloneMmMmuLib|Include/Library/StandaloneMmMmuLib.h
+  ArmGenericTimerCounterLib|Include/Library/ArmGenericTimerCounterLib.h
+  ArmGicLib|Include/Library/ArmGicLib.h
+  ArmHvcLib|Include/Library/ArmHvcLib.h
+  OemMiscLib|Include/Library/OemMiscLib.h
+  ArmSmcLib|Include/Library/ArmSmcLib.h
+
 
 [Guids.common]
   gArmTokenSpaceGuid       = { 0xBB11ECFE, 0x820F, 0x4968, { 0xBB, 0xA6, 0xF7, 0x6A, 0xFE, 0x30, 0x25, 0x96 } }
-- 
2.17.1


  parent reply	other threads:[~2021-04-28 10:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 10:20 [PATCH v3 00/15] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
2021-04-28 10:20 ` [PATCH v3 01/15] ArmPkg: Fix Ecc error 8003 PierreGondois
2021-04-28 10:20 ` [PATCH v3 02/15] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib PierreGondois
2021-04-28 10:20 ` PierreGondois [this message]
2021-04-28 10:20 ` [PATCH v3 04/15] ArmPlatformPkg: Document libraries in ArmPlatformPkg.dec PierreGondois
2021-04-28 10:20 ` [PATCH v3 05/15] ArmPkg: Document libraries in ArmPkg.dec PierreGondois
2021-04-28 10:20 ` [PATCH v3 06/15] ArmPkg: Re-order " PierreGondois
2021-04-28 10:20 ` [PATCH v3 07/15] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
2021-04-28 10:20 ` [PATCH v3 08/15] ArmPkg: Correct small typos PierreGondois
2021-04-28 10:20 ` [PATCH v3 09/15] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
2021-04-28 10:20 ` [PATCH v3 10/15] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
2021-04-28 10:20 ` [PATCH v3 11/15] .pytool: Enable CI for ArmPkg PierreGondois
2021-04-28 10:20 ` [PATCH v3 12/15] .pytool: Enable CI for ArmPlatformPkg PierreGondois
2021-04-28 10:20 ` [PATCH v3 13/15] .pytool: Document LicenseCheck and EccCheck PierreGondois
2021-04-28 10:20 ` [PATCH v3 14/15] AzurePipelines: Add support for ArmPkg PierreGondois
2021-04-28 10:20 ` [PATCH v3 15/15] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
2021-04-28 13:00 ` [PATCH v3 00/15] ArmPkg/ArmPlatformPkg CI enablement Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210428102020.2311-4-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox