* [PATCH v1 0/1] Sample unit test hangs when running in OVMF/QEMU @ 2021-04-29 17:43 getnatejigu 2021-04-29 17:43 ` [PATCH v1 1/1] UnitTestFrameworkPkg: " Getnat Ejigu 0 siblings, 1 reply; 4+ messages in thread From: getnatejigu @ 2021-04-29 17:43 UTC (permalink / raw) To: devel *** BLURB HERE *** Getnat Ejigu (1): UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU 2021-04-29 17:43 [PATCH v1 0/1] Sample unit test hangs when running in OVMF/QEMU getnatejigu @ 2021-04-29 17:43 ` Getnat Ejigu 2021-04-30 3:33 ` [EXTERNAL] " Bret Barkelew 0 siblings, 1 reply; 4+ messages in thread From: Getnat Ejigu @ 2021-04-29 17:43 UTC (permalink / raw) To: devel; +Cc: Michael D Kinney, Sean Brogan, Bret Barkelew Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c @@ -12,6 +12,7 @@ #include <Library/DebugLib.h> VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU 2021-04-29 17:43 ` [PATCH v1 1/1] UnitTestFrameworkPkg: " Getnat Ejigu @ 2021-04-30 3:33 ` Bret Barkelew 2021-04-30 16:12 ` Getnat Ejigu 0 siblings, 1 reply; 4+ messages in thread From: Bret Barkelew @ 2021-04-30 3:33 UTC (permalink / raw) To: Getnat Ejigu, devel@edk2.groups.io; +Cc: Kinney, Michael D, Sean Brogan [-- Attachment #1: Type: text/plain, Size: 1737 bytes --] This change should also be made in: UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLibDebugLib.c UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLib.c (for the prototype) - Bret From: Getnat Ejigu<mailto:getnatejigu@gmail.com> Sent: Thursday, April 29, 2021 10:43 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com> Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> --- UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c index cfb0c5972bd1..db5402d6a210 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c @@ -12,6 +12,7 @@ #include <Library/DebugLib.h> VOID +EFIAPI ReportPrint ( IN CONST CHAR8 *Format, ... -- 2.25.1 [-- Attachment #2: Type: text/html, Size: 3831 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU 2021-04-30 3:33 ` [EXTERNAL] " Bret Barkelew @ 2021-04-30 16:12 ` Getnat Ejigu 0 siblings, 0 replies; 4+ messages in thread From: Getnat Ejigu @ 2021-04-30 16:12 UTC (permalink / raw) To: Bret Barkelew; +Cc: devel@edk2.groups.io, Kinney, Michael D, Sean Brogan [-- Attachment #1: Type: text/plain, Size: 1882 bytes --] Okay, will do. Thanks, -Getnat On Thu, Apr 29, 2021 at 11:33 PM Bret Barkelew <Bret.Barkelew@microsoft.com> wrote: > This change should also be made in: > > > UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLibDebugLib.c > > UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLib.c > (for the prototype) > > > > - Bret > > > > *From: *Getnat Ejigu <getnatejigu@gmail.com> > *Sent: *Thursday, April 29, 2021 10:43 AM > *To: *devel@edk2.groups.io > *Cc: *Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan > <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com> > *Subject: *[EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit > test hangs when running in OVMF/QEMU > > > > Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU > environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI > to ReportPrint() function that use VA_ARGS. > > Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Sean Brogan <sean.brogan@microsoft.com> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > --- > UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > index cfb0c5972bd1..db5402d6a210 100644 > --- > a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > +++ > b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > @@ -12,6 +12,7 @@ > #include <Library/DebugLib.h> > > > > VOID > > +EFIAPI > > ReportPrint ( > > IN CONST CHAR8 *Format, > > ... > > -- > 2.25.1 > > > [-- Attachment #2: Type: text/html, Size: 3473 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-30 16:12 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-04-29 17:43 [PATCH v1 0/1] Sample unit test hangs when running in OVMF/QEMU getnatejigu 2021-04-29 17:43 ` [PATCH v1 1/1] UnitTestFrameworkPkg: " Getnat Ejigu 2021-04-30 3:33 ` [EXTERNAL] " Bret Barkelew 2021-04-30 16:12 ` Getnat Ejigu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox